Am 21.01.2015 um 16:32 schrieb Jeff Mahoney:
On 1/16/15 1:36 PM, Matwey V. Kornilov wrote:
From: "Matwey V. Kornilov"
Signed-off-by: Matwey V. Kornilov
I have no problem accepting this, but I haven't seen anyone respond with a review yet.
It's a bit hard to review a patch this large... I did spot a number of missing options: For instance, LS1 is Cortex-A7, so should be enabled for both. Sun9i is Cortex-A15/-A7, so should be enabled for both. Same for PINCTRL_SUN9I_A80. Exynos4412 is enabled, so let's enable 4415 for default. Guessing that'll still be a Cortex-A9. Not sure about Meson8, I haven't heard of a 64-bit chip from Amlogic, so it's probably ARMv7, too. And since we do have Meson6 enabled, I2C_MESON should get enabled. Any reason not to enable STiH407 when 415 and 416 are enabled? While at it, isn't CSR Sirf Cortex-A9 and should be enabled in default? Also, it looks like some net additions could be =m rather than unset, also MTD_NAND_SUNXI. OF_SELFTEST not set -> OF_UNITTEST=y surprises me. Did you intentionally not enable SERIAL_8250_OMAP? Is that the one with two alternative drivers? I'll try to take this patch as base and tweak stuff on top. Having some config in place will be better than none at all. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg)