-----BEGIN PGP SIGNED MESSAGE-----
On 06/14/2012 04:53 AM, Olaf Hering wrote:
On Tue, Jun 12, Jan Beulich wrote:
While I questioned whether doing this (for a slim
benefit this might provide) is really the right thing already in
the past, bug 766284 points out another reason why this is a bad
idea. Can this be reverted (in master and 12.2 at least)?
The change below for ata_piix (and other related changes in April
2009) was made without a bugzilla or fate reference. Whats the
practical benefit of having the drivers built into the kernel? At
least ata_piix should be a module because it also drives emulated
hardware (not only in a Xen HVM guest).
The changes came out of the faster booting effort at Intel for Meego
(or Moblin, or whatever it was called then), since the initialization
can happen in parallel rather than waiting on each module to load in
the initrd as happens with a mostly-modular kernel. Greg KH added the
changes and presented numbers as to why it was faster at the time.
The fact that ata_piix is also used by emulated hardware is not a
reason to make it modular. It's a reason to fix the drivers to work
together, or to pull the functionality into the original driver.
BTW, patches.suse/suse-hv-pata_piix-ignore-disks.patch pretty clearly
violates the one-commit-per-patch rule.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
-----END PGP SIGNATURE-----
To unsubscribe, e-mail: opensuse-kernel+unsubscribe(a)opensuse.org
To contact the owner, e-mail: opensuse-kernel+owner(a)opensuse.org