-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 06/14/2012 04:53 AM, Olaf Hering wrote:
On Tue, Jun 12, Jan Beulich wrote:
While I questioned whether doing this (for a slim boot time benefit this might provide) is really the right thing already in the past, bug 766284 points out another reason why this is a bad idea. Can this be reverted (in master and 12.2 at least)?
The change below for ata_piix (and other related changes in April 2009) was made without a bugzilla or fate reference. Whats the practical benefit of having the drivers built into the kernel? At least ata_piix should be a module because it also drives emulated hardware (not only in a Xen HVM guest).
The changes came out of the faster booting effort at Intel for Meego (or Moblin, or whatever it was called then), since the initialization can happen in parallel rather than waiting on each module to load in the initrd as happens with a mostly-modular kernel. Greg KH added the changes and presented numbers as to why it was faster at the time. The fact that ata_piix is also used by emulated hardware is not a reason to make it modular. It's a reason to fix the drivers to work together, or to pull the functionality into the original driver. BTW, patches.suse/suse-hv-pata_piix-ignore-disks.patch pretty clearly violates the one-commit-per-patch rule. - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJP2ekWAAoJEB57S2MheeWyP1AQALplGP2/2nqajxbBF2CHEEdZ ATB1iOWwPWUc0hH4bbxXmrjeOYBMxdldGE9W5/M1FlPfSoPQ99eLKkbJARQP7lsQ 2JMqhpfJS3tqnqVz/W1SjV4GHzWNWtM7O4PIMKOhVlYnxDcvbAVxLwQdNeywoA9W p8+2zMGbTWRDwg27l0ugK5voxv9AM4UQAPkXmdXziIntP//UtRQeX79cO6aQT1ON piJqV8HQ4rD+MHMH5Z2lqc/oo8bISQFAVot5ySripN18RSnEjjiywsuQkroCwn4B f6kHndqsEzT3hKbObxSW7lD5v8o2LPCZUNRWKlp89h+zCmEPQ5NzmQ0YBkIFoT+/ l8U9aWi0amZMmwwItwmapAx9FLrrEKNclh/ESdLT/XpKoueMMv+yzcVWYo7MJSxQ TAcFJkcNhtpG0pgWvV5LpTiUVsfkV9/lPDh1ViBIRYLH6vkTEGWlrEpWa0K7jcgQ PnJpRKBPJ9lThkERrXVaYvSAnjnFwdAZQTfz6Y557djGNYQyTqPDIYAXjNIGpAtC XrwMX44qp9vC3qnBuwVqVNwql8vqIaCAk94bEK4+p0nKzIYsDk/1uJcaZX74F1Nb GwMX2zs5DulHikUtx20iu2BOBCuRvbMav3I7f9buwKR//WmdNw9ebkqR4Ec5Eld1 mEBNoras0f2SFJ3xBiNF =+DwQ -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org