On Monday 18 July 2011 12:13:02 pm Jean Delvare wrote:
It doesn't look like there is any default level
to set: dynamic
debugging is always off by default, and enabled on a case-by-case
basis by the user.
So, the fact that the debug message is printed means one of two
* Either debugging is enabled in the dmfe driver. Then dynamic
debugging doesn't matter.
* Or debugging isn't enabled in the dmfe driver. Dynamic debugging
must have been enabled for this driver somehow.
This can be easily verified with:
$ grep dmfe /sys/kernel/debug/dynamic_debug/control
Further investigation shows that hypothesis #1 is correct:
linux-3.0-rc7$ grep DDEBUG drivers/net/tulip/Makefile
drivers/net/tulip/Makefile:ccflags-$(CONFIG_NET_TULIP) := -DDEBUG
and the responsible is:
Author: Joe Perches <joe(a)perches.com>
Date: Mon May 9 09:45:22 2011 +0000
tulip: Convert uses of KERN_DEBUG
Convert logging messages to more current styles.
Added -DDEBUG to Makefile to maintain current message logging.
This could be converted to a specific CONFIG_TULIP_DEBUG option.
Signed-off-by: Joe Perches <joe(a)perches.com>
Signed-off-by: David S. Miller <davem(a)davemloft.net>
The "maintain current message logging" part apparently doesn't apply
to the dfme driver, which isn't touched by the patch as it was
already using proper style for debugging messages.
The patch per-se looks good and shouldn't be reverted, but I would
question the relevance of enabling debugging by default, especially
now that dynamic debugging messages exist.
I'll turn debugging off by default in our kernel now, and propose
that change to upstream and see what they have to say.
To unsubscribe, e-mail: opensuse-kernel+unsubscribe(a)opensuse.org
For additional commands, e-mail: opensuse-kernel+help(a)opensuse.org