On Wed, 15 Aug 2018 23:02:52 +0200, Hans-Peter Jansen wrote:
Hi,
in an attempt to provide exfat-nofuse kmp for a number of our kernels[1][2], I noticed, that the signature deliberately of blockdev_direct_IO() changed between v4.4 and v4.4.140:
4.4:
static inline ssize_t blockdev_direct_IO(struct kiocb *iocb, struct inode *inode, struct iov_iter *iter, loff_t offset, get_block_t get_block)
4.4.140:
static inline ssize_t blockdev_direct_IO(struct kiocb *iocb, struct inode *inode, struct iov_iter *iter, get_block_t get_block)
You might notice, 4.4.140 lost the offset argument. Apart from being hard to imagine, how this argument became obsolete, and given, that it reappeared for v4.5, that reveals 2 questions: * Doesn't this violate the rules of kernel sublevel updates?
Well, it's not done through "updates". This inline function change was seen from the very beginning of SLE12-SP3 / Leap 42.3 kernel releases; i.e. a backport of an upstream change along with SP2->SP3 upgrade. So please apply the patch conditionally for SLE12-SP3 and Leap 42.3 kernels.
* How can I investigate, at which point this version got lost?
FWIW, it's a backport from 4.7 kernel.
In other words, is there a git tree, that happens to carry *all* sublevel updates (Greg's tree?), where I can git blame include/linux/fs.h and is this something to be expected?
You can see it in the expanded kernel tree, http://kernel.opensuse.org/ thanks, Takashi
Thanks for your patience.
Cheers, Pete
[1] https://build.opensuse.org/package/show/home:frispete:kernel/exfat-nofuse [2] https://github.com/frispete/exfat-nofuse -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
-- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org