On Mon, 23 Jul 2018 07:10:58 +0200, Michal Kubecek wrote:
On Wednesday, 18 July 2018 11:28 Andreas Schwab wrote:
This is needed for building include/generated/timeconst.h from kernel/time/timeconst.bc. --- rpm/kernel-source.spec.in | 1 + 1 file changed, 1 insertion(+)
diff --git a/rpm/kernel-source.spec.in b/rpm/kernel-source.spec.in index f58b8946a0..2d80c45883 100644 --- a/rpm/kernel-source.spec.in +++ b/rpm/kernel-source.spec.in @@ -118,6 +118,7 @@ Prefix: /usr/src # Source is only complete with devel files. Requires: kernel-devel%variant = %version-%source_rel Recommends: openssl-devel +Requires: bc
%(chmod +x %_sourcedir/{@SCRIPTS@})
I'm not sure about this.
1. People install kernel-source for various reasons, not always to be able to build whole kernel. Some only want to check the sources (sure, it would be easier to use git), some want to build an out of tree module (and don't know that's what -devel packages are for) etc.
True.
2. If we really want kernel-source to have hard requirement for tools needed to build the kernel, we should be consistent and require all of them, not just pick one. We would have to require at least flex, bison and libelf-devel, maybe more. Right now, there is only "Recommends: openssl-devel".
Yeah, a good point. Moving the items that are in BuildRequires to be Requires in kernel-*-devel sounds like a better idea. thanks, Takashi -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org