Re: How to package telegram-desktop with dependency of openh264?
I can try with adding openSUSE-repos. Can I have a code pointer of how to enable it in obs build? Best, Xu -- Xu Zhao i@xuzhao.net On Thu, Aug 1, 2024, at 11:30 AM, Lubos Kocman wrote:
Hmm what about putting a dependency on openSUSE-repos which enables by default openh264 repo? But that would not ensure installation of the package I guess telegram could then suggests the installation of openh264 It sound a bit fragile to be honest. Any other ideas?
Best regards
Luboš Kocman openSUSE Leap Release Manager
čt 1. 8. 2024 v 15:55 odesílatel Xu Zhao <i@xuzhao.net> napsal:
Hello all,
I am the maintainer of telegram-desktop package in OSS and I am seeking advice about how to update the package as its recent change is blocked by openSUSE's openh264 license issue.
2 weeks ago, tg_owt made a commit to use system-level openh264 instead of bundled version (https://github.com/desktop-app/tg_owt/commit/204f1abf4646a77b5c6903bd2cc8501...), this will break the build of telegram-desktop on b.o.o obs because on opensuse openh264 is distributed separately at https://codecs.opensuse.org/openh264/openSUSE_Tumbleweed/x86_64/.
I can think of the following options: 1. patch tg_owt to make openh264 an optional dependency instead of hard dependency, but this will probably be rejected by upsteam and we have to maintain our own patchset. 2. bundle openh264 library with tg_owt and maintain the previous behavior, but I am not sure if this will violate the rules of OBS 3. delete telegram-desktop package on b.o.o (https://build.opensuse.org/package/show/server:messaging/telegram-desktop) and ask users to use the flatpak version 4. if there is a plan to push openh264 into OSS factory, we can keep telegram-desktop and wait until openh264 is available in OSS factory repo.
Please advice on which option we should take, or if you have other opinions. Your advice is much appreciated.
Best, Xu Zhao
-- Xu Zhao i@xuzhao.net
Hi Lubos, On Thu, 01 Aug 2024, 18:14:41 +0200, Xu Zhao wrote:
I can try with adding openSUSE-repos. Can I have a code pointer of how to enable it in obs build?
the multimedia:libs:openh264 repo is as closed as it can be! I honestly did not find a way to get access to it. Adding a tarball for openh264 is definitly not an acceptable choice either, so I'm assuming there is *no* way for telegram-desktop in openSUSE anymore. Let's get rid of it!
Best, Xu
Cheers. l8er manfred
On Thu, Aug 1, 2024, at 11:30 AM, Lubos Kocman wrote:
Hmm what about putting a dependency on openSUSE-repos which enables by default openh264 repo? But that would not ensure installation of the package I guess telegram could then suggests the installation of openh264 It sound a bit fragile to be honest. Any other ideas?
Best regards
Luboš Kocman openSUSE Leap Release Manager
čt 1. 8. 2024 v 15:55 odesílatel Xu Zhao <i@xuzhao.net> napsal:
Hello all,
I am the maintainer of telegram-desktop package in OSS and I am seeking advice about how to update the package as its recent change is blocked by openSUSE's openh264 license issue.
2 weeks ago, tg_owt made a commit to use system-level openh264 instead of bundled version (https://github.com/desktop-app/tg_owt/commit/ 204f1abf4646a77b5c6903bd2cc8501c7ef50ec3), this will break the build of telegram-desktop on b.o.o obs because on opensuse openh264 is distributed separately at https://codecs.opensuse.org/openh264/ openSUSE_Tumbleweed/x86_64/.
I can think of the following options: 1. patch tg_owt to make openh264 an optional dependency instead of hard dependency, but this will probably be rejected by upsteam and we have to maintain our own patchset. 2. bundle openh264 library with tg_owt and maintain the previous behavior, but I am not sure if this will violate the rules of OBS 3. delete telegram-desktop package on b.o.o (https://build.opensuse.org /package/show/server:messaging/telegram-desktop) and ask users to use the flatpak version 4. if there is a plan to push openh264 into OSS factory, we can keep telegram-desktop and wait until openh264 is available in OSS factory repo.
Please advice on which option we should take, or if you have other opinions. Your advice is much appreciated.
Best, Xu Zhao
-- Xu Zhao i@xuzhao.net
Am Donnerstag, 1. August 2024, 21:08:51 MESZ schrieb Manfred Hollstein:
.... so I'm assuming there is *no* way for telegram-desktop in openSUSE anymore. Let's get rid of it!
Bad idea.....I guess not only I am using it heavily Cheers Axel
Hello Menfred, this is done on purpose so we do not redistribute it via internal repo etc, I believe that you can still build against that library in openSUSE:Factory I see that openSUSE:Factory:openh264/openh264 links to openSUSE:Factory / openh264 Lubos On Thu, Aug 1, 2024 at 9:08 PM Manfred Hollstein <mhollstein@t-online.de> wrote:
Hi Lubos,
On Thu, 01 Aug 2024, 18:14:41 +0200, Xu Zhao wrote:
I can try with adding openSUSE-repos. Can I have a code pointer of how to enable it in obs build?
the multimedia:libs:openh264 repo is as closed as it can be! I honestly did not find a way to get access to it. Adding a tarball for openh264 is definitly not an acceptable choice either, so I'm assuming there is *no* way for telegram-desktop in openSUSE anymore. Let's get rid of it!
Best, Xu
Cheers.
l8er manfred
On Thu, Aug 1, 2024, at 11:30 AM, Lubos Kocman wrote:
Hmm what about putting a dependency on openSUSE-repos which enables by default openh264 repo? But that would not ensure installation of the package I guess telegram could then suggests the installation of openh264 It sound a bit fragile to be honest. Any other ideas?
Best regards
Luboš Kocman openSUSE Leap Release Manager
čt 1. 8. 2024 v 15:55 odesílatel Xu Zhao <i@xuzhao.net> napsal:
Hello all,
I am the maintainer of telegram-desktop package in OSS and I am seeking advice about how to update the package as its recent change is blocked by openSUSE's openh264 license issue.
2 weeks ago, tg_owt made a commit to use system-level openh264 instead of bundled version (https://github.com/desktop-app/tg_owt/commit/ 204f1abf4646a77b5c6903bd2cc8501c7ef50ec3), this will break the build of telegram-desktop on b.o.o obs because on opensuse openh264 is distributed separately at https://codecs.opensuse.org/openh264/ openSUSE_Tumbleweed/x86_64/.
I can think of the following options: 1. patch tg_owt to make openh264 an optional dependency instead of hard dependency, but this will probably be rejected by upsteam and we have to maintain our own patchset. 2. bundle openh264 library with tg_owt and maintain the previous behavior, but I am not sure if this will violate the rules of OBS 3. delete telegram-desktop package on b.o.o (https://build.opensuse.org /package/show/server:messaging/telegram-desktop) and ask users to use the flatpak version 4. if there is a plan to push openh264 into OSS factory, we can keep telegram-desktop and wait until openh264 is available in OSS factory repo.
Please advice on which option we should take, or if you have other opinions. Your advice is much appreciated.
Best, Xu Zhao
-- Xu Zhao i@xuzhao.net
-- Best regards Luboš Kocman openSUSE Leap Release Manager
On Fri, 2024-08-02 at 10:23 +0200, Lubos Kocman via openSUSE Factory wrote:
Hello Menfred,
this is done on purpose so we do not redistribute it via internal repo etc, I believe that you can still build against that library in openSUSE:Factory I see that openSUSE:Factory:openh264/openh264 links to openSUSE:Factory / openh264
Not really, no - openSUSE:Factory openh264 is merely a package container but does not produce any artifacts in openSUSE:Factory; it's just there so maintainers do not have to remember that this lives somewhere else. It's not building in Factory and there are no binaries published. A package must not be in factory if it is not installable without further repositories enabled (recommends are fine - but then the app needs to work without that repo, be it with limited features) Cheers, Dominique
On Fri, 02 Aug 2024, 11:55:18 +0200, Dominique Leuenberger wrote:
On Fri, 2024-08-02 at 10:23 +0200, Lubos Kocman via openSUSE Factory wrote:
Hello Menfred,
this is done on purpose so we do not redistribute it via internal repo etc, I believe that you can still build against that library in openSUSE:Factory I see that openSUSE:Factory:openh264/openh264 links to openSUSE:Factory / openh264
Not really, no - openSUSE:Factory openh264 is merely a package container but does not produce any artifacts in openSUSE:Factory; it's just there so maintainers do not have to remember that this lives somewhere else.
It's not building in Factory and there are no binaries published.
A package must not be in factory if it is not installable without further repositories enabled (recommends are fine - but then the app needs to work without that repo, be it with limited features)
I hope the package will not get removed ;-) I branched it into my own project, built it and disabled publishing the built packages, but use them for building. This way I succeeded to build telegram-desktop now. Trouble will be when building it in Factory however... Still don't see a valid option :-( My current status can be seen at <https://build.opensuse.org/project/show/home:manfred-h:server:messaging>
Cheers, Dominique
Cheers. l8er manfred
Hi there, On Fri, 02 Aug 2024, 12:04:04 +0200, Manfred Hollstein wrote:
On Fri, 02 Aug 2024, 11:55:18 +0200, Dominique Leuenberger wrote:
On Fri, 2024-08-02 at 10:23 +0200, Lubos Kocman via openSUSE Factory wrote:
Hello Menfred,
this is done on purpose so we do not redistribute it via internal repo etc, I believe that you can still build against that library in openSUSE:Factory I see that openSUSE:Factory:openh264/openh264 links to openSUSE:Factory / openh264
Not really, no - openSUSE:Factory openh264 is merely a package container but does not produce any artifacts in openSUSE:Factory; it's just there so maintainers do not have to remember that this lives somewhere else.
It's not building in Factory and there are no binaries published.
A package must not be in factory if it is not installable without further repositories enabled (recommends are fine - but then the app needs to work without that repo, be it with limited features)
I hope the package will not get removed ;-) I branched it into my own project, built it and disabled publishing the built packages, but use them for building. This way I succeeded to build telegram-desktop now. Trouble will be when building it in Factory however... Still don't see a valid option :-(
My current status can be seen at
<https://build.opensuse.org/project/show/home:manfred-h:server:messaging>
While I have been able to successfully build telegram-desktop-5.3.0, the next "issue" popped up early today. v5.3.1 now requires another new external module, which does not exist in tg_owt and which we don't have in openSUSE: <https://github.com/ada-url/ada.git> The tdesktop maintainer in github is not actually any distribution friendly as he adds random stuff which does not necessarily exist in a Linux distribution. He even used (and required) beta versions of central packages like glib which we cannot and will not impose on our users. I have seen too many similar challenges and I'm now at the point to give up on this package. It is clearly my impression that this package cannot be maintained properly within openSUSE. If one really needs to use this package, I'd suggest to download the packages that usually get built in github, such as: <https://github.com/telegramdesktop/tdesktop/releases/download/v5.3.1/tsetup.5.3.1.tar.xz> I leave my current status available in my home project, but I remove my maintainer role for server:messaging/telegram-desktop Cheers. l8er manfred
participants (5)
-
Axel Braun -
Dominique Leuenberger -
Lubos Kocman -
Manfred Hollstein -
Xu Zhao