Re: DKMS / weak-modules (was Re: ZoL 2.0 on Leap 15.1?)

On Mo, 2021-06-14 at 10:44 +0300, Andrei Borzenkov wrote:

On Mon, Jun 14, 2021 at 10:00 AM Martin Wilck It is just different calling conventions. dkms does

list_each_installed_module "$module" "$kernelver" "$arch" | ${weak_modules} ${weak_modules_no_initrd} --add-modules

and weak-modules2 does not have --add-modules option nor does it accept a list of modules on stdin.

Right. It expects KMPs as input, not bare .ko files. There's the  --add-kernel-modules option, but that doesn't create weak links, it' only meant for kernel-default-extra and the like. So, there _is_ some reason to keep weak-modules. In particular, dkms should require or at least recommend it. And we should set WEAK_MODULES_BIN in /etc/sysconfig/module-init-tools, as this is where DKMS looks for the tool. Can anyone confirm that DKMS actually *works* with weak-modules as shipped in the suse-module-tools-legacy package, if WEAK_MODULES_BIN=/usr/lib/module-init-tools/weak-modules is set? Martin