On úterý 2. února 2016 8:35:56 CET Marcus Meissner wrote:
On Tue, Feb 02, 2016 at 12:49:46AM +0100, Dominique Leuenberger / DimStar wrote:
Michal, et.al.
- add "V=1" to make Why? To make build warnings harder to see?
A constant battle - I know that one. I myself consider V=1 great for debug perpose... as long as gcc's warnings are there if it's not specified, I don't enable it.
Actually we are parsing the gcc commandline to spot if you are using optflags and do some post build checks. (post-build-checks, check_gcc) Indeed there are actually several cases when lack of of usage of optflags was not observed due to silent build, such as in ninja, thin-provisioning tools and himeno - and those are just few cases which I noticed in last few days.
- add %{?_smp_mflags} also to make install Well, why not. But definitely not _after_ the argument.
Parallel installation - how big is that package :) I doubt it makes much difference (but then: the latest version of spec-cleaner does this automatically IIRC - so the submitter might not have done this explicitly)
I fixed several packages that build fine with -j2 but did not with -j8, which was annoying. so this actually has the cause to break things, but it is rare.
Ciao, Marcus