On 02/15/2011 04:25 PM, Michael Meeks wrote:
On Tue, 2011-02-15 at 12:35 +0100, Duncan Mac-Vicar P. wrote:
It still shows packages and patches, however, it does not use a handcrafted logic to find candidates but ZYpp solver, therefore it should respect "zypper up" no-uninstall, vendor policies, locks, etc.
Ooh ! :-) finally the love from a zypp afficionado to do the other half of fixing the zypp PK backend :-)
I'd love to read the diff, as no doubt would Zhang Qiang, hopefully you fixed some of the create-a-new-iterator-to-check-end type problems that were in there too ? :-)
https://build.opensuse.org/package/view_file?file=use-system-solve.patch&package=PackageKit&project=home%3Admacvicar&srcmd5=3cebc65db4b3f54f22feff58a4e79c75 There is some noise in the patch as my emacs has trailing whitespace removal :-/ The interesting part is: zypp_get_package_updates If choosing the update candidates would be as easy as looking for bigger versions of the same arch, why would we have a solver at all? :-) I haven't fixed anything else, just s/handcrafted candidate logic/doSystemUpdate/ and added an option to hide packages from the list on /etc/PackageKit/ZYpp.conf. There is other stuff to clean up. Sometimes the sat:: classes are used without a reason (those are the low level ones) solvable->getAttribute(ATTRIBUT_FOO) is unneeded when you have package.foo() and stuff like that. -- Duncan Mac-Vicar P. - Novell® Making IT Work As One™ SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg) -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org