On 31.07.21 18:11, Cristian Rodríguez wrote:
On Sat, Jul 31, 2021 at 7:27 AM Philipp Wagner <mail@philipp-wagner.com> wrote:
Another thing to check for: OpenLDAP used to provide a thread-safe library "libldap_r". In OpenSUSE (and Fedora at least), we symlinked this library to "libldap" for a while. In OpenLDAP 2.5 the "libldap_r" library is gone and one should always use "libldap". To check if you can migrate easily, check for code that links against libldap_r/-lldap_r and replace it with "-lldap". That already works today and shouldn't make a difference, apart from being forward-compatible. If that turns out infeasible we can introduce a compat-symlink to libldap_r.
No, don't . if one library is no longer provided one cannot replace it with symlinks and expect it to work. the best case is the program failing to start.. worst case, the program pretending to work and doing crazy things with your data.
The situation is a bit different here. Right now, we're shipping libldap which points to libldap_r; see https://bugzilla.opensuse.org/show_bug.cgi?id=996551 for the full story. So the two libraries are identical, and have been for a couple years now. One could argue that we shouldn't provide a libldap_r symlink now that this library is gone, and instead force users to update their builds. I don't really see the need for a "flag day" conversion here, though. FWIW, I honored Michael's request and updated the package to include the symlink now. (I also fixed a packaging error on my side that Jan pointed out. Thanks!) Philipp