On Thu, 18 Feb 2021, Jan Kara wrote:
On Thu 18-02-21 09:08:09, Lubos Kocman wrote:
* Autoconf 2.71: some backwards incompatible changes, and implicitly starts gtkdocize in case configure.ac contains GTK_DOC_CHECK; Especially for ring0 packages, this is painful, as we cannot add gtk- doc dependenices there. Those packages need to GTKDOCIZE=true before running autoreconf (most don't need to run autoreconf, unless they patch configure - upstream your patches!)
This caught my eye since I'm maintainer of one such package (e2fsprogs) which runs autoreconf. I thought it is needed because our build system may provide some modified autoconf macros and so we need to regenerate the configure script. Was I just mistaken and this isn't needed?
In the past we've smuggled support for new architectures into packages
libtool via libtoolize called from autoreconf, yes. But I wouldn't
call this the best idea and thus generally recommend against doing
unconditional autoreconf & friends (I'd even recomment patching
generated files if you patch configury with SUSE specific packages).
A linter that checks for patches to .ac/.am without patching generated
files and not calling autoreconf might be useful to catch no-op patch
parts - not sure how reliable that could be.
Richard.
--
Richard Biener