Hello community, here is the log from the commit of package rpmlint for openSUSE:Factory checked in at Fri Feb 26 01:10:48 CET 2010. -------- --- rpmlint/rpmlint.changes 2010-02-19 12:21:58.000000000 +0100 +++ /mounts/work_src_done/STABLE/rpmlint/rpmlint.changes 2010-02-25 15:21:06.000000000 +0100 @@ -1,0 +2,5 @@ +Thu Feb 25 14:20:42 UTC 2010 - lnussel@suse.de + +- update and enable CheckPolkitPrivs + +------------------------------------------------------------------- calling whatdependson for head-i586 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ rpmlint.spec ++++++ --- /var/tmp/diff_new_pack.0QBS42/_old 2010-02-26 01:10:09.000000000 +0100 +++ /var/tmp/diff_new_pack.0QBS42/_new 2010-02-26 01:10:09.000000000 +0100 @@ -23,7 +23,7 @@ BuildRequires: rpm-python Summary: Rpm correctness checker Version: 0.92 -Release: 3 +Release: 4 Source0: %{name}-%{version}.tar.bz2 Source1: config Source1001: config.in ++++++ CheckPolkitPrivs.py ++++++ --- /var/tmp/diff_new_pack.0QBS42/_old 2010-02-26 01:10:10.000000000 +0100 +++ /var/tmp/diff_new_pack.0QBS42/_new 2010-02-26 01:10:10.000000000 +0100 @@ -8,20 +8,20 @@ from Filter import * import AbstractCheck +import Config import re import os from xml.dom.minidom import parse -_whitelist = () +POLKIT_PRIVS_WHITELIST = Config.getOption('PolkitPrivsWhiteList', ()) # set of file names +POLKIT_PRIVS_FILES = Config.getOption('PolkitPrivsFiles', [ "/etc/polkit-default-privs.standard" ]) class PolkitCheck(AbstractCheck.AbstractCheck): def __init__(self): AbstractCheck.AbstractCheck.__init__(self, "CheckPolkitPrivs") self.privs = {} - files = [ "/etc/polkit-default-privs.standard" ] - - for file in files: + for file in POLKIT_PRIVS_FILES: if os.path.exists(file): self._parsefile(file) @@ -36,7 +36,6 @@ self.privs[priv] = value def check(self, pkg): - global _whitelist if pkg.isSource(): return @@ -52,7 +51,7 @@ if f.startswith("/etc/polkit-default-privs.d/"): bn = f[28:] - if not bn in _whitelist: + if not bn in POLKIT_PRIVS_WHITELIST: printError(pkg, "polkit-unauthorized-file", f) bn = bn.split('.')[0] @@ -76,7 +75,8 @@ # catch xml exceptions try: - if f.startswith("/usr/share/PolicyKit/policy/"): + if f.startswith("/usr/share/PolicyKit/policy/")\ + or f.startswith("/usr/share/polkit-1/actions/"): f = pkg.dirName() + f xml = parse(f) for a in xml.getElementsByTagName("action"): ++++++ config ++++++ --- /var/tmp/diff_new_pack.0QBS42/_old 2010-02-26 01:10:10.000000000 +0100 +++ /var/tmp/diff_new_pack.0QBS42/_new 2010-02-26 01:10:10.000000000 +0100 @@ -27,7 +27,7 @@ addCheck("BrandingPolicyCheck") addCheck("CheckSUIDPermissions") # polkit-default-privs would need to be installed always -#addCheck("CheckPolkitPrivs") +addCheck("CheckPolkitPrivs") addCheck("CheckDBUSServices") addCheck("CheckDBusPolicy") addCheck("CheckFilelist") ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun... -- To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-commit+help@opensuse.org