Hello community, here is the log from the commit of package yast2-cluster for openSUSE:Factory checked in at 2017-11-01 11:09:52 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2-cluster (Old) and /work/SRC/openSUSE:Factory/.yast2-cluster.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "yast2-cluster" Wed Nov 1 11:09:52 2017 rev:19 rq:537876 version:4.0.0 Changes: -------- --- /work/SRC/openSUSE:Factory/yast2-cluster/yast2-cluster.changes 2017-04-07 13:56:38.131265290 +0200 +++ /work/SRC/openSUSE:Factory/.yast2-cluster.new/yast2-cluster.changes 2017-11-01 11:09:50.757318186 +0100 @@ -1,0 +2,6 @@ +Fri Oct 27 08:35:58 UTC 2017 - nwang@suse.com + +- bsc#1065393, remove checking bind address when unicast. +- Version 4.0.0 + +------------------------------------------------------------------- Old: ---- yast2-cluster-3.2.0.tar.bz2 New: ---- yast2-cluster-4.0.0.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-cluster.spec ++++++ --- /var/tmp/diff_new_pack.SwkEMH/_old 2017-11-01 11:09:51.293298609 +0100 +++ /var/tmp/diff_new_pack.SwkEMH/_new 2017-11-01 11:09:51.293298609 +0100 @@ -18,7 +18,7 @@ Name: yast2-cluster %define _fwdefdir /etc/sysconfig/SuSEfirewall2.d/services -Version: 3.2.0 +Version: 4.0.0 Release: 0 BuildRoot: %{_tmppath}/%{name}-%{version}-build ++++++ yast2-cluster-3.2.0.tar.bz2 -> yast2-cluster-4.0.0.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-cluster-3.2.0/Makefile.am.common new/yast2-cluster-4.0.0/Makefile.am.common --- old/yast2-cluster-3.2.0/Makefile.am.common 2017-04-06 03:51:03.655446224 +0200 +++ new/yast2-cluster-4.0.0/Makefile.am.common 1970-01-01 01:00:00.000000000 +0100 @@ -1,47 +0,0 @@ -# Makefile.am.common -*- Makefile -*- -# Generated file, do not edit! - -modulebin_DATA = $(patsubst %.ycp,%.ybc,$(module_DATA)) -modulebindir = $(moduledir) - -ybcfiles = $(filter %.ybc,$(modulebin_DATA)) - -# suffix mapping: info '(make)Static Usage' -# apply only to our modules, not external ones -${ybcfiles}: %.ybc: %.ycp $(ycpchook) - Y2DIR=$(YCPC_Y2DIR) LD_LIBRARY_PATH=$(YCPC_LD_LIBRARY_PATH) ${YCPC} -c -M. -I. -q $(YCPCFLAGS) $< - -# files to clean -CLEANFILES = ${ybcfiles} -DISTCLEANFILES = .dep - -# Needs to be outside "." because of cases -# where ycpchook contains a symlink to "." -# Otherwise "." keeps being newer than .dep and we loop. -NEWDEP=${top_builddir}/.dep.new -# generate dependencies -# two steps not to lose the file if the command fails -# hook: create the links before we look for files -.dep: $(wildcard *.ycp) ${ycpchook} - ${YCPMAKEDEP} --prefix=${prefix} ${YCPCFLAGS} > ${NEWDEP} - cat ${NEWDEP} > .dep - rm ${NEWDEP} - -dist-hook: check-syntax - -CHECK_SYNTAX = true -check-syntax: $(client_DATA) $(ycpchook) - @if test "$(client_DATA)"; then \ - if $(CHECK_SYNTAX); then \ - TO_CHECK="$(filter %.ycp,$^)"; \ - echo "Checking syntax of $${TO_CHECK}"; \ - if ! $(YCPC) -qE -M. -I. $(YCPCFLAGS) $${TO_CHECK}; then \ - echo "Failed. Disable by 'make ... CHECK_SYNTAX=false' at your own risk"; \ - exit 1; \ - fi; \ - else \ - echo "Syntax check disabled"; \ - fi; \ - fi - --include .dep diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-cluster-3.2.0/package/yast2-cluster.changes new/yast2-cluster-4.0.0/package/yast2-cluster.changes --- old/yast2-cluster-3.2.0/package/yast2-cluster.changes 2017-04-06 03:51:03.659446224 +0200 +++ new/yast2-cluster-4.0.0/package/yast2-cluster.changes 2017-10-31 11:07:24.256722880 +0100 @@ -1,4 +1,10 @@ ------------------------------------------------------------------- +Fri Oct 27 08:35:58 UTC 2017 - nwang@suse.com + +- bsc#1065393, remove checking bind address when unicast. +- Version 4.0.0 + +------------------------------------------------------------------- Wed Apr 5 05:20:44 UTC 2017 - nwang@suse.com - bsc#1032419, remove bind address for unicast. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-cluster-3.2.0/package/yast2-cluster.spec new/yast2-cluster-4.0.0/package/yast2-cluster.spec --- old/yast2-cluster-3.2.0/package/yast2-cluster.spec 2017-04-06 03:51:03.659446224 +0200 +++ new/yast2-cluster-4.0.0/package/yast2-cluster.spec 2017-10-31 11:07:24.256722880 +0100 @@ -18,7 +18,7 @@ Name: yast2-cluster %define _fwdefdir /etc/sysconfig/SuSEfirewall2.d/services -Version: 3.2.0 +Version: 4.0.0 Release: 0 BuildRoot: %{_tmppath}/%{name}-%{version}-build diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-cluster-3.2.0/src/include/cluster/dialogs.rb new/yast2-cluster-4.0.0/src/include/cluster/dialogs.rb --- old/yast2-cluster-3.2.0/src/include/cluster/dialogs.rb 2017-04-06 03:51:03.663446224 +0200 +++ new/yast2-cluster-4.0.0/src/include/cluster/dialogs.rb 2017-10-31 11:07:24.260722880 +0100 @@ -189,11 +189,6 @@ # BNC#871970, change member address struct def ValidateCommunication i = 0 - if IP.Check(Convert.to_string(UI.QueryWidget(Id(:bindnetaddr1), :Value))) == false - Popup.Message(_("The Bind Network Address has to be fulfilled")) - UI.SetFocus(:bindnetaddr1) - return false - end if UI.QueryWidget(Id(:cluster_name), :Value) == "" Popup.Message(_("The cluster name has to be fulfilled")) @@ -224,6 +219,12 @@ return false end + if IP.Check(Convert.to_string(UI.QueryWidget(Id(:bindnetaddr1), :Value))) == false + Popup.Message(_("The Bind Network Address has to be fulfilled")) + UI.SetFocus(:bindnetaddr1) + return false + end + if !IP.Check(Convert.to_string(UI.QueryWidget(Id(:mcastaddr1), :Value))) Popup.Message(_("The Multicast Address has to be fulfilled")) UI.SetFocus(:mcastaddr1) @@ -241,16 +242,16 @@ end if UI.QueryWidget(Id(:enable2), :Value) - if IP.Check( - Convert.to_string(UI.QueryWidget(Id(:bindnetaddr2), :Value)) - ) == false - Popup.Message(_("The Bind Network Address has to be fulfilled")) - UI.SetFocus(:bindnetaddr2) - return false - end - if UI.QueryWidget(Id(:transport), :Value) == "udp" if IP.Check( + Convert.to_string(UI.QueryWidget(Id(:bindnetaddr2), :Value)) + ) == false + Popup.Message(_("The Bind Network Address has to be fulfilled")) + UI.SetFocus(:bindnetaddr2) + return false + end + + if IP.Check( Convert.to_string(UI.QueryWidget(Id(:mcastaddr2), :Value)) ) == false Popup.Message(_("The Multicast Address has to be fulfilled")) @@ -553,7 +554,6 @@ def fill_memberaddr_entries i = 0 - ret = 0 current = 0 items = [] @@ -627,7 +627,6 @@ if ret == :memberaddr_edit current = 0 - str = "" # The value will be nil if the list is empty, however nil.to_i is 0 current = UI.QueryWidget(:memberaddr, :CurrentItem).to_i @@ -1191,7 +1190,6 @@ if ret == :host_edit current = 0 - str = "" current = Convert.to_integer(UI.QueryWidget(:host_box, :CurrentItem)) ret = text_input_dialog(