[opensuse-buildservice] [PATCH] fix osc selection of debs for dsc builds
Use buildtype instead of expecting a dependency on debhelper patch against 7788: http://gitorious.org/mer/osc/commit/184edb3778baf4264b84afd83887b7ea23dfaae7 -- "Don't worry, you'll be fine; I saw it work in a cartoon once..." -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
Am Samstag, 1. August 2009 22:35:52 schrieb David Greaves:
Use buildtype instead of expecting a dependency on debhelper
patch against 7788:
http://gitorious.org/mer/osc/commit/184edb3778baf4264b84afd83887b7ea23dfaae 7
Can you please send a diff directly ? The patch created from the web patch leads to errors here. (and yes, I am too lazy ;) Just by looking at the patch, should the buildtype not get a default ? bye adrian -- Adrian Schroeter SUSE Linux Products GmbH email: adrian@suse.de -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
Adrian Schröter wrote:
Am Samstag, 1. August 2009 22:35:52 schrieb David Greaves:
Use buildtype instead of expecting a dependency on debhelper
patch against 7788:
http://gitorious.org/mer/osc/commit/184edb3778baf4264b84afd83887b7ea23dfaae 7
Can you please send a diff directly ? The patch created from the web patch leads to errors here. (and yes, I am too lazy ;) Sure.
OK, I did a vanilla svn checkout and a diff -ru ... visually it appears the same.
Just by looking at the patch, should the buildtype not get a default ? It's validated on line 250 and only influence pacsuffix which defaults to rpm.
I've just added a default and some class validation in keeping with the other parameters though. David -- "Don't worry, you'll be fine; I saw it work in a cartoon once..."
On 2009-08-01 21:35:52 +0100, David Greaves wrote:
Use buildtype instead of expecting a dependency on debhelper
patch against 7788: http://gitorious.org/mer/osc/commit/184edb3778baf4264b84afd83887b7ea23dfaae7
I just committed a slightly modified version of your patch (see r7797). Thanks! Marcus -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
participants (3)
-
Adrian Schröter -
David Greaves -
Marcus Hüwe