On 2010-12-31 16:39:18 +0100, Michal Marek wrote:
There is no need for the whole build process to have
the _buildinfo* and
_buildconfig* files open.
Hmm with this patch it might be possible that the temporary file isn't
unlinked (because you call NamedTemporaryFile with "delete=False").
For instance if an exception is raised before the
"if buildfiles_temporary..." check is reached the tempfiles won't be
unlinked (with "delete=True" the file will be removed whenever the
_TemporaryFileWrapper instance is "deleted").
I need to think about it again (because I want to avoid a big
Signed-off-by: Michal Marek <mmarek(a)suse.cz>
@@ -882,10 +884,9 @@ def main(apiurl, opts, argv):
for i in b_built.splitlines() + s_built.splitlines():
shutil.copy2(i, os.path.join(opts.keep_pkgs, os.path.basename(i)))
- if bi_file:
- if bc_file:
+ if buildfiles_temporary:
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe(a)opensuse.org
For additional commands, e-mail: opensuse-buildservice+help(a)opensuse.org