On 2010-12-31 16:39:18 +0100, Michal Marek wrote:
There is no need for the whole build process to have the _buildinfo* and _buildconfig* files open.
Hmm with this patch it might be possible that the temporary file isn't unlinked (because you call NamedTemporaryFile with "delete=False"). For instance if an exception is raised before the "if buildfiles_temporary..." check is reached the tempfiles won't be unlinked (with "delete=True" the file will be removed whenever the _TemporaryFileWrapper instance is "deleted"). I need to think about it again (because I want to avoid a big try-finally block)...
Signed-off-by: Michal Marek <mmarek@suse.cz> ---
<SNIP>
@@ -882,10 +884,9 @@ def main(apiurl, opts, argv): for i in b_built.splitlines() + s_built.splitlines(): shutil.copy2(i, os.path.join(opts.keep_pkgs, os.path.basename(i)))
- if bi_file: - bi_file.close() - if bc_file: - bc_file.close() - rpmlist_file.close() + if buildfiles_temporary: + os.unlink(bi_filename) + os.unlink(bc_filename) + os.unlink(rpmlist_filename)
Marcus -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org