I have been playing with OBS recently and one of the things I was trying to achieve was to improve UI for reviewing requests. I have my OBS instance running & patched although I took a few shortcuts, so to have a real submitable patch ready (not speaking about test I have no clue how to write), there is still a long way to go. But before I put more effort into it, I wanted some check whether these changes actually makes sense and would be welcomed or discuss them in general. Attaching screenshots as machine I have this running on is accessible only internally.
Overall the idea was to simplify the request webpage and get inspired by github. Get rid of too many elemnts and move stuff to tabs.
* request history, build results, rpmlint results and issues are tabbed together with diff * comments and request history merged * show by default request history (intention is to be more clever in the end - ** show diff if there is only creation in history, show history if there are reviews, comments and more...) * all actions in one tabbed window - review, decision, comment creation * cookie based seen/unseen for comments/request ** not really perfect, but helps to notice what changed since the last time * since request history is in big window, expand all comments so people can easily read all the info
What do you think? What do you like? What do you dislike? Shoot!