[Bug 620483] New: Archiving/unzip: Bug in version 6.00. Doesn't print multibyte characters.
http://bugzilla.novell.com/show_bug.cgi?id=620483 http://bugzilla.novell.com/show_bug.cgi?id=620483#c0 Summary: Archiving/unzip: Bug in version 6.00. Doesn't print multibyte characters. Classification: openSUSE Product: openSUSE.org Version: unspecified Platform: Other OS/Version: SuSE Other Status: NEW Severity: Normal Priority: P5 - None Component: 3rd party software AssignedTo: pth@novell.com ReportedBy: lazy.kent.suse@gmail.com QAContact: opensuse-communityscreening@forge.provo.novell.com Found By: --- Blocker: --- Created an attachment (id=374274) --> (http://bugzilla.novell.com/attachment.cgi?id=374274) patch isprint * unzip 5.22: % /usr/bin/unzip -l test-russian-utf8.zip Archive: test-russian-utf8.zip Length Date Time Name -------- ---- ---- ---- 24 07-07-10 16:36 тест русский.txt -------- ------- 24 1 file * unzip 6.00: % unzip-6 -l test-russian-utf8.zip Archive: test-russian-utf8.zip Length Date Time Name --------- ---------- ----- ---- 24 07-07-2010 16:36 ???????? ??????????????.txt --------- ------- 24 1 file .. % unzip-6 test-russian-utf8.zip Archive: test-russian-utf8.zip extracting: ???????? ??????????????.txt .. % ls test-russian-utf8.zip тест русский.txt unzip 6.00 doesn't print multibyte characters, but extracts correctly. Something is wrong with isprint. http://www.gnu.org/software/gnulib/manual/html_node/isprint.html We have a patch from Suren A. Chilingaryan. * unzip 6.00 patched: % unzip-6-patched -l test-russian-utf8.zip Archive: test-russian-utf8.zip Length Date Time Name --------- ---------- ----- ---- 24 07-07-2010 16:36 тест русский.txt --------- ------- 24 1 file .. % unzip-6-patched test-russian-utf8.zip Archive: test-russian-utf8.zip extracting: тест русский.txt .. % ls test-russian-utf8.zip тест русский.txt -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=620483 http://bugzilla.novell.com/show_bug.cgi?id=620483#c1 Philipp Thomas <pth@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |lazy.kent.suse@gmail.com --- Comment #1 from Philipp Thomas <pth@novell.com> 2010-07-08 11:35:22 CEST --- There's nothing wrong with isprint, it just can't deal with multibyte characters as the cited gnulib manpage. I'll try to come up with a patch that uses mbrtowc and iswprint. Could you please attach that test-russian-utf8.zip test case so I can check whether my approach works? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=620483 http://bugzilla.novell.com/show_bug.cgi?id=620483#c2 Kyrill Detinov <lazy.kent.suse@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW InfoProvider|lazy.kent.suse@gmail.com | --- Comment #2 from Kyrill Detinov <lazy.kent.suse@gmail.com> 2010-07-08 13:47:04 MSD --- Created an attachment (id=374522) --> (http://bugzilla.novell.com/attachment.cgi?id=374522) russian file name -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=620483 http://bugzilla.novell.com/show_bug.cgi?id=620483#c Philipp Thomas <pth@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium Status|NEW |ASSIGNED Version|unspecified |RC 2 Component|3rd party software |Basesystem AssignedTo|pth@novell.com |bnc-team-screening@forge.pr | |ovo.novell.com QAContact|opensuse-communityscreening |qa@suse.de |@forge.provo.novell.com | Target Milestone|--- |Factory Product|openSUSE.org |openSUSE 11.3 -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=620483 http://bugzilla.novell.com/show_bug.cgi?id=620483#c Philipp Thomas <pth@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pth@novell.com AssignedTo|bnc-team-screening@forge.pr |pth@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=620483 https://bugzilla.novell.com/show_bug.cgi?id=620483#c3 --- Comment #3 from Kyrill Detinov <lazy.kent.suse@gmail.com> 2010-09-19 16:16:40 MSD --- Info-ZIP Forum: http://www.info-zip.org/board/board.pl?m-1250835536 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=620483 https://bugzilla.novell.com/show_bug.cgi?id=620483#c4 --- Comment #4 from Kyrill Detinov <lazy.kent.suse@gmail.com> 2011-02-03 13:04:06 MSK --- bump -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=620483 https://bugzilla.novell.com/show_bug.cgi?id=620483#c Philipp Thomas <pth@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P3 - Medium |P4 - Low -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=620483 https://bugzilla.novell.com/show_bug.cgi?id=620483#c5 Andrey Gankov <gankov.andrey@inbox.ru> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gankov.andrey@inbox.ru --- Comment #5 from Andrey Gankov <gankov.andrey@inbox.ru> 2011-03-15 18:34:27 UTC --- I have this bug on openSUSE 11.4 unzip 6. before with unzip 5.22, unzip correctly extract russian name files. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=620483 https://bugzilla.novell.com/show_bug.cgi?id=620483#c6 Alexander R <aleromex@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleromex@gmail.com --- Comment #6 from Alexander R <aleromex@gmail.com> 2011-04-14 05:42:38 UTC --- Have this issue too on Opensuse 11.4 x86_64 unzip -l 111.zip Archive: 111.zip Length Date Time Name --------- ---------- ----- ---- 11264 08-11-2010 18:13 ???????????? ???????????????? ?? ???????????????????????????? ????.xls --------- ------- 11264 1 file #unzip -v UnZip 6.00 of 20 April 2009, by Info-ZIP. Maintained by C. Spieler. Send bug reports using http://www.info-zip.org/zip-bug.html; see README for details. Latest sources and executables are at ftp://ftp.info-zip.org/pub/infozip/ ; see ftp://ftp.info-zip.org/pub/infozip/UnZip.html for other sites. Compiled with gcc 4.5.1 20101208 [gcc-4_5-branch revision 167585] for Unix (Linux ELF) on Feb 22 2011. UnZip special compilation options: COPYRIGHT_CLEAN (PKZIP 0.9x unreducing method not supported) SET_DIR_ATTRIB SYMLINKS (symbolic links supported, if RTL and file system permit) TIMESTAMP UNIXBACKUP USE_EF_UT_TIME USE_UNSHRINK (PKZIP/Zip 1.x unshrinking method supported) USE_DEFLATE64 (PKZIP 4.x Deflate64(tm) supported) VMS_TEXT_CONV [decryption, version 2.11 of 05 Jan 2007] UnZip and ZipInfo environment options: UNZIP: [none] UNZIPOPT: [none] ZIPINFO: [none] ZIPINFOOPT: [none] -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=620483 https://bugzilla.novell.com/show_bug.cgi?id=620483#c7 --- Comment #7 from Alexander R <aleromex@gmail.com> 2011-05-10 06:00:08 UTC --- After "unzip" updating from home:Lazy_Kent / openSUSE_11.4 (current unzip version 6.00-6.2), an issue is solved: unzip -l /tmp/bug-620483_test-russian-utf8.zip Archive: /tmp/bug-620483_test-russian-utf8.zip Length Date Time Name --------- ---------- ----- ---- 24 07-07-2010 16:36 тест русский.txt --------- ------- 24 1 file unzip -v UnZip 6.00 of 20 April 2009, by Info-ZIP. Maintained by C. Spieler. Send bug reports using http://www.info-zip.org/zip-bug.html; see README for details. Latest sources and executables are at ftp://ftp.info-zip.org/pub/infozip/ ; see ftp://ftp.info-zip.org/pub/infozip/UnZip.html for other sites. Compiled with gcc 4.5.1 20101208 [gcc-4_5-branch revision 167585] for Unix (Linux ELF) on Apr 16 2011. UnZip special compilation options: COPYRIGHT_CLEAN (PKZIP 0.9x unreducing method not supported) SET_DIR_ATTRIB SYMLINKS (symbolic links supported, if RTL and file system permit) TIMESTAMP UNIXBACKUP USE_EF_UT_TIME USE_UNSHRINK (PKZIP/Zip 1.x unshrinking method supported) USE_DEFLATE64 (PKZIP 4.x Deflate64(tm) supported) VMS_TEXT_CONV [decryption, version 2.11 of 05 Jan 2007] UnZip and ZipInfo environment options: UNZIP: [none] UNZIPOPT: [none] ZIPINFO: [none] ZIPINFOOPT: [none] -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=620483 https://bugzilla.novell.com/show_bug.cgi?id=620483#c8 Philipp Thomas <pth@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO InfoProvider| |lazy.kent@opensuse.org --- Comment #8 from Philipp Thomas <pth@novell.com> 2011-08-05 13:49:08 CEST --- OK, I'll bite and use the patch :) Kyrill, can you do a SR to Archiving/zip that will then approve? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=620483 https://bugzilla.novell.com/show_bug.cgi?id=620483#c9 Kyrill Detinov <lazy.kent@opensuse.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED InfoProvider|lazy.kent@opensuse.org | --- Comment #9 from Kyrill Detinov <lazy.kent@opensuse.org> 2011-08-05 16:54:06 MSD --- I see you committed the patch already. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=620483 https://bugzilla.novell.com/show_bug.cgi?id=620483#c10 --- Comment #10 from Kyrill Detinov <lazy.kent@opensuse.org> 2011-08-13 01:29:16 MSD --- Do we plan maintenance update for 11.4 or close the bug? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=620483 https://bugzilla.novell.com/show_bug.cgi?id=620483#c11 Philipp Thomas <pth@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO InfoProvider| |maintenance@opensuse.org --- Comment #11 from Philipp Thomas <pth@novell.com> 2011-08-13 01:22:19 CEST --- Maintenance, is this a candidate for an 11.4 update? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=620483 https://bugzilla.novell.com/show_bug.cgi?id=620483#c12 Marcus Meissner <meissner@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |meissner@novell.com --- Comment #12 from Marcus Meissner <meissner@novell.com> 2011-08-15 12:19:36 UTC --- can you tell us the diff? is it the patch from comment0? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=620483 https://bugzilla.novell.com/show_bug.cgi?id=620483#c13 --- Comment #13 from Philipp Thomas <pth@novell.com> 2011-08-15 15:07:59 CEST --- Yes, that's the diff. As you know, isprint won't work as it depends on locale so you'd have to change at least LC_CTYPE for isprint to work as expected. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=620483 https://bugzilla.novell.com/show_bug.cgi?id=620483#c14 --- Comment #14 from Marcus Meissner <meissner@novell.com> 2011-08-15 15:28:28 UTC --- This patch might not be fully safe security wise due to 8bit control codes, these are not default enabled. mb_isprint() ? Unclear. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=620483 https://bugzilla.novell.com/show_bug.cgi?id=620483#c15 --- Comment #15 from Philipp Thomas <pth@novell.com> 2011-08-17 13:06:26 CEST --- Would that work given that the locale isn't set correctly? Upstream maintainer thinks either ASCII or utf-8 and doesn't care for anything else. That's why we have all that trouble with other encodings. And as I've never dealt with the mb* functions before I have no idea if that would work. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=620483 https://bugzilla.novell.com/show_bug.cgi?id=620483#c16 --- Comment #16 from Philipp Thomas <pth@novell.com> 2011-08-17 15:32:09 CEST --- Hmm, if you look at the code, it does if (*r < 32) { //(!isprint(*r)) { if (*r < 32) { /* ASCII control codes are escaped as "^{letter}". */ if (se != NULL && (s > (space + (size-4)))) { have_overflow = TRUE; break; } *s++ = '^', *s++ = (uch)(64 + *r++); } else { So control code are escaped. Or do I miss something? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=620483 https://bugzilla.novell.com/show_bug.cgi?id=620483#c17 --- Comment #17 from Marcus Meissner <meissner@novell.com> 2011-08-19 09:36:50 UTC --- There can be 8bit set terminal escape codes enabled on VT100. However it needs ESCAPE (0x1b) to get it enabled. isprint() on ASCII covers e.g. only 32-127, nothing above 128. I am not fully convinced allowing characters that are invalid in the current LC_CTYPE is a good idea. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=620483 https://bugzilla.novell.com/show_bug.cgi?id=620483#c18 --- Comment #18 from Marcus Meissner <meissner@suse.com> 2011-08-26 11:21:35 UTC --- .. but that said we can jsut do it with the current change. the risk is low. +1 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=620483 https://bugzilla.novell.com/show_bug.cgi?id=620483#c19 Swamp Workflow Management <swamp@suse.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard| |maint:running:42905:low --- Comment #19 from Swamp Workflow Management <swamp@suse.de> 2011-08-26 16:41:45 UTC --- The SWAMPID for this issue is 42905. This issue was rated as low. Please submit fixed packages until 2011-09-23. Also create a patchinfo file using this link: https://swamp.suse.de/webswamp/wf/42905 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=620483 https://bugzilla.novell.com/show_bug.cgi?id=620483#c20 Christian Dengler <cdengler@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED CC| |cdengler@suse.com InfoProvider|maintenance@opensuse.org | --- Comment #20 from Christian Dengler <cdengler@suse.com> 2011-08-26 16:42:29 UTC --- update started -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=620483 https://bugzilla.novell.com/show_bug.cgi?id=620483#c21 --- Comment #21 from Christian Dengler <cdengler@suse.com> 2011-08-30 16:44:01 UTC --- Patchinfo available; but be so kind and also submit the fixed sources. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=620483 https://bugzilla.novell.com/show_bug.cgi?id=620483#c22 Christian Dengler <cdengler@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |FIXED --- Comment #22 from Christian Dengler <cdengler@suse.com> 2011-09-06 15:08:27 UTC --- update released. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=620483 https://bugzilla.novell.com/show_bug.cgi?id=620483#c23 Swamp Workflow Management <swamp@suse.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|maint:running:42905:low |maint:running:42905:low | |maint:released:11.4:42911 --- Comment #23 from Swamp Workflow Management <swamp@suse.de> 2011-09-06 15:09:07 UTC --- Update released for: unzip, unzip-debuginfo, unzip-debugsource Products: openSUSE 11.4 (debug, i586, x86_64) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=620483 https://bugzilla.novell.com/show_bug.cgi?id=620483#c Swamp Workflow Management <swamp@suse.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|maint:running:42905:low |maint:released:11.4:42911 |maint:released:11.4:42911 | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=620483 http://bugzilla.novell.com/show_bug.cgi?id=620483#c24 --- Comment #24 from Bernhard Wiedemann <bwiedemann@suse.com> --- This is an autogenerated message for OBS integration: This bug (620483) was mentioned in https://build.opensuse.org/request/show/78103 Factory / unzip -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com