http://bugzilla.opensuse.org/show_bug.cgi?id=1088574 Petr Matula changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1088574 http://bugzilla.opensuse.org/show_bug.cgi?id=1088574#c1 --- Comment #1 from Petr Matula --- https://forums.opensuse.org/showthread.php/530595-Just-updated-TW-now-MSB-da... https://lists.opensuse.org/opensuse-factory/2018-04/msg00278.html -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1088574 http://bugzilla.opensuse.org/show_bug.cgi?id=1088574#c3 Aurelien Aptel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aaptel@suse.com, | |samba-maintainers@SuSE.de Assignee|samba-maintainers@SuSE.de |aaptel@suse.com --- Comment #3 from Aurelien Aptel --- This is related to bsc#1065551 and bsc#1071090. To make samba<=>systemd interactions better (first bug in the list) we changed the service files. Then things started breaking *on upgrades*. The starting flags are in the unit file which is on the vendor repo (same branch for all products) and they source /etc/sysconfig/samba (also from vendor repo) which is where we defined the daemonizing/foreground flags. But this file doesnt get updated automatically on updates it seems (see second bug). the fix is to - make sure the samba has the required systemd commits - move the foreground flags directly in the unit file, and leave the sysconfig flags empty by default (might require %post scriptlet in spec file to FORCE sysconfig update) We could use upstream sysconfig/unit files which are mostly correct but differ slightly in certain directives. This might be hard to get right so I'm more for keeping our vendor files. This will probably affect SLE15 too. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1088574 http://bugzilla.opensuse.org/show_bug.cgi?id=1088574#c5 Noel Power changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nopower@suse.com --- Comment #5 from Noel Power --- (In reply to Arjen de Korte from comment #4)

I don't think flags from /etc/sysconfig/samba and/or systemd startup files are the problem here. I updated /etc/sysconfig/samba and confirmed that the systemd files are updated.

I get exactly the same error if I run these from the commandline:

/usr/sbin/nmbd -D -F /usr/sbin/smbd -D -F

This problem was first introduced when samba went from 4.7.6 to 4.8.0, so I think we should be looking in what changed there.

as Aurelien says the problem is to do with new values (currently missing) that need to be in the systemd files (and/or) in the /etc/sysconfig/samba file As a workaround a minimal change that should get you going would be in /usr/lib/systemd/system/smb.service (nmb.service & winbind.service) do similar to -ExecStart=/usr/sbin/smbd $SMBDOPTIONS +ExecStart=/usr/sbin/smbd --foreground --no-process-group $SMBDOPTIONS systemctl daemon-reload then try and restart the services -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1088574 http://bugzilla.opensuse.org/show_bug.cgi?id=1088574#c7 --- Comment #7 from Arjen de Korte --- (In reply to Noel Power from comment #6)

(In reply to Noel Power from comment #5)

...

-ExecStart=/usr/sbin/smbd $SMBDOPTIONS +ExecStart=/usr/sbin/smbd --foreground --no-process-group $SMBDOPTIONS

and of course replacing smbd above with (nmb, winbindd) as appropriate

I just found out myself :-) This is indeed the fix. Remove the "-D -F" from the NMBDOPTIONS and SMBDOPTIONS from /etc/sysconfig/samba and adjust /usr/lib/systemd/system/nmb.service: -ExecStart=/usr/sbin/nmbd $NMBDOPTIONS +ExecStart=/usr/sbin/nmbd --foreground --no-process-group $NMBDOPTIONS /usr/lib/systemd/system/smb.service: -ExecStart=/usr/sbin/smbd $SMBDOPTIONS +ExecStart=/usr/sbin/smbd --foreground --no-process-group $SMBDOPTIONS and voila, everything is back in order. Thanks! -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1088574 http://bugzilla.opensuse.org/show_bug.cgi?id=1088574#c8 --- Comment #8 from Aurelien Aptel --- I've modified the post installation script to remove the sysconfig stuff and changed the unit file to use --foreground --no-process-group so that the next update should fix this issue in a way that won't break for those who did this themselves. https://build.opensuse.org/request/show/595751 -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1088574 http://bugzilla.opensuse.org/show_bug.cgi?id=1088574#c10 Aurelien Aptel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #10 from Aurelien Aptel --- ok, closing. -- You are receiving this mail because: You are on the CC list for the bug.