[Bug 543132] New: cpio-2.10-3.6: missing call to fclose
http://bugzilla.novell.com/show_bug.cgi?id=543132 Summary: cpio-2.10-3.6: missing call to fclose Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package cpio-2.10-3.6 source code file cpio-2.10/src/copyin.c function process_copy_in local variable tty_out. I notice the following code tty_out = fopen (TTY_NAME, "w"); but I fail to notice a matching call to fclose. This looks like a resource leak to me. Suggest add call to fclose near the end of the function. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=543132 Marcus Meissner <meissner@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |mseben@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=543132 Michal Seben <mseben@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|cpio-2.10-3.6: missing call |JJ:cpio-2.10-3.6: missing |to fclose |call to fclose -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=543132 User rschweikert@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=543132#c1 Robert Schweikert <rschweikert@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rschweikert@novell.com --- Comment #1 from Robert Schweikert <rschweikert@novell.com> 2009-10-16 15:13:13 MDT --- created request id 22527 -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=543132 User rguenther@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=543132#c2 --- Comment #2 from Richard Guenther <rguenther@novell.com> 2009-10-17 08:56:00 MDT --- David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream. Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM. Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=543132 User mseben@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=543132#c3 Michal Seben <mseben@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |UPSTREAM --- Comment #3 from Michal Seben <mseben@novell.com> 2009-10-19 23:44:46 MDT --- forwarded to upstream : http://www.nabble.com/missing-call-to-fclose-in-copyin.c-td25957662.html -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com