[Bug 546014] New: argus-client-3.0.0-6.2: memory leak and some unfinished code
http://bugzilla.novell.com/show_bug.cgi?id=546014 Summary: argus-client-3.0.0-6.2: memory leak and some unfinished code Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package argus-client-3.0.0-6.2 source code file argus-clients-3.0.0/common/argus_event.c function ArgusProcessSQLEvent local variable is uid
From the command line
$ fgrep uid ../BUILD/argus-clients-3.0.0/common/argus_event.c char mbuf[MAXSTRLEN], username[1024], *uid; accounts = getpwuid(geteuid())->pw_name; if (row[0]) uid = strdup((const char *)row [0]); We can see that local variable uid is declared, line 2 is unrelated and line 3 has a call to strdup. Other than that, local variable uid is unused but causes a memory leak. Suggest delete local variable uid. In the same routine, local variables uid, name, fullname, address, telephone, mobile, fax, email url, pass, filter and stat all seem to be set but never used. It might be unfinished code, but suggest remove this code until it is ready for use. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=546014
Michal Seben
http://bugzilla.novell.com/show_bug.cgi?id=546014
User rguenther@novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=546014#c1
--- Comment #1 from Richard Guenther
http://bugzilla.novell.com/show_bug.cgi?id=546014
Michal Seben
http://bugzilla.novell.com/show_bug.cgi?id=546014
User mseben@novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=546014#c2
Michal Seben
participants (1)
-
bugzilla_noreply@novell.com