[Bug 954505] New: yast ruby msg extractor (xgettext) does not support format marker
http://bugzilla.suse.com/show_bug.cgi?id=954505 Bug ID: 954505 Summary: yast ruby msg extractor (xgettext) does not support format marker Classification: openSUSE Product: openSUSE Tumbleweed Version: 2015* Hardware: x86-64 OS: openSUSE 42.1 Status: NEW Severity: Normal Priority: P5 - None Component: YaST2 Assignee: yast2-maintainers@suse.de Reporter: ke@suse.com QA Contact: jsrain@suse.com CC: 5yrnyk@myway.com, ancor@suse.com, dimstar@opensuse.org, ke@suse.com Depends on: 954357 Found By: --- Blocker: --- +++ This bug was initially created as a clone of Bug #954357 +++ When installing Leap 42.1 (or 13.2) with Ukrainian localization the page of user account setup is skipped with error: Details: malformed format string - %*[0-9] Caller: /usr/lib64/ruby/gems/2.1.0/gems/fast_gettext-0.9.2/lib/fast_gettext/vendor/string.rb:70:in `%' Other tried localizations show user account page correctly. y2logs is attached ============================================================================= Karl Eichwalder 2015-11-10 17:36:40 CET (In reply to Ancor Gonzalez Sosa from comment #5)
Silly me! I was looking at Estonian .po file (et) and checking the effect in Greek language (el). But turns out el!=et. :-)
In Estonian it's not broken just because the translation is marked as fuzzy (so not included in the .mo file)... a missing translation that is not that obvious when you are staring at a Greek screen and you see no English text. :-D
So, in the end, it's a bug in the uk/users.po, as expected from the very beginning. So reassigning to translations.
Ok, thanks for debugging. It would work better, if the ruby xgettext extractor would add formatting markers as it does for other languages such as c or even ycp: #, c-format #, ycp-format I'm not sure whether that's a general issue or whether our yast xgettext extractor just does not know about this. Without such markers we are not (easily) able to validate the translations -- we usually do this with msgfmt. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=954505 Karl Eichwalder <ke@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|Normal |Enhancement -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=954505 Bug 954505 depends on bug 954357, which changed state. Bug 954357 Summary: Error when installing with Ukrainian localization http://bugzilla.suse.com/show_bug.cgi?id=954357 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=954505 Bug 954505 depends on bug 954357, which changed state. Bug 954357 Summary: Error when installing with Ukrainian localization http://bugzilla.suse.com/show_bug.cgi?id=954357 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=954505 http://bugzilla.suse.com/show_bug.cgi?id=954505#c1 Ancor Gonzalez Sosa <ancor@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|yast2-maintainers@suse.de |yast-internal@suse.de --- Comment #1 from Ancor Gonzalez Sosa <ancor@suse.com> --- Added to YaST Team Scrum queue for the issue to be prioritized with the other tasks. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=954505 Bug 954505 depends on bug 954357, which changed state. Bug 954357 Summary: Error when installing with Ukrainian localization http://bugzilla.suse.com/show_bug.cgi?id=954357 What |Removed |Added ---------------------------------------------------------------------------- Status|IN_PROGRESS |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=954505 Karl Eichwalder <ke@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1026156 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=954505 Karl Eichwalder <ke@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1047617 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=954505 http://bugzilla.suse.com/show_bug.cgi?id=954505#c2 Ludwig Nussel <lnussel@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P2 - High Severity|Enhancement |Major --- Comment #2 from Ludwig Nussel <lnussel@suse.com> --- Raising priority. Broken translations are repeatedly a source of crashes in the installer. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=954505 Karl Eichwalder <ke@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kdupke@suse.com Blocks| |1046572 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=954505 http://bugzilla.suse.com/show_bug.cgi?id=954505#c4 Luciano Santos <luc14n0@linuxmail.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |luc14n0@linuxmail.org --- Comment #4 from Luciano Santos <luc14n0@linuxmail.org> --- A user have reported that when trying to install TW 20180222 with German locale (de_DE.UTF-8) he got this same error in Keyboard Settings (required for vconsole): malformed format string - % ... /usr/lib64/ruby/gems/2.5.0/gems/fast_gettext-1.6.0/lib/fast_gettext/vendor/string.rb:70:in `%' -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=954505 http://bugzilla.suse.com/show_bug.cgi?id=954505#c5 --- Comment #5 from Luciano Santos <luc14n0@linuxmail.org> --- (In reply to Luciano Santos from comment #4)
A user have reported that when trying to install TW 20180222 with German locale (de_DE.UTF-8) he got this same error in Keyboard Settings (required for vconsole): malformed format string - % ... /usr/lib64/ruby/gems/2.5.0/gems/fast_gettext-1.6.0/lib/fast_gettext/vendor/ string.rb:70:in `%'
Sorry, I gave a wrong information. The system was installed but failed at startup when vconsole was being set. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=954505 http://bugzilla.suse.com/show_bug.cgi?id=954505#c6 --- Comment #6 from Ancor Gonzalez Sosa <ancor@suse.com> --- (In reply to Luciano Santos from comment #4)
A user have reported that when trying to install TW 20180222 with German locale (de_DE.UTF-8) he got this same error in Keyboard Settings (required for vconsole): malformed format string - % ... /usr/lib64/ruby/gems/2.5.0/gems/fast_gettext-1.6.0/lib/fast_gettext/vendor/ string.rb:70:in `%'
Which typically means an error in the translated string (German in this case). The translator didn't respect the number and shape of all the placeholders. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=954505 http://bugzilla.suse.com/show_bug.cgi?id=954505#c7 --- Comment #7 from Karl Eichwalder <ke@suse.com> --- (In reply to Ancor Gonzalez Sosa from comment #6)
Which typically means an error in the translated string (German in this case). The translator didn't respect the number and shape of all the placeholders.
As long as nobody take the time to work with gettext upstream maintainers to add proper ruby support, this will happen again and again. Also see Ludwig's #c2. (In the past I did this for ycp.) -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=954505 http://bugzilla.suse.com/show_bug.cgi?id=954505#c22 Tomáš Chvátal <tchvatal@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Group|SUSE Enterprise Partner | Component|YaST2 |YaST2 Version|RC 2 |Leap 15.0 Product|SUSE Linux Enterprise |openSUSE Distribution |Desktop 15 | Target Milestone|RC 3 |--- --- Comment #22 from Tomáš Chvátal <tchvatal@suse.com> --- Publishing the bug as we want to have community involved too. It is based of SLE15 if someone later tries on what codestreams need to be updated. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=954505 Arvin Schnell <aschnell@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aschnell@suse.com See Also| |http://bugzilla.suse.com/sh | |ow_bug.cgi?id=1134685 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=954505 http://bugzilla.suse.com/show_bug.cgi?id=954505#c23 --- Comment #23 from Stefan Hundhammer <shundhammer@suse.com> --- WIP: https://github.com/yast/yast-devtools/pull/152 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=954505 Stefan Hundhammer <shundhammer@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |IN_PROGRESS -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=954505 Stefan Hundhammer <shundhammer@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|yast-internal@suse.de |shundhammer@suse.com -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=954505 http://bugzilla.suse.com/show_bug.cgi?id=954505#c24 --- Comment #24 from Stefan Hundhammer <shundhammer@suse.com> --- Please read the extensive documentation at the pull request to get an idea how this works: https://github.com/yast/yast-devtools/pull/152 In a nutshell, we manually add different types of format markers for the different kinds of format that we use; so "msgfmt -c" or "msgmerge -c" should catch any errors in the translations. The script is normally part of our translation process when generating .pot files, but it can also be invoked standalone. Feel free to test and experiment. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=954505 http://bugzilla.suse.com/show_bug.cgi?id=954505#c25 Stefan Hundhammer <shundhammer@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|IN_PROGRESS |RESOLVED Resolution|--- |FIXED --- Comment #25 from Stefan Hundhammer <shundhammer@suse.com> --- The fix will become available with yast2-devtools-4.2.6. But it can already be used independently if downloaded from here: https://github.com/yast/yast-devtools/blob/master/build-tools/scripts/po_add... It doesn't need any YaST development environment, only Ruby (which all SUSE users should have installed anyway for YaST) and the "gettext" Ruby gem for that Ruby version (see ruby --version) sudo zypper in ruby2.6-rubygem-gettext For more details, see https://github.com/yast/yast-devtools/pull/152 All YaST .pot files that we generate from now on should already contain format flags generated by this script, so they will trickle down to the translators with the normal translation workflow. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=954505 Shane Wims <shane.wims@microfocus.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|shane.wims@microfocus.com | -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com