[Bug 1206745] New: Unnecessary log entries for rtkit
http://bugzilla.opensuse.org/show_bug.cgi?id=1206745 Bug ID: 1206745 Summary: Unnecessary log entries for rtkit Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: x86-64 OS: openSUSE Tumbleweed Status: NEW Severity: Minor Priority: P5 - None Component: Kernel Assignee: kernel-bugs@opensuse.org Reporter: jimoe@sma-inc.us QA Contact: qa-bugs@suse.de Found By: --- Blocker: --- Tumbleweed 20221222 The system log has many entries (generally tens per day, grouped in bunches of 5 - 30) like this: 2022-12-29T06:30:59-0700 sma-station14l rtkit-daemon[7852]: Supervising 0 threads of 0 processes of 0 users. Is this really necessary? It is merely saying it has nothing to do. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1206745 http://bugzilla.opensuse.org/show_bug.cgi?id=1206745#c2 Jean Delvare <jdelvare@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdelvare@suse.com, | |meissner@suse.com --- Comment #2 from Jean Delvare <jdelvare@suse.com> --- This issue also affects Leap 15.4. Numbers differ on my system, as rtkit actually does have some work here, nevertheless it doesn't make sense to fill the system log with informative messages duplicated every minute. This will ultimately fill up /var/log, and also makes the investigation of actual system issues harder. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1206745 http://bugzilla.opensuse.org/show_bug.cgi?id=1206745#c7 --- Comment #7 from Jean Delvare <jdelvare@suse.com> --- As far as I know, the only thing rtkit deals with by default is sound (at least, the only packages that would be uninstalled if I uninstall rtkit are all related to pulseaudio). So I would guess that James's system simply doesn't have a configured sound device and that's why the log message has numbers "0". Anyway, the actual numbers do not matter, even when non-zero, they are still not worth logging continuously by default in my opinion. Thanks for the pointers in comment #6. Having read that, I think the easiest solution is to add: [Service] LogLevelMax=info to the rtkit-daemon.service file. Alternatively, we could add an option --debug to rtkit-daemon and not even generate these debug messages when the option isn't used (by the way of setlogmask()). That's some more work as a few lines of code have to be written, but it's also slightly more efficient to not generate these messages at all than to filter them out afterwards. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1206745 http://bugzilla.opensuse.org/show_bug.cgi?id=1206745#c9 --- Comment #9 from Jean Delvare <jdelvare@suse.com> --- Created attachment 866177 --> http://bugzilla.opensuse.org/attachment.cgi?id=866177&action=edit [PATCH] rtkit-daemon: Don't log debug messages by default Here's a candidate fix. It is inspired from https://github.com/heftig/rtkit/pull/26/commits/1b5ebe1e36ec0301e9e4d147e0fb... with 3 key differences: 1* Debug messages are turned off by default, as this is how other services behave. 2* The filtering of debug messages is done directly at the syslog facility level, instead of cluttering the code with conditionals. 3* Only messages with level LOG_DEBUG are affected. Messages with level LOG_INFO are left unmodified and will always be logged, as before. This makes my proposal less intrusive and less risky. I think we should add this patch to the rtkit package in Tumbleweed. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1206745 http://bugzilla.opensuse.org/show_bug.cgi?id=1206745#c10 --- Comment #10 from Jean Delvare <jdelvare@suse.com> --- Test package for Leap 15.4 if anyone wants to give it a try: https://build.opensuse.org/package/show/home:jdelvare:branches:openSUSE:Leap... -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1206745 http://bugzilla.opensuse.org/show_bug.cgi?id=1206745#c11 Scott Bradnick <scott.bradnick@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |IN_PROGRESS --- Comment #11 from Scott Bradnick <scott.bradnick@suse.com> --- (In reply to Jean Delvare from comment #9)
Created attachment 866177 [details] [PATCH] rtkit-daemon: Don't log debug messages by default
Here's a candidate fix. It is inspired from
https://github.com/heftig/rtkit/pull/26/commits/ 1b5ebe1e36ec0301e9e4d147e0fb7869bc5a5d18
with 3 key differences:
1* Debug messages are turned off by default, as this is how other services behave. 2* The filtering of debug messages is done directly at the syslog facility level, instead of cluttering the code with conditionals. 3* Only messages with level LOG_DEBUG are affected. Messages with level LOG_INFO are left unmodified and will always be logged, as before.
This makes my proposal less intrusive and less risky. I think we should add this patch to the rtkit package in Tumbleweed.
I'd suggest PR'ing this upstream and get their thoughts on it first. I realize there isn't much activity @ https://github.com/heftig/rtkit - but better to get at least some eyes on it vs. us assuming it's fine to do. I'd like to see that happen before we consider adjusting it here because I'm more inclined to *not* change the default(s) since this behavior doesn't happen on any of my systems [1] as well as there being a pretty simple workaround. I don't like the idea of changing defaults in relation to personal preference and this could potentially do more harm than good if someone might rely on it's current default behavior. [1]: 3 quite different physical hosts that when 'pipewire-pulse.service' is running, 'sudo journalctl --this-boot | grep -i rtkit' shows output that appears sane and none of it is like OPs (all the 0s). Is it useful to me? No, but that doesn't necessitate a change in behavior IMO. -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠suse.com