Scott Bradnick changed bug 1206745
What Removed Added
Status NEW IN_PROGRESS

Comment # 11 on bug 1206745 from
(In reply to Jean Delvare from comment #9)
> Created attachment 866177 [details]
> [PATCH] rtkit-daemon: Don't log debug messages by default
> 
> Here's a candidate fix. It is inspired from
> 
> https://github.com/heftig/rtkit/pull/26/commits/
> 1b5ebe1e36ec0301e9e4d147e0fb7869bc5a5d18
> 
> with 3 key differences:
> 
> 1* Debug messages are turned off by default, as this is how other services
> behave.
> 2* The filtering of debug messages is done directly at the syslog facility
> level, instead of cluttering the code with conditionals.
> 3* Only messages with level LOG_DEBUG are affected. Messages with level
> LOG_INFO are left unmodified and will always be logged, as before.
> 
> This makes my proposal less intrusive and less risky. I think we should add
> this patch to the rtkit package in Tumbleweed.

I'd suggest PR'ing this upstream and get their thoughts on it first. I realize
there isn't much activity @ https://github.com/heftig/rtkit - but better to get
at least some eyes on it vs. us assuming it's fine to do.

I'd like to see that happen before we consider adjusting it here because I'm
more inclined to *not* change the default(s) since this behavior doesn't happen
on any of my systems [1] as well as there being a pretty simple workaround. I
don't like the idea of changing defaults in relation to personal preference and
this could potentially do more harm than good if someone might rely on it's
current default behavior.

[1]: 3 quite different physical hosts that when 'pipewire-pulse.service' is
running, 'sudo journalctl --this-boot | grep -i rtkit' shows output that
appears sane and none of it is like OPs (all the 0s). Is it useful to me? No,
but that doesn't necessitate a change in behavior IMO.


You are receiving this mail because: