[Bug 248676] New: Packages should not symlink their hicolor icons to /usr/share/pixmaps
https://bugzilla.novell.com/show_bug.cgi?id=248676 Summary: Packages should not symlink their hicolor icons to /usr/share/pixmaps Product: openSUSE 10.3 Version: Alpha 1 Platform: All OS/Version: All Status: NEW Severity: Normal Priority: P5 - None Component: GNOME AssignedTo: bnc-team-gnome@forge.provo.novell.com ReportedBy: andreas.hanke@gmx-topmail.de QAContact: qa@suse.de Some time ago, GNOME packages started to symlink their icons from the hicolor theme into /usr/share/pixmaps. This is 100% the wrong way, it should be exactly the other way round (see bug 209385), it hides bugs and is wrong because /usr/share/pixmaps is a legacy directory. If this stuff has been added to work around a bug somewhere, this bug needs to be fixed properly and afterwards the packages have to drop their symlinks again. Possibly inexact list of affected packages (some packages might be missing, some packages listed here might be OK): alacarte-0.10.3-5 control-center2-2.16.1-44 eog-2.16.1-40 epiphany-2.16.1-42 evince-0.6.1-36 file-roller-2.16.1-41 gcalctool-5.8.24-40 gedit-2.16.1-42 gnome-cups-manager-0.32cvs20060120-86 gnome-keyring-manager-2.16.0-42 gnome-nettool-2.16.0-39 gnome-system-monitor-2.16.1-38 gnome-utils-2.16.1-44 gucharmap-1.8.0-41 libgnomedb-1.3.91-66 liferea-1.2.2-4 MozillaFirefox-2.0-46 nautilus-2.16.1-47 nautilus-cd-burner-2.16.1-39 orca-1.0.0-41 pysol-4.82-244 rhythmbox-0.9.6-22 sound-juicer-2.16.1-40 totem-2.17.0-48 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=248676 ------- Comment #1 from andreas.hanke@gmx-topmail.de 2007-02-26 11:01 MST ------- I wonder whether this could be related to bug 248854. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=248676 jpr@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team- |bnc-team-gnome-build@forge.provo.novell.com |gnome@forge.provo.novell.com| -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=248676 jpr@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Info Provider| |andreas.hanke@gmx-topmail.de ------- Comment #2 from jpr@novell.com 2007-02-27 03:06 MST ------- What do you think Rodney? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=248676 ------- Comment #3 from andreas.hanke@gmx-topmail.de 2007-02-27 04:01 MST ------- I assume that you wanted to put someone else into NEEDINFO... Anyway: These symlinks are not needed, they have been added because of a brp check script in autobuild that makes the packages fail if they are not present. This is a bug in that check, either in the brp script itself or in the build environment. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=248676 andreas.hanke@gmx-topmail.de changed: What |Removed |Added ---------------------------------------------------------------------------- Info Provider|andreas.hanke@gmx-topmail.de|dobey@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=248676 dobey@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW Info Provider|dobey@novell.com | ------- Comment #4 from dobey@novell.com 2007-02-27 09:17 MST ------- Sounds reasonable to me. Assuming the bug in the brp script is fixed, I see no reason to not remove the symlinks. I wouldn't say that having symlinks in $datadir/pixmaps pointing to icons in $datadir/icons/hicolor is the wrong way, or backward though. If there was a need to maintain some sort of compatibility here, doing that seems to me to be the right way to do it. You wouldn't want files in $datadir/icons/hicolor to be symlinks that point to files outside the icon theme, when the icon theme is supposed to be the standard way to do things now. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=248676 ------- Comment #5 from sbrabec@novell.com 2007-02-27 09:49 MST ------- Technical note: Symlinks to $datadir/icons/gnome should be reported upstream as - either use OnlyShowIn=GNOME or add icon to public path. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=248676 andreas.hanke@gmx-topmail.de changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Packages should not symlink |Packages should not have to symlink their |their hicolor icons to |hicolor icons to /usr/share/pixmaps |/usr/share/pixmaps | ------- Comment #6 from andreas.hanke@gmx-topmail.de 2007-02-27 16:18 MST ------- The symlinks have been added after the move to /usr, so before that it somehow worked without them and I don't see any reason why it shouldn't work now. The rationale behind "the wrong way" is that the icon-theme-spec requires the hicolor icon theme to be searched, actually even before /usr/share/pixmaps. So there is no reason to force packages to symlink hicolor icons into /usr/share/pixmaps: Packages that install only hicolor icons and no /usr/share/pixmaps perfectly fulfill the requirements of that spec. These are valid packages that should pass the check. Whether the already present symlinks should be removed: They are indeed not harmful, but I don't see how they should maintain compatibility with anything given that they have been added "just now" (i.e. during the last weeks, after moving to /usr). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=248676 ------- Comment #7 from andreas.hanke@gmx-topmail.de 2007-02-27 16:47 MST ------- More exact list of affected packages (still incomplete, but without false positives): alacarte-0.10.3-6 (alacarte.svg) control-center2-2.16.1-45 (gnome-control-center.png) evince-0.7.2-2 (evince.png) file-roller-2.16.1-42 (file-roller.png) gnome-nettool-2.16.0-40 (gnome-nettool.png) gnome-utils-2.16.1-45 (baobab.png, gnome-dictionary.png, logviewer.png) gucharmap-1.8.0-42 (gucharmap.png) liferea-1.2.2-5 (liferea.png) nautilus-cd-burner-2.16.1-40 (nautilus-cd-burner.svg) orca-1.0.0-42 (orca.png) rhythmbox-0.9.6-24 (rhythmbox.png) sound-juicer-2.16.1-41 (sound-juicer.svg) totem-2.17.0-50 (totem.svg) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=248676 ------- Comment #8 from andreas.hanke@gmx-topmail.de 2007-02-27 22:13 MST ------- Created an attachment (id=121451) --> (https://bugzilla.novell.com/attachment.cgi?id=121451&action=view) find-useless-symlinks.sh -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=248676 adrian@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Info Provider| |coolo@novell.com ------- Comment #9 from adrian@novell.com 2007-02-28 03:28 MST ------- The new pathes needs to be added in KDE and all other WM's, afterwards the autobuild check can get made in sync to support the new pathes. Coolo, does KDE 3 & 4 support these /usr/share/icons/... pathes already ? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=248676 coolo@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW Info Provider|coolo@novell.com | ------- Comment #10 from coolo@novell.com 2007-03-01 08:31 MST ------- not sure how it matters. If it does not, then this is an independent bug - it simply has to. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=248676 ------- Comment #11 from sbrabec@novell.com 2007-03-08 04:11 MST ------- More complete list: cd /mounts/dist/unpacked/i386.full/usr/share/pixmaps for FILE in * ; do if test -L $FILE ; then LINK=$(readlink $FILE) ; if test "${LINK}" != "${LINK#../icons/hicolor/*/apps}" ; then rpm -r /mounts/dist/unpacked/i386.full --queryformat %{NAME}\\n -qf /usr/share/pixmaps/$FILE ; fi ; fi ; done | sort -u alacarte banshee control-center2 dasher evince file-roller f-spot gimp-unstable gnome-games gnome-nettool gnome-utils gnopernicus gthumb gucharmap jedit liferea nautilus-cd-burner OpenOffice_org orca resapplet rhythmbox sabayon-admin sound-juicer tangerine totem vmx-manager In case of vmx-manager it is a dangling link. I will try to remove the symlink and rebuild them. Let's see whether they will fail. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=248676 ------- Comment #12 from sbrabec@novell.com 2007-03-08 04:51 MST ------- Cannot remove symlink, check is invalid! alacarte has following files: /usr/share/icons/hicolor/22x22/apps/alacarte.png /usr/share/icons/hicolor/scalable/apps/alacarte.svg ERROR: Icon file not installed: /var/tmp/alacarte-0.11.3-build//usr/share/applications/alacarte.desktop WARNING: Empty GenericName: /var/tmp/alacarte-0.11.3-build//usr/share/applications/alacarte.desktop Errors in installed desktop file detected. Please mail adrian@suse.de, if you think this is wrong. error: Bad exit status from /var/tmp/rpm-tmp.95900 (%install) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=248676 ------- Comment #13 from sbrabec@novell.com 2007-03-08 05:20 MST ------- Notes to script improvement: /opt/kde3/share/icons/default.kde and /opt/kde3/share/icons/crystalsvg are valid only for desktop files with OnlyShowIn=KDE /usr/share/icons/gnome is valid only for desktop files with OnlyShowIn=GNOME -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=248676 sbrabec@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|adrian@novell.com |sbrabec@novell.com Status|NEW |ASSIGNED ------- Comment #14 from sbrabec@novell.com 2007-03-08 06:18 MST ------- I have just prepared and tested Autobuild check update. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=248676 sbrabec@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED ------- Comment #15 from sbrabec@novell.com 2007-03-09 09:08 MST ------- Autobuild fix checked in. All mentioned packages fixed. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
participants (1)
-
bugzilla_noreply＠novell.com