[Bug 547889] New: LibVNCServer-0.9.7-1.13: small memory leak
http://bugzilla.novell.com/show_bug.cgi?id=547889 Summary: LibVNCServer-0.9.7-1.13: small memory leak Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.2 Status: NEW Severity: Minor Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package LibVNCServer-0.9.7-1.13 source code file LibVNCServer-0.9.7/libvncserver/vncauth.c function rfbDecryptPasswdFromFile I notice the following code unsigned char *passwd = (unsigned char *)malloc(9); if ((fp = fopen(fname,"r")) == NULL) return NULL; so if the return is taken, then passwd is a memory leak. Suggest new code if ((fp = fopen(fname,"r")) == NULL) return NULL; unsigned char *passwd = (unsigned char *)malloc(9); -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=547889 Andreas Jaeger <aj@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |garloff@novell.com |ovo.novell.com | Summary|LibVNCServer-0.9.7-1.13: |JJ: |small memory leak |LibVNCServer-0.9.7-1.13: | |small memory leak -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=547889 User rguenther@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=547889#c1 --- Comment #1 from Richard Guenther <rguenther@novell.com> 2009-10-17 08:56:34 MDT --- David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream. Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM. Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=547889 https://bugzilla.novell.com/show_bug.cgi?id=547889#c2 Agron Selimaj <linuxmaster@verizon.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |linuxmaster@verizon.net --- Comment #2 from Agron Selimaj <linuxmaster@verizon.net> 2011-02-15 16:21:22 UTC --- People please disregard Richards comments about being fine to have resource leaks. He is belittling the seriousness of the problem. We should try to make Linux reboot once in 20 years. Not every Tuesday like some other OSes. If I can rephrase Richards comment I would say, if you can't release the allocated resources, the OS will release the for you but only and only if you terminate your process. Also, put comments that you are deliberately doing this. But, because of the nature of the open source development, every code that has been published serves as tutorial, sample and skeleton to the next open source developer, it is of the utmost importance to release all allocated resources. The other major problem is that the way code is moved within a project or copied to another project, what once was an exit path, it may end up being a part of some other execution path and cause catastrophic problems on life support equipment, elevators, SCADA, etc. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=547889 https://bugzilla.novell.com/show_bug.cgi?id=547889#c4 kk zhang <kkzhang@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED CC| |kkzhang@novell.com Resolution| |NORESPONSE --- Comment #4 from kk zhang <kkzhang@novell.com> 2012-03-08 02:36:09 UTC --- Long time no response.So closed.Feel free to reopen it.Thanks. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com