http://bugzilla.opensuse.org/show_bug.cgi?id=1198463 http://bugzilla.opensuse.org/show_bug.cgi?id=1198463#c1 Christian Boltz <suse-beta@cboltz.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |suse-beta@cboltz.de --- Comment #1 from Christian Boltz <suse-beta@cboltz.de> --- Looks like '�' the script uses as separator is no longer is a single-byte character, so we'll need to find another special character ;-) Looking at the smiley - why not ';'? While on it, let me add - set -o pipefail - || verboseexit "generating profile sniplet failed" (after the sed call) During testing, I also noticed that test -e "$profilesniplet" || \ silentexit "apparmor profile snippet not available" might not be a good idea, and replaced it with test -e "$profilesniplet" || touch "$profilesniplet" I'll attach a patch ;-) -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1198463 http://bugzilla.opensuse.org/show_bug.cgi?id=1198463#c3 --- Comment #3 from Noel Power <nopower@suse.com> --- (In reply to Noel Power from comment #0)

when update-apparmor-samba-profile runs (on smb start) the file /etc/apparmor.d/local/usr.sbin.smbd-shares is not updated (if fact it will be empty)

caused by sed error

sed: -e expression #1, char 42: delimiter character is not a single-byte character

so the change here happened because the samba CI tests include a test that scans the source code to ensure it is utf8 compliant. The previous delimiter was a printable character with some other encoding most likley latin-8 (because it must have been a single byte) we changed that but didn't double check that sed still worked :-( We discussed it here and decided that maybe a non printable delimiter is probably a better choice (and avoids mostly any chance that it could be part of a path name scanned by sed) so we chose the first single byte ascii char that worked e.g. 001 I am sure the other changes you have here are fine, but I'll look in more detail tomorrow (it might be we could integrate them in a second pass given some of of the team involved in discussing this just went on vacation) -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1198463 Felix Niederwanger <felix.niederwanger@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |felix.niederwanger@suse.com -- You are receiving this mail because: You are on the CC list for the bug.

(In reply to Noel Power from comment #3)

...

We discussed it here and decided that maybe a non printable delimiter is probably a better choice (and avoids mostly any chance that it could be part of a path name scanned by sed) so we chose the first single byte ascii char that worked e.g. 001

That's an interesting delimiter ;-) which I never used, and that might make the script a bit more interesting to read. most editors (at least gedit, emacs & vi) show it as a special char (And I won't even think about copy&paste ;-)

http://bugzilla.opensuse.org/show_bug.cgi?id=1198463 http://bugzilla.opensuse.org/show_bug.cgi?id=1198463#c6 --- Comment #6 from Noel Power <nopower@suse.com> --- (In reply to Christian Boltz from comment #5) that might be a problem (but not really necessary and in editor cut/paste should work) :-)

To make things a bit easier - the delimiter should be avoided (or escaped) in the sed command (the 's/foo/bar/'), but it shouldn't be a problem if it appears in the input data (in this case the path name). This also means using ';' as delimiter (as my patch does) should work without problems.

If you want a quick confirmation of the above: echo 'test;delimiter' | sed 's;t;b;'

right, I wonder why the special character was chosen as a delimiter in the first place, we thought it was intentionally chosen to ensure it was very unlikely to be in the input data. We already have a submission with the non-printable char (as this was the reviewed change and we wanted to get this fix out asap) I doubt anyone here has any religious objections to changing the delimiter :-) especially if it appearing in the input data doesn't have downside so we will try to update this again later -- You are receiving this mail because: You are on the CC list for the bug.