Comment # 3 on bug 1198463 from
(In reply to Noel Power from comment #0)
> when update-apparmor-samba-profile runs (on smb start) the file
> /etc/apparmor.d/local/usr.sbin.smbd-shares is not updated (if fact it will
> be empty)
> 
> caused by sed error
> 
> sed: -e expression #1, char 42: delimiter character is not a single-byte
> character

so the change here happened because the samba CI tests include a test that
scans the source code to ensure it is utf8 compliant. The previous delimiter
was a printable character with some other encoding most likley latin-8 (because
it must have been a single byte) we changed that but didn't double check that
sed still worked :-(

We discussed it here and decided that maybe a non printable delimiter is
probably a better choice (and avoids mostly any chance that it could be part of
a path name scanned by sed) so we chose the first single byte ascii char that
worked e.g. 001

I am sure the other changes you have here are fine, but I'll look in more
detail tomorrow (it might be we could integrate them in a second pass given
some of of the team involved in discussing this just went on vacation)


You are receiving this mail because: