[Bug 644738] New: link_wait script just prints usage information when activated
https://bugzilla.novell.com/show_bug.cgi?id=644738
https://bugzilla.novell.com/show_bug.cgi?id=644738#c0
Summary: link_wait script just prints usage information when
activated
Classification: openSUSE
Product: openSUSE 11.3
Version: Final
Platform: All
OS/Version: openSUSE 11.3
Status: NEW
Severity: Normal
Priority: P5 - None
Component: Basesystem
AssignedTo: bnc-team-screening@forge.provo.novell.com
ReportedBy: jochen.katz@de.thalesgroup.com
QAContact: qa@suse.de
Found By: ---
Blocker: ---
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.2.10)
Gecko/20100914 SUSE/3.6.10-0.3.1 Firefox/3.6.10
When activating /etc/sysconfig/network/scripts/link_wait, it just prints out
its usage information because the initialization of SCRIPTNAME is wrong.
SCRIPTNAME has to be set to SCRIPTNAME=${0}.
SLES11 SP1 is also affected.
Additional thing that need improvement:
- There are a lot of calculations done with LINK_WAIT value. In the end it is
not bigger than WAIT_FOR_INTERFACES / 4. This is confusing for the user.
- The usage of ping should be replaced by fping, because the command "ping -I
eth0 -w 20 -c 1
https://bugzilla.novell.com/show_bug.cgi?id=644738
https://bugzilla.novell.com/show_bug.cgi?id=644738#c
Marius Tomaschewski
https://bugzilla.novell.com/show_bug.cgi?id=644738
https://bugzilla.novell.com/show_bug.cgi?id=644738#c2
--- Comment #2 from Marius Tomaschewski
https://bugzilla.novell.com/show_bug.cgi?id=644738
https://bugzilla.novell.com/show_bug.cgi?id=644738#c4
--- Comment #4 from Marius Tomaschewski
SCRIPTNAME has to be set to SCRIPTNAME=${0}.
fixed.
Additional thing that need improvement: - There are a lot of calculations done with LINK_WAIT value. In the end it is not bigger than WAIT_FOR_INTERFACES / 4. This is confusing for the user.
Yes, the script was originally for sles10 and there it was required. You have to increase WAIT_FOR_INTERFACES.
- The usage of ping should be replaced by fping, because the command "ping -I eth0 -w 20 -c 1
I don't see any benefit using fping. It is installed in /usr, so it is not usable in the when /usr is on remote-fs and this (+static ip) was the purpose of this optional helper script, e.g. when bnx2 does not report the carrier correctly. A loop seems better to me. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=644738
https://bugzilla.novell.com/show_bug.cgi?id=644738#c5
--- Comment #5 from Jochen Katz
I don't see any benefit using fping. It is installed in /usr, so it is not usable in the when /usr is on remote-fs and this (+static ip) was the purpose of this optional helper script, e.g. when bnx2 does not report the carrier correctly. A loop seems better to me.
Yes, your loop can do it without fping. I mentioned fping, because if fping is called with the right params, it will return after the specified amount of seconds, while such params do not exist for ping. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=644738
https://bugzilla.novell.com/show_bug.cgi?id=644738#c
Dirk Mueller
https://bugzilla.novell.com/show_bug.cgi?id=644738
https://bugzilla.novell.com/show_bug.cgi?id=644738#c
Swamp Workflow Management
https://bugzilla.novell.com/show_bug.cgi?id=644738
https://bugzilla.novell.com/show_bug.cgi?id=644738#c7
Christian Dengler
https://bugzilla.novell.com/show_bug.cgi?id=644738
https://bugzilla.novell.com/show_bug.cgi?id=644738#c9
Swamp Workflow Management
https://bugzilla.novell.com/show_bug.cgi?id=644738
https://bugzilla.novell.com/show_bug.cgi?id=644738#c10
Swamp Workflow Management
participants (1)
-
bugzilla_noreply@novell.com