[Bug 619218] New: /etc/sysconfig/kernel KMS setting should not start with NO
http://bugzilla.novell.com/show_bug.cgi?id=619218 http://bugzilla.novell.com/show_bug.cgi?id=619218#c0 Summary: /etc/sysconfig/kernel KMS setting should not start with NO Classification: openSUSE Product: openSUSE 11.3 Version: Factory Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: Kernel AssignedTo: kernel-maintainers@forge.provo.novell.com ReportedBy: jnelson-suse@jamponi.net QAContact: qa@suse.de Found By: --- Blocker: --- User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100317 SUSE/3.5.9-0.1.1 Firefox/3.5.9 The current setting in /etc/sysconfig/kernel for KMS is: NO_KMS_IN_INITRD="" However, it's bad practice to use "NO" in a setting, because setting the *value* to "no" is a double negative, and people find it hard to parse the meaning of the setting that way. It should be: KMS_IN_INITRD="" # defaults to yes There is still time to fix! Reproducible: Always Steps to Reproduce: 1. 2. 3. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=619218 https://bugzilla.novell.com/show_bug.cgi?id=619218#c1 Jeff Mahoney <jeffm@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Kernel |Kernel AssignedTo|kernel-maintainers@forge.pr |ro@novell.com |ovo.novell.com | Product|openSUSE 11.3 |openSUSE 12.1 --- Comment #1 from Jeff Mahoney <jeffm@novell.com> 2011-04-25 21:28:11 UTC --- /etc/sysconfig/kernel is part of aaa_base. Assigning to maintainer. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=619218 https://bugzilla.novell.com/show_bug.cgi?id=619218#c2 Ruediger Oertel <ro@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |mmarek@novell.com --- Comment #2 from Ruediger Oertel <ro@novell.com> 2011-05-09 11:23:58 UTC --- well, I'm just providing the variable. The use of it is in /lib/mkinitrd/scripts/setup-kms.sh. Michal: do we want to change this ? Does this still default to not setting up kms ? (I can provide renaming the variable and reversing the current setting on update if wanted in the install scripts of aaa_base), but actually: why does this file belong to aaa_base at all while the whole thing could live in mkinitrd ? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=619218 https://bugzilla.novell.com/show_bug.cgi?id=619218#c3 Michal Marek <mmarek@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mmarek@novell.com InfoProvider|mmarek@novell.com |eich@novell.com --- Comment #3 from Michal Marek <mmarek@novell.com> 2011-05-09 11:32:44 UTC --- (In reply to comment #2)
well, I'm just providing the variable. The use of it is in /lib/mkinitrd/scripts/setup-kms.sh. Michal: do we want to change this ? Does this still default to not setting up kms ?
Egbert contributed the kms scripts.
(I can provide renaming the variable and reversing the current setting on update if wanted in the install scripts of aaa_base), but actually: why does this file belong to aaa_base at all while the whole thing could live in mkinitrd ?
INITRD_MODULES, DOMU_INITRD_MODULES, ACPI_DSDT and NO_KMS_IN_INITRD are variables read by mkinitrd. MODULES_LOADED_ON_BOOT is read by /etc/init.d/boot.loadmodules. SKIP_RUNNING_KERNEL can be removed. So yes, most of the variables are used by mkinitd, although the *MODULES once are obsolete. What everything needs to be done to move a sysconfig file from one package to another (IOW is it worth it)? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=619218 https://bugzilla.novell.com/show_bug.cgi?id=619218#c4 Egbert Eich <eich@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eich@novell.com --- Comment #4 from Egbert Eich <eich@novell.com> 2011-05-09 13:12:23 UTC --- (In reply to comment #3)
(In reply to comment #2)
well, I'm just providing the variable. The use of it is in /lib/mkinitrd/scripts/setup-kms.sh. Michal: do we want to change this ? Does this still default to not setting up kms ?
Egbert contributed the kms scripts.
I could add the inverse semantics not replace what we currently have - this would be really easy - still I'm hesitant as this might produce some nightmare on the update process. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=619218 https://bugzilla.novell.com/show_bug.cgi?id=619218#c5 Jon Nelson <jnelson-suse@jamponi.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW InfoProvider|eich@novell.com | --- Comment #5 from Jon Nelson <jnelson-suse@jamponi.net> 2011-05-09 13:23:47 UTC --- If it's going to be a lot of work or difficult for end users, I would say not to bother. I _respectfully_ submit two observations: 1. at the time of the submission, there was time to correct the issue before release 2. in the future when new config items are introduced, try to avoid issues like this -- even though it's minor, once it's "in", it's hard to change. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=619218 https://bugzilla.novell.com/show_bug.cgi?id=619218#c6 --- Comment #6 from Ruediger Oertel <ro@novell.com> 2011-05-09 14:57:41 UTC --- working on a proposal for the changes to mkinitrd in home:oertel:branches:Base:System/mkinitrd -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=619218 https://bugzilla.novell.com/show_bug.cgi?id=619218#c7 Ruediger Oertel <ro@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |mmarek@novell.com --- Comment #7 from Ruediger Oertel <ro@novell.com> 2011-05-09 15:14:02 UTC --- created request id 69906 please ping me if this is okay, so I can remove the files from aaa_base in turn -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=619218 https://bugzilla.novell.com/show_bug.cgi?id=619218#c8 --- Comment #8 from Egbert Eich <eich@novell.com> 2011-05-09 15:51:28 UTC --- Rudi, AFAICT this looks good. Thanks! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=619218 https://bugzilla.novell.com/show_bug.cgi?id=619218#c9 Christian Boltz <suse-beta@cboltz.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bruno@ioda-net.ch, | |suse-beta@cboltz.de --- Comment #9 from Christian Boltz <suse-beta@cboltz.de> 2011-06-14 00:36:46 CEST --- (In reply to comment #4) (Egbert)
I could add the inverse semantics not replace what we currently have - this would be really easy -
Things aren't always as easy as they might look ;-)
still I'm hesitant as this might produce some nightmare on the update process.
Your guess was right - this *is* producing a nightmare on update. (OK, I'm exaggerating ;-) Bruno Friedmann wrote this in opensuse-factory yesterday: ------------------------------------------------------------------------------- Sid I mean on new factory install the NO_KMS_IN_INITRD="yes" become KMS_IN_INITRD="no" The upgrade process is faulty with wrong sed or regex as I've finished with a NO_KMS_IN_INITRD="noyes" and KMS_IN_INITRD="yes" ------------------------------------------------------------------------------- The "yesno" looks as if the update script can't decide ;-)) mkinitrd.spec from Base:System looks somewhat buggy, even if it seems to have the bug in the KMS_IN_INITRD variable instead of the NO_KMS_... variable: %post: [...] case "$NO_KMS_IN_INITRD" in no) sed -i -e "s@^KMS_IN_INITRD=@KMS_IN_INITRD=\"yes\"@" /etc/sysconfig/kernel ;; yes) sed -i -e "s@^KMS_IN_INITRD=@KMS_IN_INITRD=\"no\"@" /etc/sysconfig/kernel ;; esac You probably want to add ".*" to the search part to replace the whole line (and not only everything until the "=", which will at least result in additional, useless quotes, or in a "yesno" if things go worse). I'd also use single quotes to make the sed command better readable. In other words, I'd recommend to use the following sed commands: no) sed -i -e 's@^KMS_IN_INITRD=.*@KMS_IN_INITRD="yes"@' /etc/sysconfig/kernel ;; yes) sed -i -e 's@^KMS_IN_INITRD=.*@KMS_IN_INITRD="no"@' /etc/sysconfig/kernel ;; -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=619218 https://bugzilla.novell.com/show_bug.cgi?id=619218#c10 Ruediger Oertel <ro@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED InfoProvider|mmarek@novell.com | AssignedTo|ro@suse.com |mmarek@novell.com --- Comment #10 from Ruediger Oertel <ro@suse.com> 2011-08-02 00:14:22 UTC --- sysconfig/kernel removed from aaa_base reassigning to mkinitrd maintainer for comment # 9 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=619218 https://bugzilla.novell.com/show_bug.cgi?id=619218#c11 Michal Marek <mmarek@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #11 from Michal Marek <mmarek@novell.com> 2011-08-02 08:17:33 UTC --- (In reply to comment #9) This should be fixed already (KMS_IN_INITRD=.* in the sed command was lacking the ".*"). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=619218 https://bugzilla.novell.com/show_bug.cgi?id=619218#c12 Stefan Dirsch <sndirsch@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | --- Comment #12 from Stefan Dirsch <sndirsch@suse.com> 2011-11-03 14:55:20 UTC --- Date: Thu, 03 Nov 2011 15:42:35 +0100 From: Michal Marek <mmarek@suse.de> To: Stefan Dirsch <sndirsch@suse.de> CC: Egbert Eich <eich@suse.de>, Ruediger Oertel <ro@suse.de> Subject: Re: mkinitrd: NO_KMS_IN_INITRD --> KMS_IN_INITRD change ... On 3.11.2011 14:37, Stefan Dirsch wrote:
On Thu, Nov 03, 2011 at 02:31:08PM +0100, Stefan Dirsch wrote:
Dear Michal
Why did you do this change (even not documented in the package changelog!)
NO_KMS_IN_INITRD --> KMS_IN_INITRD
in mkinitrd?!? I'm really not interested in changing all the nvidia/fglrx packages accordingly, so that I would need to handle both versions for older *and* newer products. Please consider reverting this change. Thanks!
Ah, I didn't consider nvidia and fglrx (or any other setting by scripts) at all, otherwise I would have rejected the name change.
Apparently this change in git.
commit aa6970e7149abebaa84c09bd1a00f63071db0c2f Author: Michal Marek <mmarek@suse.cz> Date: Tue Jun 14 15:40:26 2011 +0200
Merge Factory changes by Rudi
Signed-off-by: Michal Marek <mmarek@suse.cz>
The bugnumber was bnc#619218. Can you reopen it and post the same angry message there? :) I agree that it should be reverted. Michal -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=619218 https://bugzilla.novell.com/show_bug.cgi?id=619218#c13 --- Comment #13 from Stefan Dirsch <sndirsch@suse.com> 2011-11-03 14:55:59 UTC --- Michal, please revert. :-) Thanks! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=619218 https://bugzilla.novell.com/show_bug.cgi?id=619218#c14 Michal Marek <mmarek@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |WONTFIX --- Comment #14 from Michal Marek <mmarek@suse.com> 2011-11-07 13:12:02 UTC --- Reverted in sr 90245. Update from a pre-12.1 Factory version to 12.1 will leave a stray KMS_IN_INITRD variable in /etc/sysconfig/kernel and ifnore any previous setting there, but a clean install or update from 11.4 should work fine. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=619218 https://bugzilla.novell.com/show_bug.cgi?id=619218#c15 --- Comment #15 from Stefan Dirsch <sndirsch@suse.com> 2011-11-07 13:39:01 UTC --- Thanks a lot, Michal! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=619218 https://bugzilla.novell.com/show_bug.cgi?id=619218#c16 --- Comment #16 from Bernhard Wiedemann <bwiedemann@suse.com> 2011-11-07 15:00:08 CET --- This is an autogenerated message for OBS integration: This bug (619218) was mentioned in https://build.opensuse.org/request/show/90245 Factory / mkinitrd -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com