[Bug 776117] New: science/octave-forge: most packages are completely broken since binary .oct files are not shipped
https://bugzilla.novell.com/show_bug.cgi?id=776117 https://bugzilla.novell.com/show_bug.cgi?id=776117#c0 Summary: science/octave-forge: most packages are completely broken since binary .oct files are not shipped Classification: openSUSE Product: openSUSE.org Version: unspecified Platform: x86-64 OS/Version: openSUSE 12.1 Status: NEW Severity: Normal Priority: P5 - None Component: 3rd party software AssignedTo: pgajdos@suse.com ReportedBy: martin_helm@arcor.de QAContact: opensuse-communityscreening@forge.provo.novell.com CC: werner.ho@gmx.de Found By: --- Blocker: --- This is due to the fact that in the %install part only one parameter for pkg prefix is set, octaves pkg prefix takes two paths (which in this case should be simple the same ones), so instead of octave --eval "pkg prefix %{buildroot}%{octpackages_dir}; pkg install -nodeps $archive" it has to be octave --eval "pkg prefix %{buildroot}%{octpackages_dir} %{buildroot}%{octpackages_dir}; pkg install -nodeps $archive" in addition the BuildArch: noarch is wrong since the packages are architecture specific and the line should be removed. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=776117
https://bugzilla.novell.com/show_bug.cgi?id=776117#c1
Martin Helm
https://bugzilla.novell.com/show_bug.cgi?id=776117
https://bugzilla.novell.com/show_bug.cgi?id=776117#c2
--- Comment #2 from Martin Helm
https://bugzilla.novell.com/show_bug.cgi?id=776117
https://bugzilla.novell.com/show_bug.cgi?id=776117#c3
--- Comment #3 from Martin Helm
https://bugzilla.novell.com/show_bug.cgi?id=776117
https://bugzilla.novell.com/show_bug.cgi?id=776117#c4
Petr Gajdos
I build the packages now also in my obs home project to see how it works there home:martin_helm/octave-forge
Martin, excelent, thanks. When you are done, could I ask you to osc sr home:martin_helm octave-forge science and drop me note here in bug. This will create request which I will accept fortwith. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=776117
https://bugzilla.novell.com/show_bug.cgi?id=776117#c
Petr Gajdos
https://bugzilla.novell.com/show_bug.cgi?id=776117
https://bugzilla.novell.com/show_bug.cgi?id=776117#c5
--- Comment #5 from Martin Helm
https://bugzilla.novell.com/show_bug.cgi?id=776117
https://bugzilla.novell.com/show_bug.cgi?id=776117#c6
--- Comment #6 from Petr Gajdos
I need to cleanup my crappy spec file before so that it matches again your's which uses nice defines for the package versions and is overall cleaner, I can do that tomorrow and after successful test (the already built packages work for me) I will do the "osc sr".
Note that there is octave-forge.spec.in file from which is octave-forge.spec generated by calling sh update.sh. Therefore, changes made in octave-forge.spec will get lost with next sh updates.sh call, so changes should be made in octave-forge.spec.in. Then, sh update.sh should be called and package rebuild should be triggered then to test generated spec file.
One other unrelated thing: I updated a handful of octave forge packages to newer versions, do you want that update or shall I stay on the versions we already have in science?
This should be done automaticaly by update.sh call. But! Note there is also blacklist file in science/octave-forge source, which is read by update.sh and all packages listed there are ommited. The reason why is written in comment in blacklist. I know they should be fixed instead of blacklisting them, nevertheless I lack time for this. Moreover, there is a chance that some of them with "doesn't build with octave ..." can be compilable with octave 3.6.2 on current openSUSE. Feel free to propose better system :-). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=776117
https://bugzilla.novell.com/show_bug.cgi?id=776117#c7
--- Comment #7 from Martin Helm
https://bugzilla.novell.com/show_bug.cgi?id=776117
https://bugzilla.novell.com/show_bug.cgi?id=776117#c8
--- Comment #8 from Martin Helm
https://bugzilla.novell.com/show_bug.cgi?id=776117
https://bugzilla.novell.com/show_bug.cgi?id=776117#c9
Petr Gajdos
The update.sh is what I used to get the skeleton for the spec, I have seen that it uses the spec.in file. The result had no similarity with the spec file used in the science repo, so it does not look as if the current spec file in the science repo was produce with the spec.in which is uploaded there.
Oh, I didn't notice that there was so heavy development :-). I actually wanted to look for updates in octave-forge in week or two (I used to update packages after every openSUSE release). (In reply to comment #8)
I'll rework the update.sh a bit and the octave-forge.spec.in to give a result that is compatible with the current structure of the spec file in science. Btw odepkg works now and making the gsl package work is an absolutely trivial fix, so I will add them and remove from blacklist.
Thanks a lot, if I can help somehow, just tell me. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=776117
https://bugzilla.novell.com/show_bug.cgi?id=776117#c10
--- Comment #10 from Claudio Freire
I'll rework the update.sh a bit and the octave-forge.spec.in to give a result that is compatible with the current structure of the spec file in science. Btw odepkg works now and making the gsl package work is an absolutely trivial fix, so I will add them and remove from blacklist.
I've been mantaining it by hand since an SR got accepted that made it difficult to use update.sh, but it would be nice to make it usable again. However, I'm wondering whether a python script using jinja templates wouldn't be easier to maintain (akin to py2pack templates). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=776117
https://bugzilla.novell.com/show_bug.cgi?id=776117#c11
--- Comment #11 from Claudio Freire
So finally the correct way which I can confirm with local osc builds (the resulting rpm's wor as expected):
octave -qf --eval "pkg prefix %{buildroot}%{octpackages_dir} %{buildroot}%{octlib_dir}; pkg install -nodeps $archive"
(in the install loop) where octlib_dir is %{_libdir}/octave/packages so that the architecture dependent binaries go to the correct location where octave's packaging system expects them.
Did a quick test, that command doesn't seem to work[0]. Are you sure that command is right?
I build the packages now also in my obs home project to see how it works there home:martin_helm/octave-forge
What I see in your home[1] doesn't actually change the build (unless the diff[2] is lying to me) About the issue itself, I would have to get to my computer and do a few tests. [0] https://build.opensuse.org/package/live_build_log?arch=x86_64&package=octave-forge&project=home%3Aklaussfreire%3Abranches%3Ascience&repository=openSUSE_12.1 [1] https://build.opensuse.org/package/show?package=octave-forge&project=home%3Amartin_helm [2] https://build.opensuse.org/package/rdiff?opackage=octave-forge&oproject=science&package=octave-forge&project=home%3Amartin_helm&rev=18 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=776117
https://bugzilla.novell.com/show_bug.cgi?id=776117#c12
--- Comment #12 from Petr Gajdos
What I see in your home[1] doesn't actually change the build (unless the diff[2] is lying to me)
It is at least lying about author of this change, so don't forget to set correct name in changelog entry ;-). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=776117
https://bugzilla.novell.com/show_bug.cgi?id=776117#c13
--- Comment #13 from Martin Helm
https://bugzilla.novell.com/show_bug.cgi?id=776117
https://bugzilla.novell.com/show_bug.cgi?id=776117#c14
--- Comment #14 from Martin Helm
https://bugzilla.novell.com/show_bug.cgi?id=776117
https://bugzilla.novell.com/show_bug.cgi?id=776117#c15
--- Comment #15 from Claudio Freire
in reply to comment 11:
you need to create the directories needed
mkdir -p %{buildroot}%{octpackages_dir} mkdir -p %{buildroot}%{octlib_dir} for archive in `ls | egrep .*[0-9].*.tar.gz`; do mkdir -p %{buildroot}%{octlib_dir}/$(echo "${archive%.*.*}")
You're right. Although the mkdir in the loop isn't necessary it seems. However, some packages don't install binaries. This means update.sh just got really hard - how does it know whether the files section should include the binary path or not? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=776117
https://bugzilla.novell.com/show_bug.cgi?id=776117#c16
--- Comment #16 from Martin Helm
https://bugzilla.novell.com/show_bug.cgi?id=776117
https://bugzilla.novell.com/show_bug.cgi?id=776117#c17
--- Comment #17 from Claudio Freire
https://bugzilla.novell.com/show_bug.cgi?id=776117
https://bugzilla.novell.com/show_bug.cgi?id=776117#c18
Petr Gajdos
https://bugzilla.novell.com/show_bug.cgi?id=776117
https://bugzilla.novell.com/show_bug.cgi?id=776117#c19
--- Comment #19 from Claudio Freire
https://bugzilla.novell.com/show_bug.cgi?id=776117
https://bugzilla.novell.com/show_bug.cgi?id=776117#c20
Claudio Freire
participants (1)
-
bugzilla_noreply@novell.com