[Bug 617623] New: xpdf crashes in XPutImage, *image is NULL
http://bugzilla.novell.com/show_bug.cgi?id=617623 http://bugzilla.novell.com/show_bug.cgi?id=617623#c0 Summary: xpdf crashes in XPutImage, *image is NULL Classification: openSUSE Product: openSUSE 11.2 Version: Final Platform: x86-64 OS/Version: Linux Status: NEW Severity: Normal Priority: P5 - None Component: X11 Applications AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: olaf@aepfle.de QAContact: qa@suse.de Found By: Outsourced Testing Blocker: --- Created an attachment (id=371912) --> (http://bugzilla.novell.com/attachment.cgi?id=371912) hwinfo-fsc-esprimo-mobile-m9400.txt 11.2-x86_64, kde4, FSC ESPRIMO Mobile M9400 xpdf crashes on certain pages when xpdf window is maximized. This is with "Understanding the Linux Virtual Memory Manager": http://ptgmedia.pearsoncmg.com/images/0131453483/downloads/gorman_book.pdf olaf@esprimo:~ $ env -i /bin/rpm -qfi /usr/bin/xpdf Name : xpdf-poppler Relocations: (not relocatable) Version : 3.02 Vendor: openSUSE Release : 4.5.1 Build Date: Tue Feb 16 00:58:37 2010 Install Date: Mon Mar 1 23:13:03 2010 Build Host: build30 Group : Productivity/Publishing/PDF Source RPM: xpdf-poppler-3.02-4.5.1.src.rpm Size : 382953 License: GPLv2 Signature : RSA/8, Tue Feb 16 00:59:00 2010, Key ID b88b2fd43dbdc284 Packager : http://bugs.opensuse.org URL : http://www.foolabs.com/xpdf/ Summary : A PDF File Viewer for the X Window System Description : This tool is used for viewing PDF (Portable Document Format) files. It is designed to be small and efficient. Authors: -------- Derek B. Noonburg <derekn@foolabs.com> Distribution: openSUSE 11.2 olaf@esprimo:~ $ gdb --readnow -ex 'r gorman_book.pdf ' /usr/bin/xpdf GNU gdb (GDB) SUSE (6.8.91.20090930-2.4) Copyright (C) 2009 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "x86_64-suse-linux". For bug reporting instructions, please see: <http://www.gnu.org/software/gdb/bugs/>... Reading symbols from /usr/bin/xpdf...expanding to full symbols...Reading symbols from /usr/lib/debug/usr/bin/xpdf.debug...expanding to full symbols...done. done. Starting program: /usr/bin/xpdf gorman_book.pdf type this in the xpdf window: ALT+F3 x to maximize xpdf window w to fit pdf document to window width g 133 to go to page 133 PG-DOWN a few times to scroll down now xpdf will crash in page 134. *image is NULL. Program received signal SIGSEGV, Segmentation fault. XPutImage (dpy=0x6a4180, d=50331831, gc=<value optimized out>, image=0x0, req_xoffset=0, req_yoffset=0, x=0, y=431, req_width=1242, req_height=258) at PutImage.c:969 969 if ((req_xoffset + width) > image->width) Current language: auto The current source language is "auto; currently c". (gdb) bt #0 XPutImage (dpy=0x6a4180, d=50331831, gc=<value optimized out>, image=0x0, req_xoffset=0, req_yoffset=0, x=0, y=431, req_width=1242, req_height=258) at PutImage.c:969 #1 0x000000000041dd19 in XPDFCore::redrawRect (this=0x731240, tileA=0x9b59d0, xSrc=<value optimized out>, ySrc=0, xDest=0, yDest=431, width=1242, height=258, composited=1) at XPDFCore.cc:1347 #2 0x0000000000417822 in PDFCore::redrawWindow (this=0x731240, x=0, y=0, width=1242, height=689, needUpdate=<value optimized out>) at PDFCore.cc:2027 #3 0x000000000041a951 in PDFCore::update (this=0x731240, topPageA=689, scrollXA=2, scrollYA=<value optimized out>, zoomA=<value optimized out>, rotateA=0, force=0, addToHist=0) at PDFCore.cc:704 #4 0x000000000041fce8 in XPDFCore::update (this=0x6a4180, topPageA=50331831, scrollXA=0, scrollYA=0, zoomA=-2, rotateA=0, force=0, addToHist=0) at XPDFCore.cc:286 #5 0x000000000041673d in PDFCore::scrollTo (this=0x6a4180, x=7541312, y=<value optimized out>) at PDFCore.cc:1015 #6 0x0000000000429746 in XPDFViewer::execCmd (this=<value optimized out>, cmd=0xc389c0, event=<value optimized out>) at XPDFViewer.cc:726 #7 0x0000000000429cab in XPDFViewer::keyPressCbk (data=0x6f9680, key=<value optimized out>, modifiers=<value optimized out>, event=0x7fffffffdc10) at XPDFViewer.cc:590 #8 0x000000000041e900 in XPDFCore::inputCbk (widget=<value optimized out>, ptr=0x731240, callData=0x7fffffffd5f0) at XPDFCore.cc:1152 #9 0x00007ffff63a1c7f in XtCallCallbackList (widget=0x739100, callbacks=0x7393b0, call_data=0x7fffffffd5f0) at Callback.c:617 #10 0x00007ffff75bb333 in _XmDrawingAreaInput (wid=0x739100, event=0x7fffffffdc10, params=<value optimized out>, num_params=<value optimized out>) at DrawingA.c:440 #11 0x00007ffff63d8b5d in HandleActions (w=<value optimized out>, event=0x7fffffffdc10, stateTree=<value optimized out>, accelWidget=<value optimized out>, procs=<value optimized out>, actions=0x72c810) at TMstate.c:636 #12 0x00007ffff63d8cb8 in HandleSimpleState (w=<value optimized out>, tmRecPtr=<value optimized out>, curEventPtr=0x7fffffffd7c0) at TMstate.c:875 #13 0x00007ffff63d9618 in _XtTranslateEvent (w=<value optimized out>, event=<value optimized out>) at TMstate.c:1093 #14 0x00007ffff63aff2b in XtDispatchEventToWidget (widget=0x739100, event=0x7fffffffdc10) at Event.c:898 #15 0x00007ffff63b0783 in _XtDefaultDispatcher (event=0x7fffffffdc10) at Event.c:1359 #16 0x00007ffff63af6e4 in XtDispatchEvent (event=0x30000b7) at Event.c:1415 #17 0x00007ffff63af88b in XtAppMainLoop (app=0x6a30b0) at Event.c:1552 #18 0x000000000042b37a in main (argc=2, argv=<value optimized out>) at xpdf.cc:328 (gdb) info threads * 1 process 31458 XPutImage (dpy=0x6a4180, d=50331831, gc=<value optimized out>, image=0x0, req_xoffset=0, req_yoffset=0, x=0, y=431, req_width=1242, req_height=258) at PutImage.c:969 (gdb) l 969 if ((req_xoffset + width) > image->width) 970 width = image->width - req_xoffset; 971 if ((req_yoffset + height) > image->height) 972 height = image->height - req_yoffset; 973 if ((width <= 0) || (height <= 0)) 974 return 0; (gdb) -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=617623 http://bugzilla.novell.com/show_bug.cgi?id=617623#c1 --- Comment #1 from Olaf Hering <olaf@aepfle.de> 2010-06-26 00:12:33 CEST --- olaf@esprimo:~ $ dmesg | grep xpdf [10981.355712] xpdf[13142]: segfault at 0 ip 00007f5d309477e0 sp 00007fffd94194e0 error 4 in libX11.so.6.2.0[7f5d3090c000+136000] [11010.700723] xpdf[14727]: segfault at 0 ip 00007f33ded5e7e0 sp 00007fff228f5190 error 4 in libX11.so.6.2.0[7f33ded23000+136000] [27991.825252] xpdf[17899]: segfault at 0 ip 00007fe4976147e0 sp 00007fffc7cb6140 error 4 in libX11.so.6.2.0[7fe4975d9000+136000] [28064.312883] xpdf[22186]: segfault at 0 ip 00007ffe71b4c7e0 sp 00007fff8e6e9dc0 error 4 in libX11.so.6.2.0[7ffe71b11000+136000] -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=617623 http://bugzilla.novell.com/show_bug.cgi?id=617623#c2 --- Comment #2 from Olaf Hering <olaf@aepfle.de> 2010-06-26 09:20:30 CEST --- Created an attachment (id=371934) --> (http://bugzilla.novell.com/attachment.cgi?id=371934) XPDFCore.cc.patch this patch avoids the crashes for me: --- XPDFCore.cc | 3 +++ 1 file changed, 3 insertions(+) --- xpdf-3.02-poppler.orig/XPDFCore.cc +++ xpdf-3.02-poppler/XPDFCore.cc @@ -1343,8 +1343,11 @@ void XPDFCore::redrawRect(PDFCoreTile *t // draw the document if (tile) { + if (tile->image) XPutImage(display, drawAreaWin, drawAreaGC, tile->image, xSrc, ySrc, xDest, yDest, width, height); + else + error(-1, "tile->image NULL in tile @ %p", tile); // draw the background } else { -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=617623 http://bugzilla.novell.com/show_bug.cgi?id=617623#c yang xiaoyu <xyyang@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xyyang@novell.com AssignedTo|bnc-team-screening@forge.pr |pgajdos@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=617623 http://bugzilla.novell.com/show_bug.cgi?id=617623#c Petr Gajdos <pgajdos@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=617623 http://bugzilla.novell.com/show_bug.cgi?id=617623#c Petr Gajdos <pgajdos@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=617623 http://bugzilla.novell.com/show_bug.cgi?id=617623#c3 Petr Gajdos <pgajdos@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO InfoProvider| |olaf@aepfle.de --- Comment #3 from Petr Gajdos <pgajdos@novell.com> 2010-07-01 10:20:16 UTC --- Olaf, unfortunately I can't reproduce this crash but fortunately I found another one. Could you please try go to full screen mode and then press 'g'. Does it crash for you too? If yes, this workaround should help: ---------------------------------------------------------------------- --- XPDFViewer.cc +++ XPDFViewer.cc @@ -844,6 +844,8 @@ void XPDFViewer::cmdFocusToPageNum(GooString *args[], int nArgs, XEvent *event) { + if (core->getFullScreen()) + return; XmTextFieldSetSelection(pageNumText, 0, strlen(XmTextFieldGetString(pageNumText)), XtLastTimestampProcessed(display)); ----------------------------------------------------------------------- I think, better solution would be to display window to prompt the page number, maybe I would do that in the future. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=617623 http://bugzilla.novell.com/show_bug.cgi?id=617623#c4 Olaf Hering <olaf@aepfle.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED InfoProvider|olaf@aepfle.de | --- Comment #4 from Olaf Hering <olaf@aepfle.de> 2010-07-05 11:05:08 CEST --- Yes, this fixes the crash in fullscreen mode, pressing g. I have seen this one also on a Thinkpad T500 last year. Please provide an online update for xpdf with both fixes. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=617623 http://bugzilla.novell.com/show_bug.cgi?id=617623#c5 Petr Gajdos <pgajdos@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO InfoProvider| |maintenance@opensuse.org --- Comment #5 from Petr Gajdos <pgajdos@novell.com> 2010-07-12 09:23:52 UTC --- For which opensuse releases we will do the update? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=617623 http://bugzilla.novell.com/show_bug.cgi?id=617623#c7 Christian Dengler <cdengler@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|andrea@opensuse.org | --- Comment #7 from Christian Dengler <cdengler@novell.com> 2010-07-14 13:55:50 UTC --- Sry for adding andrea mistakenly. Removing you. Was in the wrong bug instead of the lxsession-logout one. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=617623 http://bugzilla.novell.com/show_bug.cgi?id=617623#c10 Swamp Workflow Management <swamp@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard| |maint:running:34708:low --- Comment #10 from Swamp Workflow Management <swamp@suse.com> 2010-07-22 15:43:34 UTC --- The SWAMPID for this issue is 34708. This issue was rated as low. Please submit fixed packages as soon as possible. Also create a patchinfo file using this link: https://swamp.suse.de/webswamp/wf/34708 -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=617623 http://bugzilla.novell.com/show_bug.cgi?id=617623#c12 Petr Gajdos <pgajdos@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO InfoProvider| |cdengler@novell.com --- Comment #12 from Petr Gajdos <pgajdos@novell.com> 2010-07-30 09:41:54 UTC --- openSUSE 11.3: sr#44256 openSUSE 11.2: sr#44260 openSUSE 11.1: sr#44262 SLE 11 : sr#7444 SLE 11-SP1 : sr#7445 Could we get a swampid? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=617623 http://bugzilla.novell.com/show_bug.cgi?id=617623#c13 Christian Dengler <cdengler@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED InfoProvider|cdengler@novell.com | --- Comment #13 from Christian Dengler <cdengler@novell.com> 2010-08-02 11:10:31 UTC ---
Could we get a swampid? There is already one. See comment #11. SwampID: 34708
-- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=617623 http://bugzilla.novell.com/show_bug.cgi?id=617623#c14 --- Comment #14 from Petr Gajdos <pgajdos@novell.com> 2010-08-02 11:15:47 UTC --- (In reply to comment #13)
Could we get a swampid? There is already one. See comment #11. SwampID: 34708
Oh sorry I have missed it. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=617623 http://bugzilla.novell.com/show_bug.cgi?id=617623#c15 Petr Gajdos <pgajdos@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO InfoProvider| |cdengler@novell.com --- Comment #15 from Petr Gajdos <pgajdos@novell.com> 2010-08-02 11:49:07 UTC --- Patchinfos done. Please let me know, if they are ok. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=617623 http://bugzilla.novell.com/show_bug.cgi?id=617623#c16 Christian Dengler <cdengler@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED InfoProvider|cdengler@novell.com | --- Comment #16 from Christian Dengler <cdengler@novell.com> 2010-08-02 13:42:26 UTC --- Yes. Proofread done. Feel free to close the bug. Update will be released after one week in the update:test repo. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=617623 http://bugzilla.novell.com/show_bug.cgi?id=617623#c Swamp Workflow Management <swamp@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|maint:running:34708:low |maint:running:34708:low | |maint:planned:update -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=617623 http://bugzilla.novell.com/show_bug.cgi?id=617623#c17 Swamp Workflow Management <swamp@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|maint:running:34708:low |maint:running:34708:low |maint:planned:update |maint:released:11.1:34932 --- Comment #17 from Swamp Workflow Management <swamp@suse.com> 2010-08-09 14:42:47 UTC --- Update released for: xpdf, xpdf-debuginfo, xpdf-debugsource, xpdf-tools Products: openSUSE 11.1 (debug, i586, ppc, x86_64) -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=617623 http://bugzilla.novell.com/show_bug.cgi?id=617623#c18 Swamp Workflow Management <swamp@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|maint:running:34708:low |maint:running:34708:low |maint:released:11.1:34932 |maint:released:11.2:34929 | |maint:released:11.3:34929 --- Comment #18 from Swamp Workflow Management <swamp@suse.com> 2010-08-09 14:42:52 UTC --- Update released for: xpdf-poppler, xpdf-poppler-debuginfo, xpdf-poppler-debugsource Products: openSUSE 11.2 (debug, i586, x86_64) openSUSE 11.3 (debug, i586, x86_64) -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=617623 http://bugzilla.novell.com/show_bug.cgi?id=617623#c Swamp Workflow Management <swamp@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|maint:running:34708:low |maint:planned:update |maint:released:11.2:34929 | |maint:released:11.3:34929 | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=617623 http://bugzilla.novell.com/show_bug.cgi?id=617623#c19 Stefan For Personal Use <kdevel@vogtner.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kdevel@vogtner.de --- Comment #19 from Stefan For Personal Use <kdevel@vogtner.de> 2010-08-11 11:45:20 UTC --- I could not reproduce this bug in openSUSE 11.1/x86_64/kde3. Why is the fix applied to 11.1? OTOH there is a long standing issue with 11.1's pdf viewers, namely #597581 -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=617623 https://bugzilla.novell.com/show_bug.cgi?id=617623#c20 Petr Gajdos <pgajdos@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #20 from Petr Gajdos <pgajdos@novell.com> 2010-08-17 14:03:09 UTC --- (In reply to comment #19)
I could not reproduce this bug in openSUSE 11.1/x86_64/kde3. Why is the fix applied to 11.1?
We decided to test pointer on NULL even if I can't reproduce it as well.
OTOH there is a long standing issue with 11.1's pdf viewers, namely #597581
Please don't do reference of unrelated bug, even better is to add me in to CC of this bug, thanks! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=617623 https://bugzilla.novell.com/show_bug.cgi?id=617623#c Swamp Workflow Management <swamp@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|maint:planned:update |. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=617623 http://bugzilla.novell.com/show_bug.cgi?id=617623#c21 --- Comment #21 from Bernhard Wiedemann <bwiedemann@suse.com> --- This is an autogenerated message for OBS integration: This bug (617623) was mentioned in https://build.opensuse.org/request/show/42817 Factory / xpdf-poppler https://build.opensuse.org/request/show/44256 11.3:Test / xpdf-poppler https://build.opensuse.org/request/show/44260 11.2:Test / xpdf-poppler https://build.opensuse.org/request/show/44262 11.1 / xpdf -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com