http://bugzilla.novell.com/show_bug.cgi?id=529135

Summary: openvas-client-2.0.1-1.33: missing call to close Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: ---

I just had a look at factory package openvas-client-2.0.1-1.33

For source code file openvas-client-2.0.1/nessus/comm.c around line 870 is the source code for the function comm_send_file.

I notice the following line of code

fd = open(fname, O_RDONLY);

but I notice that close is only called on failure. Suggest add a call to close at the end of the routine, for the return success case. Like

network_gets(context->socket, buff, sizeof(buff) - 1); fclose( fd); return 0;