[Bug 1198449] New: ghostscript appears to be embedding zlib
https://bugzilla.suse.com/show_bug.cgi?id=1198449 Bug ID: 1198449 Summary: ghostscript appears to be embedding zlib Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem Assignee: screening-team-bugs@suse.de Reporter: dmueller@suse.com QA Contact: qa-bugs@suse.de Found By: --- Blocker: --- when you look at the build log, you can see that it is compiling its own copy of zlib: [ 98s] gcc -Wno-write-strings -I./zlib -Dverbose=-1 -DHAVE_MKSTEMP -DHAVE_FILE64 -DHAVE_FSEEKO -DHAVE_MKSTEMP64 -DHAVE_FONTCONFIG -DHAVE_SETLOCALE -DHAVE_SSE2 -DHAVE_DBUS -DHAVE_BSWAP32 -DHA VE_BYTESWAP_H -DHAVE_STRERROR -DHAVE_ISNAN -DHAVE_ISINF -DHAVE_PREAD_PWRITE=1 -DGS_RECURSIVE_MUTEXATTR=PTHREAD_MUTEX_RECURSIVE -fPIC -O2 -DNDEBUG -fPIC \ [ 98s] -Wall -Wstrict-prototypes -Wundef -Wmissing-declarations -Wmissing-prototypes -Wwrite-strings -fno-strict-aliasing -Werror=declaration-after-statement -fno-builtin -fno-common -Werror=return-type -DHAVE_STDINT_H=1 -DHAVE_DIRENT_H=1 -DHAVE_SYS_DIR_H=1 -DHAVE_SYS_TIME_H=1 -DHAVE_SYS_TIMES_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_LIBDL=1 -DGX_COLOR_INDEX_TYPE="unsigned long long" -D__USE_UNIX98=1 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -fno-strict-aliasing -fPIC -DHAVE_RESTRICT=1 -fno-strict-aliasing -DHAVE_POPEN_PROTO=1 -DGS_DEVS_SHARED -DGS_DEVS_SHARED_DIR=\"/usr/lib64/ghostscript/9.54.0\" -o ./soobj/deflate.o -c ./zlib/deflate.c it should use the system provided one instead. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1198449 Marcus Meissner <meissner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |meissner@suse.com -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1198449 Marcus Meissner <meissner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|screening-team-bugs@suse.de |werner@suse.com -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1198449 https://bugzilla.suse.com/show_bug.cgi?id=1198449#c2 Dirk Mueller <dmueller@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|werner@suse.com |martin.wilck@suse.com --- Comment #2 from Dirk Mueller <dmueller@suse.com> --- It appears other distros have no problem with removing the in-tree copies: https://src.fedoraproject.org/rpms/ghostscript/blob/rawhide/f/ghostscript.sp... -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1198449 https://bugzilla.suse.com/show_bug.cgi?id=1198449#c3 Martin Wilck <martin.wilck@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|martin.wilck@suse.com |jsmeix@suse.com --- Comment #3 from Martin Wilck <martin.wilck@suse.com> --- I'm not the cups maintainer, either. Trying Johannes. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1198449 https://bugzilla.suse.com/show_bug.cgi?id=1198449#c4 Martin Wilck <martin.wilck@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.wilck@suse.com --- Comment #4 from Martin Wilck <martin.wilck@suse.com> --- s/cups/ghostscript/ -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1198449 https://bugzilla.suse.com/show_bug.cgi?id=1198449#c7 --- Comment #7 from Johannes Meixner <jsmeix@suse.com> --- I wished I found more time for things like that but in practice that never happens. For me the main problem is that /usr/share/doc/ghostscript/9.54.0/thirdparty.htm which is also online at https://ghostscript.com/doc/9.54.0/thirdparty.htm does not tell WHY each particular third party library is included in Ghostscript. Using a system library instead of Ghostscript's included library might cause (possibly subtle) regressions because third party sources that are included in the Ghostscript sources are (always/sometimes?) modified by Ghostscript upstream for special Ghostscript needs or Ghostscript depends on the exact version of the included third party source so some (possibly subtle) things may fail when Ghostscript is compiled with the system's library. E.g. see my comments about lcms2 in ghostscript.spec and in ghostscript.changes. I know basically nothing at all about zlib (except it is used for data-compression) so I cannot simply do actually useful things for issues related to zlib in Ghostscript. I would have to digg into the zlib area which requires some "extra" time but that never appears in practice so such issues just hang... -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1198449 https://bugzilla.suse.com/show_bug.cgi?id=1198449#c8 --- Comment #8 from Dirk Mueller <dmueller@suse.com> --- I made the hard work and used a tool called diff(1): $ diff -wur zlib-1.2.11 ../ghostscript/ghostscript-9.54.0/zlib/ | diffstat 0 files changed There is no ghostscript specific modification. its the pure upstream tarball, without any fixes or patches. I also already submitted a fix, almost 3 weeks ago: https://build.opensuse.org/request/show/969841 please consider reviewing it. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1198449 https://bugzilla.suse.com/show_bug.cgi?id=1198449#c9 --- Comment #9 from Johannes Meixner <jsmeix@suse.com> --- What you praise as "made the hard work" is only one single step that only shows that with current Ghostscript sources and our current zlib version 1.2.11 in openSUSE:Factory, SLE15 and Leap 15.2 things could match - provided we do not have patches in our zlib - so all could be well currently BUT we do have patches in our zlib and even if all would be well currently things may fall apart in the future. I experienced such kind of quick and dirty contributions way too often in the past and then it is always me alone who must later clean up the mess when subtle regressions appear for our users because of careless "optimizations" by SUSE contributors. If you would be willing to co-maintain Ghostscript when it is built with our zlib in the future your https://build.opensuse.org/request/show/969841 would be "just acceptable" by me - i.e. I mean it would be you who checks each time when Ghostscript upgrades or when our zlib changes if things still fit together and it is you who talks to Ghostscript upstream to get an understanding if all should be well for Ghostscript with basically any (reasonable up to date) zlib version. FYI: The included third-party software sources in Ghostscript are a pain and an annoyance which I wished to clean up together with Ghostscript upstream but (as written above): I wished I found more time for things like that but in practice that never happens. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1198449 https://bugzilla.suse.com/show_bug.cgi?id=1198449#c10 --- Comment #10 from Dirk Mueller <dmueller@suse.com> ---
If you would be willing to co-maintain Ghostscript when it is built with our zlib in the future your https://build.opensuse.org/request/show/969841 would be "just acceptable" by me
sure, if thats what it is needed to move this forward, then lets do it that way. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1198449 https://bugzilla.suse.com/show_bug.cgi?id=1198449#c11 Johannes Meixner <jsmeix@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |IN_PROGRESS --- Comment #11 from Johannes Meixner <jsmeix@suse.com> --- Wow! I am no longer alone - Ghostscript got a co-maintainer. Thank you for that - it is much appreciated. So https://build.opensuse.org/request/show/969841 is accepted. Let's see if it still builds for SLE12 in the Printing project as it did before --------------------------------------------------------------- # osc results -l Printing ghostscript openSUSE_Tumbleweed i586 ghostscript succeeded* openSUSE_Tumbleweed i586 ghostscript-mini succeeded* openSUSE_Tumbleweed x86_64 ghostscript succeeded* openSUSE_Tumbleweed x86_64 ghostscript-mini succeeded* openSUSE_Leap_15.3 x86_64 ghostscript succeeded* openSUSE_Leap_15.3 x86_64 ghostscript-mini succeeded* SLE_15_SP3 x86_64 ghostscript succeeded* SLE_15_SP3 x86_64 ghostscript-mini succeeded* SLE_12_SP5 x86_64 ghostscript succeeded* SLE_12_SP5 x86_64 ghostscript-mini succeeded* 15.4 x86_64 ghostscript succeeded* 15.4 x86_64 ghostscript-mini succeeded* --------------------------------------------------------------- because it could not build for SLE12 in home:dirkmueller:Factory with --------------------------------------------------------------- sle12 x86_64 unresolvable: nothing provides cups154-devel --------------------------------------------------------------- but in Printing there is cups154-SLE12 so it should work ... and it does: --------------------------------------------------------------- # osc results Printing ghostscript openSUSE_Tumbleweed i586 ghostscript succeeded* openSUSE_Tumbleweed i586 ghostscript-mini succeeded* openSUSE_Tumbleweed x86_64 ghostscript succeeded* openSUSE_Tumbleweed x86_64 ghostscript-mini succeeded* openSUSE_Leap_15.3 x86_64 ghostscript succeeded openSUSE_Leap_15.3 x86_64 ghostscript-mini succeeded SLE_15_SP3 x86_64 ghostscript succeeded SLE_15_SP3 x86_64 ghostscript-mini succeeded SLE_12_SP5 x86_64 ghostscript succeeded SLE_12_SP5 x86_64 ghostscript-mini succeeded 15.4 x86_64 ghostscript succeeded 15.4 x86_64 ghostscript-mini succeeded --------------------------------------------------------------- -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1198449 https://bugzilla.suse.com/show_bug.cgi?id=1198449#c12 Johannes Meixner <jsmeix@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|IN_PROGRESS |RESOLVED Resolution|--- |FIXED --- Comment #12 from Johannes Meixner <jsmeix@suse.com> --- It is also accepted in openSUSE:Factory via https://build.opensuse.org/request/show/987199 so this issue is fixed. -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠suse.com