[Bug 1225776] New: Flavor addons of package graphviz does not build with gcc14
https://bugzilla.suse.com/show_bug.cgi?id=1225776 Bug ID: 1225776 Summary: Flavor addons of package graphviz does not build with gcc14 Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Other Assignee: screening-team-bugs@suse.de Reporter: mjambor@suse.com QA Contact: qa-bugs@suse.de Blocks: 1220571 Target Milestone: --- Found By: --- Blocker: --- Gcc 14 newly by default treats as errors a number of situations which before were only warnings. For more information see https://gcc.gnu.org/gcc-14/porting_to.html and meta bug #1220571. Because of this, flavor addons of package graphviz fails to compile. This can be seen online at: https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:G... It can be reproduced locally with command: osc build --clean --alternative-project home:rguenther:nextgcc The error (that halts the build) is: [ 79s] tbl.c:173:15: error: assignment to ‘char *’ from incompatible pointer type ‘char (*)[1]’ [-Wincompatible-pointer-types] [ 79s] 173 | s = &cp[i].u.s; [ 79s] | ^ -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1225776 https://bugzilla.suse.com/show_bug.cgi?id=1225776#c1 --- Comment #1 from Martin Jambor <mjambor@suse.com> --- The error when compiling cmd/lefty/tbl.c can be fixed with the following patch. Accordig to https://graphviz.org/docs/cli/lefty/ it is deprecated and so we might need to carry that patch but that seems OK. --- graphviz-2.49.3/cmd/lefty/tbl.c~ 2021-10-23 00:02:14.000000000 +0000 +++ graphviz-2.49.3/cmd/lefty/tbl.c 2024-07-09 13:00:01.366640148 +0000 @@ -170,7 +170,7 @@ cp2[i] = cp[i]; if (cp2[i].next != C_NULL) cp2[i].next -= ci; - s = &cp[i].u.s; + s = &cp[i].u.s[0]; while (*s) s++; cn = (long) (s - (char *) &cp[i]) / sizeof (Code_t); -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1225776 https://bugzilla.suse.com/show_bug.cgi?id=1225776#c2 --- Comment #2 from Martin Jambor <mjambor@suse.com> --- Fixing that, there are incompatible pointer type errors in cmd/smyrna/polytess.c which upstream seemed to have addressed with https://gitlab.com/graphviz/graphviz/-/commit/87cc54644e40fccc0651b7fedc137b... However, the patch does not apply cleanly and so it seems it would be better to simply defer fixing this until we grab a new upstream version. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1225776 https://bugzilla.suse.com/show_bug.cgi?id=1225776#c3 --- Comment #3 from Martin Jambor <mjambor@suse.com> --- Which is what I did in https://build.opensuse.org/request/show/1186592 -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1225776 https://bugzilla.suse.com/show_bug.cgi?id=1225776#c4 Dr. Werner Fink <werner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |IN_PROGRESS --- Comment #4 from Dr. Werner Fink <werner@suse.com> --- (In reply to Martin Jambor from comment #2)
Fixing that, there are incompatible pointer type errors in cmd/smyrna/polytess.c which upstream seemed to have addressed with https://gitlab.com/graphviz/graphviz/-/commit/ 87cc54644e40fccc0651b7fedc137b3dd02b4514
However, the patch does not apply cleanly and so it seems it would be better to simply defer fixing this until we grab a new upstream version.
Only the `void` in the fucntion argument was missed ... so I've ported the commit as patch graphviz-87cc546.patch beside patch graphviz-2.49.3-boo1225776-gcc14.patch -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1225776 https://bugzilla.suse.com/show_bug.cgi?id=1225776#c5 --- Comment #5 from OBSbugzilla Bot <bwiedemann+obsbugzillabot@suse.com> --- This is an autogenerated message for OBS integration: This bug (1225776) was mentioned in https://build.opensuse.org/request/show/1199143 Factory / graphviz -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1225776 https://bugzilla.suse.com/show_bug.cgi?id=1225776#c7 Thomas Renninger <trenn@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|IN_PROGRESS |RESOLVED --- Comment #7 from Thomas Renninger <trenn@suse.com> --- This one got fixed by Werner some time ago already -> resolving fixed. -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠suse.com