[Bug 1013206] New: [Build 20161129] live installer does not check for password simplicity
http://bugzilla.opensuse.org/show_bug.cgi?id=1013206 Bug ID: 1013206 Summary: [Build 20161129] live installer does not check for password simplicity Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other URL: http://openqa.opensuse.org/tests/312496/modules/user_s ettings/steps/2 OS: Other Status: NEW Severity: Minor Priority: P5 - None Component: Live Medium Assignee: coolo@suse.com Reporter: okurz@suse.com QA Contact: qa-bugs@suse.de Found By: --- Blocker: --- ## Observation yast installer in scenario opensuse-Tumbleweed-KDE-Live-x86_64-kde-live_installation@64bit [user_settings](http://openqa.opensuse.org/tests/312496/modules/user_settings/steps/2) does not show an expected dialog noticing that the password might be too simple. ## Reproducible Fails every time in this scenario ## Expected result Compare to the dialog showing up in https://openqa.opensuse.org/tests/312409#step/user_settings/3 The password used is the same in both cases. ## Further details Always latest result in this scenario: [latest](http://openqa.opensuse.org/tests/latest?flavor=KDE-Live&arch=x86_64&machine=64bit&distri=opensuse&test=kde-live_installation&version=Tumbleweed) -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1013206
http://bugzilla.opensuse.org/show_bug.cgi?id=1013206#c1
Stephan Kulow
http://bugzilla.opensuse.org/show_bug.cgi?id=1013206
http://bugzilla.opensuse.org/show_bug.cgi?id=1013206#c3
Fabian Vogt
http://bugzilla.opensuse.org/show_bug.cgi?id=1013206
http://bugzilla.opensuse.org/show_bug.cgi?id=1013206#c20
Ancor Gonzalez Sosa
http://bugzilla.opensuse.org/show_bug.cgi?id=1013206
http://bugzilla.opensuse.org/show_bug.cgi?id=1013206#c21
Fabian Vogt
The main problem here is that the YaST code is conceived to work only on the inst-sys. I mean, it uses the so-called installation extensions to load dict-full dynamically. See this code:
https://github.com/yast/yast-users/blob/ 29d0c407f6d15a89da7cfa856c9f9e1c65dbeef0/src/modules/UsersSimple.pm#L973
Thanks for the analysis!
But that results in the following errors in the logs:
[Ruby] modules/InstExtensionImage.rb:386 Calling: extend 'cracklib-dict-full.rpm' [bash] ShellCommand.cc(shellcommand):78 sh: extend: command not found [Ruby] modules/InstExtensionImage.rb:388 Returned: $["exit":127, "stderr":"sh: extend: command not found\n", "stdout":""] [Ruby] modules/InstExtensionImage.rb:392 'extend' failed! [Ruby] users/local_password.rb:97 loading cracklib failed, not used for pw check[Ruby] modules/InstExtensionImage.rb:418 Package cracklib-dict-full.rpm wasn't integrated
We would need either to adapt YaST to recognize the situation and not try to use the installer extensions (i.e. using the 'extend' command) or to provide 'extend' in the live system with a different behavior when compared to the inst-sys (e.g. checking if something is there, instead of trying to load it temporarily.
I guess using this as /usr/sbin/extend: #!/bin/bash rpm -q ${1%%.rpm} >/dev/null >&1 || zypper --non-interactive in ${1%%.rpm} would work as a workaround. Maybe it's even a proper fix, I'm not sure how this behaves in certain situations. I'll try to give this a try in live-net-installer. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1013206
http://bugzilla.opensuse.org/show_bug.cgi?id=1013206#c22
Fabian Vogt
(In reply to Ancor Gonzalez Sosa from comment #20)
The main problem here is that the YaST code is conceived to work only on the inst-sys. I mean, it uses the so-called installation extensions to load dict-full dynamically. See this code:
https://github.com/yast/yast-users/blob/ 29d0c407f6d15a89da7cfa856c9f9e1c65dbeef0/src/modules/UsersSimple.pm#L973
Thanks for the analysis!
But that results in the following errors in the logs:
[Ruby] modules/InstExtensionImage.rb:386 Calling: extend 'cracklib-dict-full.rpm' [bash] ShellCommand.cc(shellcommand):78 sh: extend: command not found [Ruby] modules/InstExtensionImage.rb:388 Returned: $["exit":127, "stderr":"sh: extend: command not found\n", "stdout":""] [Ruby] modules/InstExtensionImage.rb:392 'extend' failed! [Ruby] users/local_password.rb:97 loading cracklib failed, not used for pw check[Ruby] modules/InstExtensionImage.rb:418 Package cracklib-dict-full.rpm wasn't integrated
We would need either to adapt YaST to recognize the situation and not try to use the installer extensions (i.e. using the 'extend' command) or to provide 'extend' in the live system with a different behavior when compared to the inst-sys (e.g. checking if something is there, instead of trying to load it temporarily.
I guess using this as /usr/sbin/extend:
#!/bin/bash rpm -q ${1%%.rpm} >/dev/null >&1 || zypper --non-interactive in ${1%%.rpm}
would work as a workaround. Maybe it's even a proper fix, I'm not sure how this behaves in certain situations. I'll try to give this a try in live-net-installer.
I tried it - it works if the package is already installed. Otherwise zypper aborts because YaST currently holds the lock. Any idea? -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1013206
http://bugzilla.opensuse.org/show_bug.cgi?id=1013206#c23
--- Comment #23 from Ancor Gonzalez Sosa
I guess using this as /usr/sbin/extend:
#!/bin/bash rpm -q ${1%%.rpm} >/dev/null >&1 || zypper --non-interactive in ${1%%.rpm}
would work as a workaround. Maybe it's even a proper fix, I'm not sure how this behaves in certain situations. I'll try to give this a try in live-net-installer.
I tried it - it works if the package is already installed. Otherwise zypper aborts because YaST currently holds the lock. Any idea?
To be honest, I was expecting the fake extend to simply return 0 if the package is already there and another exit code otherwise (basically the first half of your script). That should be enough as a workaround for the live installer case. I don't think is worth it (or even realistic) to actually install the package if it's missing. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1013206
http://bugzilla.opensuse.org/show_bug.cgi?id=1013206#c24
--- Comment #24 from Fabian Vogt
(In reply to Fabian Vogt from comment #22)
I guess using this as /usr/sbin/extend:
#!/bin/bash rpm -q ${1%%.rpm} >/dev/null >&1 || zypper --non-interactive in ${1%%.rpm}
would work as a workaround. Maybe it's even a proper fix, I'm not sure how this behaves in certain situations. I'll try to give this a try in live-net-installer.
I tried it - it works if the package is already installed. Otherwise zypper aborts because YaST currently holds the lock. Any idea?
To be honest, I was expecting the fake extend to simply return 0 if the package is already there and another exit code otherwise (basically the first half of your script). That should be enough as a workaround for the live installer case. I don't think is worth it (or even realistic) to actually install the package if it's missing.
If you think that it's not that important to implement that, I can submit the first part for now. Packages can be installed as usual on live media (with or without persistence), so there's no technical reason not to enable this. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1013206
http://bugzilla.opensuse.org/show_bug.cgi?id=1013206#c26
Fabian Vogt
http://bugzilla.opensuse.org/show_bug.cgi?id=1013206
http://bugzilla.opensuse.org/show_bug.cgi?id=1013206#c27
Dominique Leuenberger
openQA reports that the softfail is gone -> fixed!
Verification screenshot: https://openqa.opensuse.org/tests/671631#step/user_settings/3 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1013206
http://bugzilla.opensuse.org/show_bug.cgi?id=1013206#c28
Oliver Kurz
http://bugzilla.opensuse.org/show_bug.cgi?id=1013206
http://bugzilla.opensuse.org/show_bug.cgi?id=1013206#c32
Fabian Vogt
http://bugzilla.opensuse.org/show_bug.cgi?id=1013206
http://bugzilla.opensuse.org/show_bug.cgi?id=1013206#c33
Oliver Kurz
participants (1)
-
bugzilla_noreply@novell.com