[Bug 1092489] New: GCC 8: schily build fails on i586
http://bugzilla.opensuse.org/show_bug.cgi?id=1092489 Bug ID: 1092489 Summary: GCC 8: schily build fails on i586 Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem Assignee: bnc-team-screening@forge.provo.novell.com Reporter: martin.liska@suse.com QA Contact: qa-bugs@suse.de Found By: --- Blocker: --- Please take a look here: https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:C... -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1092489
Martin Liška
http://bugzilla.opensuse.org/show_bug.cgi?id=1092489
Dominique Leuenberger
http://bugzilla.opensuse.org/show_bug.cgi?id=1092489
http://bugzilla.opensuse.org/show_bug.cgi?id=1092489#c13
Martin Liška
http://bugzilla.opensuse.org/show_bug.cgi?id=1092489
http://bugzilla.opensuse.org/show_bug.cgi?id=1092489#c14
--- Comment #14 from Jörg Schiling
http://bugzilla.opensuse.org/show_bug.cgi?id=1092489
http://bugzilla.opensuse.org/show_bug.cgi?id=1092489#c15
--- Comment #15 from Martin Liška
Hi, thank you for pinging me with your current state.
Let me comment:
+#define _GNU_SOURCE 1 /* eaccess */
This is a NO-OP since this definition already is in the standard Linux #defines since March 2009
+ FINFO finfo = {};
This is an interesting result from a copy/paste from July 2005. I prefer
finfo.f_flags = 0, since your code is not portable.
BTW: could you explain https://build.opensuse.org/package/view_file/utilities/schily/gcc48wa.diff please?
I would remove it. I can confirm that build succeeds w/o the patch.
Do you really get a warning here? The code has been modified in March 2012 to avoid buffer overflow warnings.
-- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1092489
http://bugzilla.opensuse.org/show_bug.cgi?id=1092489#c16
--- Comment #16 from Jan Engelhardt
+#define _GNU_SOURCE 1 /* eaccess */
This is a NO-OP since this definition already is in the standard Linux #defines >since March 2009
Indeed it is included in the standard Linux flags. But the Linux flags are not used by psmake/MAKE-sh.
could you explain https://build.opensuse.org/package/view_file/utilities/schily/gcc48wa.diff please?
gcc-4.8 complained about missing zero-termination of the buffer; it's a bug in gcc and fixed in gcc 5. The patch is technically no longer needed since we do not have 4.8 anymore. -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com