Comment # 15 on bug 1092489 from
(In reply to J��rg Schiling from comment #14)
> Hi, thank you for pinging me with your current state.
> 
> Let me comment:
> 
> +#define _GNU_SOURCE 1 /* eaccess */
> 
> This is a NO-OP since this definition already is in the standard Linux
> #defines since March 2009
> 
> +		FINFO	finfo = {};
> 
> This is an interesting result from a copy/paste from July 2005. I prefer
> 
> finfo.f_flags = 0, since your code is not portable.
> 
> BTW: could you explain
> https://build.opensuse.org/package/view_file/utilities/schily/gcc48wa.diff
> please?

I would remove it. I can confirm that build succeeds w/o the patch.

> 
> Do you really get a warning here? The code has been modified in March 2012
> to avoid buffer overflow warnings.


You are receiving this mail because: