[Bug 1062068] New: X server should exit anymore when logind (v234) is restarted - openSUSE Bugs - openSUSE Mailing Lists

newer
[Bug 1083869] Starting vncserver...

[Bug 1062068] New: X server should exit anymore when logind (v234) is restarted

older
[Bug 1163720] Display is broken in...

bugzilla_noreply＠novell.com

6 Oct 2017 6 Oct '17

13:52

http://bugzilla.suse.com/show_bug.cgi?id=1062068 Bug ID: 1062068 Summary: X server should exit anymore when logind (v234) is restarted Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: X.Org Assignee: xorg-maintainer-bugs@forge.provo.novell.com Reporter: fbui@suse.com QA Contact: xorg-maintainer-bugs@forge.provo.novell.com Found By: --- Blocker: --- Previously, logind didn't fully support restarting as the file descriptors of the session devices shared with the X server weren't saved. Due to this limitation a workaround was added in the X server [1] so the server exits as soon as it detects logind was stopped or restarted. However since v234, logind saves/reloads the fds before/after restarting so the revocation logic continue to work properly. Therefore the workaround [1] mentioned above is no more needed. However it's still not clear what should be done if logind is stopped completely. It's being discussed here [2]. This bug was opened so this issue is not lost on our side. [1] https://cgit.freedesktop.org/xorg/xserver/commit/?id=dc48bd653c7e1013e2d69e3... [2] https://github.com/systemd/systemd/pull/5600#issuecomment-328023750 -- You are receiving this mail because: You are on the CC list for the bug.

Attachments:

attachment.htm (text/html — 3.1 KB)

Reply

Sign in to reply online Use email software

Show replies by date

bugzilla_noreply＠novell.com

6 Oct 6 Oct

13:52

New subject: [Bug 1062068] X server should exit anymore when logind (v234) is restarted

http://bugzilla.suse.com/show_bug.cgi?id=1062068 Franck Bui changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sndirsch@suse.de -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

13:52

New subject: [Bug 1062068] X server should exit anymore when logind (v234) is restarted

http://bugzilla.suse.com/show_bug.cgi?id=1062068 Franck Bui changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |msrb@suse.com -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

14:02

New subject: [Bug 1062068] X server should exit anymore when logind (v234) is restarted

http://bugzilla.suse.com/show_bug.cgi?id=1062068 Stefan Dirsch changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium Status|NEW |CONFIRMED -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

20 Oct 20 Oct

01:55

New subject: [Bug 1062068] X server should not exit anymore when logind (v234) is restarted

http://bugzilla.suse.com/show_bug.cgi?id=1062068 Stefan Dirsch changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|X server should exit |X server should not exit |anymore when logind (v234) |anymore when logind (v234) |is restarted |is restarted -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

01:59

New subject: [Bug 1062068] X server should not exit anymore when logind (v234) is restarted

http://bugzilla.suse.com/show_bug.cgi?id=1062068 http://bugzilla.suse.com/show_bug.cgi?id=1062068#c1 Stefan Dirsch changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|xorg-maintainer-bugs@forge. |msrb@suse.com |provo.novell.com | Severity|Normal |Enhancement --- Comment #1 from Stefan Dirsch --- Michal is looking into this. Reassigning. -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

06:42

New subject: [Bug 1062068] X server should not exit anymore when logind (v234) is restarted

http://bugzilla.suse.com/show_bug.cgi?id=1062068 http://bugzilla.suse.com/show_bug.cgi?id=1062068#c3 --- Comment #3 from Michal Srb --- Summarize of the development so far: * It is not possible to recognize stop from restart just by listening on dbus. It was rather ugly way to detect it anyway. * X server could register itself as a transient unit requiring (or binding to, or wanting, ...) systemd-logind. I have working prototype of this, but now it seems that there is no way to configure systemd unit to stop if dependency stops, but do nothing if dependency restarts. * Could we instead prevent the lockup on virtual console switch? Then we would not need all this tracking of systemd-logind. Investigating that now. * Another alternative is to simply not care. Nothing will break if systemd-logind restarts. If it stops or crashes, then there is the change of lockup - maybe it would be acceptable? -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

23 Oct 23 Oct

09:15

New subject: [Bug 1062068] X server should not exit anymore when logind (v234) is restarted

http://bugzilla.suse.com/show_bug.cgi?id=1062068 http://bugzilla.suse.com/show_bug.cgi?id=1062068#c4 --- Comment #4 from Franck Bui --- (In reply to Michal Srb from comment #3)

Summarize of the development so far: * It is not possible to recognize stop from restart just by listening on dbus. It was rather ugly way to detect it anyway.

I'm wondering if this couldn't be implemented though...

* X server could register itself as a transient unit requiring (or binding to, or wanting, ...) systemd-logind. I have working prototype of this, but now it seems that there is no way to configure systemd unit to stop if dependency stops, but do nothing if dependency restarts.

You meant that if A.service has "BindsTo=B.service", A is stopped if B is restarted ? -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

09:23

New subject: [Bug 1062068] X server should not exit anymore when logind (v234) is restarted

http://bugzilla.suse.com/show_bug.cgi?id=1062068 http://bugzilla.suse.com/show_bug.cgi?id=1062068#c5 --- Comment #5 from Michal Srb --- (In reply to Franck Bui from comment #4)

...
* It is not possible to recognize stop from restart just by listening on dbus. It was rather ugly way to detect it anyway.

I'm wondering if this couldn't be implemented though...

I guess it could be. If systemd-logind would send some signal saying "Hey I am going away and not coming back any time soon.", we could listen for that. It does not solve the case when systemd-logind crashes, but in my opinion we shouldn't try too hard in that case. If such important component crashes, I would expect anything can happen, so why should X server have some special safety against it.

You meant that if A.service has "BindsTo=B.service", A is stopped if B is restarted ?

With BindsTo I am observing this: * If B is stopped, then A is stopped. Good, we want that. * If B is restarted, then A is restarted. Bad, we don't want that. -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

09:37

New subject: [Bug 1062068] X server should not exit anymore when logind (v234) is restarted

http://bugzilla.suse.com/show_bug.cgi?id=1062068 http://bugzilla.suse.com/show_bug.cgi?id=1062068#c6 --- Comment #6 from Franck Bui --- (In reply to Michal Srb from comment #5)

I guess it could be. If systemd-logind would send some signal saying "Hey I am going away and not coming back any time soon.", we could listen for that.

It does not solve the case when systemd-logind crashes, but in my opinion we shouldn't try too hard in that case. If such important component crashes, I would expect anything can happen, so why should X server have some special safety against it.

Might be worth to ask if upstream would accept to implement such signal.

With BindsTo I am observing this: * If B is stopped, then A is stopped. Good, we want that. * If B is restarted, then A is restarted. Bad, we don't want that.

Hmm... I'm not sure what the right behavior should be: currently I dont see the point to restart A if B is restarted. A should be stopped in case the restart of B fails though. -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

27 Mar 27 Mar

15:22

New subject: [Bug 1062068] X server should not exit anymore when logind (v234) is restarted

http://bugzilla.suse.com/show_bug.cgi?id=1062068 Stefan Dirsch changed: What |Removed |Added ---------------------------------------------------------------------------- CC|msrb@suse.com | -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

15:34

New subject: [Bug 1062068] X server should not exit anymore when logind (v234) is restarted

http://bugzilla.suse.com/show_bug.cgi?id=1062068 Stefan Dirsch changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|msrb@suse.com |xorg-maintainer-bugs@forge. | |provo.novell.com -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

16:37

New subject: [Bug 1062068] X server should not exit anymore when logind (v234) is restarted

http://bugzilla.suse.com/show_bug.cgi?id=1062068 http://bugzilla.suse.com/show_bug.cgi?id=1062068#c9 Stefan Dirsch changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fbui@suse.com Flags| |needinfo?(fbui@suse.com) --- Comment #9 from Stefan Dirsch --- Is this still an issue with current TW? -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

20:07

New subject: [Bug 1062068] X server should not exit anymore when logind (v234) is restarted

http://bugzilla.suse.com/show_bug.cgi?id=1062068 http://bugzilla.suse.com/show_bug.cgi?id=1062068#c10 Franck Bui changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(fbui@suse.com) | --- Comment #10 from Franck Bui --- Most likely but you should double check. At least the system I have which runs Xwayland still doesn't work properly when logind is restarted (sorry I don't have one which runs the X server as a non root user). That said I guess this bug could be forwarded to upstream as it's not specific to SUSE. -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

26 Feb 26 Feb

17:02

New subject: [Bug 1062068] X server should not exit anymore when logind (v234) is restarted

http://bugzilla.suse.com/show_bug.cgi?id=1062068 http://bugzilla.suse.com/show_bug.cgi?id=1062068#c11 Stefan Dirsch changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CONFIRMED |RESOLVED URL| |https://gitlab.freedesktop. | |org/xorg/xserver/issues/990 Resolution|--- |UPSTREAM --- Comment #11 from Stefan Dirsch --- Reported upstream: https://gitlab.freedesktop.org/xorg/xserver/issues/990 -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

1583

Age (days ago)

2456

Last active (days ago)

Download

14 comments

1 participants

tags

participants (1)

bugzilla_noreply＠novell.com