http://bugzilla.opensuse.org/show_bug.cgi?id=1030873 Oliver Kurz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |okurz@suse.com -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1030873 http://bugzilla.opensuse.org/show_bug.cgi?id=1030873#c27 Fabian Vogt changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |IN_PROGRESS --- Comment #27 from Fabian Vogt --- Except for icewm and lxqt-common all requests are now accepted in the devel projects and should arrive in factory soon, to be forwarded to 42.3 if it proves to work fine. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1030873 Fabian Vogt changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1039756 -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1030873 http://bugzilla.opensuse.org/show_bug.cgi?id=1030873#c34 --- Comment #34 from Fabian Vogt --- (In reply to Oliver Kurz from comment #33)

we are still failing to have auto-login but the SRs seem to be accepted -> https://openqa.opensuse.org/tests/420710#step/first_boot/21

what's missing?

Indeed, it looks like I changed it everywhere except for lxde, whoops. I'll submit that soon. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1030873 http://bugzilla.opensuse.org/show_bug.cgi?id=1030873#c36 --- Comment #36 from Dominique Leuenberger --- Created attachment 729751 --> http://bugzilla.opensuse.org/attachment.cgi?id=729751&action=edit y2logs from a local reproducer As noted, despite lxde now also setting up the default.desktop, this does not work. While debugging this locally, it shows that /etc/sysconfig/windowmanager STILL has the default set to 'xfce' - even though xfce is not being installed in my local test. /var/adm/filleup-templates/sysconfig.windowmanager (from aaa_base) has the defalut setting DEFAULT_WM="kde-plasma" - on my install /etc/sysconfig/windowmanager has DEFAULT_WM="xfce" - so definitively yast (or some thing else) must have changed the default. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1030873 http://bugzilla.opensuse.org/show_bug.cgi?id=1030873#c38 Lukas Ocilka changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo? --- Comment #38 from Lukas Ocilka --- In my quick test: Pattern selected for installation: patterns-openSUSE-lxde_laptop-20150918-26.5.x86_64.rpm Logs say: clients/desktop_finish.rb:128 Package xorg-x11-server selected or installed, desktop min_x matches clients/desktop_finish.rb:136 Setting logon manager - package selected clients/desktop_finish.rb:142 Setting window manager icewm - package selected clients/desktop_finish.rb:166 Default desktop: icewm clients/desktop_finish.rb:167 Default logon manager: clients/desktop_finish.rb:199 Logon manager shutdown: clients/desktop_finish.rb:207 sysconfig/displaymanager/DISPLAYMANAGER= And yes, for some reason, icewm-1.3.12-4.4.x86_64.rpm has been actually installed The answer to WTF is here: https://github.com/yast/skelcd-control-openSUSE/blob/openSUSE-42_3/control/c... And here: https://github.com/yast/yast-installation/blob/SLE-12-SP3/src/lib/installati... Installer tries to match the "selected desktop" using "installed packages", there is NO lxde definition in so no wonder it's not found. Guys, as you know what to put there, would you mind creating a PR for the control file change? -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1030873 http://bugzilla.opensuse.org/show_bug.cgi?id=1030873#c40 --- Comment #40 from Josef Reidinger --- (In reply to Lukas Ocilka from comment #38)

In my quick test:

Pattern selected for installation: patterns-openSUSE-lxde_laptop-20150918-26.5.x86_64.rpm

Logs say: clients/desktop_finish.rb:128 Package xorg-x11-server selected or installed, desktop min_x matches clients/desktop_finish.rb:136 Setting logon manager - package selected clients/desktop_finish.rb:142 Setting window manager icewm - package selected clients/desktop_finish.rb:166 Default desktop: icewm clients/desktop_finish.rb:167 Default logon manager: clients/desktop_finish.rb:199 Logon manager shutdown: clients/desktop_finish.rb:207 sysconfig/displaymanager/DISPLAYMANAGER=

And yes, for some reason, icewm-1.3.12-4.4.x86_64.rpm has been actually installed

The answer to WTF is here: https://github.com/yast/skelcd-control-openSUSE/blob/openSUSE-42_3/control/ control.openSUSE.xml#L243-L253

And here: https://github.com/yast/yast-installation/blob/SLE-12-SP3/src/lib/ installation/clients/desktop_finish.rb#L122-L164

Installer tries to match the "selected desktop" using "installed packages", there is NO lxde definition in so no wonder it's not found.

Guys, as you know what to put there, would you mind creating a PR for the control file change?

this behavior is in fact wrong. If custom is selected, then no desktop should be selected and should be kept empty, so it should be autoselected. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1030873 http://bugzilla.opensuse.org/show_bug.cgi?id=1030873#c42 --- Comment #42 from Lukas Ocilka --- The answer is: 1. When I was installing the system, I chose "Min X server" 2. Then I selected the LXDE pattern 3. Additionally, "desktops" are sorter according to the order <order config:type="integer">1</order> 4. Three desktops have the same order <name>kde</name> <name>gnome</name> <name>server</name> (then they are "sorted" and the result is: "server", "kde", "gnome") Possible solution in control file 1. Adjust sorting 2. Add more packages to <packages/> 3. Add LXDE BTW, we are reaching limits of the old use cases combined with new(er) role-selection dialog. They don't seem to play well together. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1030873 http://bugzilla.opensuse.org/show_bug.cgi?id=1030873#c44 Lukas Ocilka changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(lnussel@suse.com) --- Comment #44 from Lukas Ocilka --- (In reply to Ludwig Nussel from comment #37)

Thanks. This is important to Leap 42.3

Ludwig, this bug is reported for Tumbleweed. Leap uses different desktop selection dialog. I was actually testing Leap DVD, instead of TW. But as it seems, Josef talks about the TW behavior. This really makes a huge difference. So, what are your expectations here? -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1030873 http://bugzilla.opensuse.org/show_bug.cgi?id=1030873#c46 --- Comment #46 from Josef Reidinger --- (In reply to Lukas Ocilka from comment #44)

(In reply to Ludwig Nussel from comment #37)

...

Thanks. This is important to Leap 42.3

Ludwig, this bug is reported for Tumbleweed. Leap uses different desktop selection dialog. I was actually testing Leap DVD, instead of TW. But as it seems, Josef talks about the TW behavior. This really makes a huge difference. So, what are your expectations here?

we are talking about leap 42.3 and TW. There should be same dialog. What I mean by previous sentence, is that new desktop selection intentionally set default desktop to nil and in such case I hope it skip writting it to /etc/sysconfig/windowmanager and it will select desktop according to default.desktop but maybe it is not that case. I have to check it -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1030873 http://bugzilla.opensuse.org/show_bug.cgi?id=1030873#c48 Lukas Ocilka changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?, | |needinfo?(lnussel@suse.com) | --- Comment #48 from Lukas Ocilka --- My apologies, I was testing some ancient build of Leap 42.3 (dist.suse.de is way obsolete now) Anyway, thinking about Josef's solution... It may work, we only need to make sure that we don't break SLE. The whole code in finish client will need unit tests with these scenarios AND maybe even some refactoring. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1030873 http://bugzilla.opensuse.org/show_bug.cgi?id=1030873#c50 --- Comment #50 from Josef Reidinger --- short analysis of this bug from yast side. Problem is that desktop finish client trying to quess desktop from some predefined packages and it won't work for all desktop. Correct behavior for it should be to not write anything if no desktop is selected. The biggest challenge here is that same code also use SLED and SLES, so we have to be careful what is going to go there, to avoid breakage of it. One possibility is to have specific finish client on opensuse that replace one from SLE. So both code streams have own one. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1030873 http://bugzilla.opensuse.org/show_bug.cgi?id=1030873#c53 --- Comment #53 from Lukas Ocilka --- Considering the current state, copy & paste (decoupling) is the best way to change openSUSE behavior and keep SLE the same. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1030873 http://bugzilla.opensuse.org/show_bug.cgi?id=1030873#c55 --- Comment #55 from Lukas Ocilka --- Solution: Installer in Leap 42.3 will not write any default desktop or other sysconfig values of no desktop has been selected. Installer will not guess the desktop (and related settings) anymore in that case. Considering SLE behavior - it will not change (SLE 12 SP3), but it will change in SLE 15 where we plan to unify the solution with openSUSE. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1030873 http://bugzilla.opensuse.org/show_bug.cgi?id=1030873#c57 Dominique Leuenberger changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(dimstar@opensuse. | |org) | --- Comment #57 from Dominique Leuenberger --- (In reply to Josef Reidinger from comment #56)

I am testing my fix and it keeps there kde-plasma ( yast do not touch that file ) and result is that desktop env is icewm. So if needed, what should write there to have default.desktop working?

From the tests I did, DEFAULT_WM should be set to "" - then default.desktop

triggers (alternatively, we can also put 'default' - as in the end it just represents the .desktop file name -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1030873 http://bugzilla.opensuse.org/show_bug.cgi?id=1030873#c59 --- Comment #59 from Josef Reidinger --- (In reply to Dominique Leuenberger from comment #58)

as for the current setting remaining kde_plasma, that makes sense, as this would now mean that the default is properly defined in /var/adm/filleup-templates/sysconfig.windowmanager (from aaa_base)

In the current versions, this file contains "kde-plasma"; if we need to change this to 'default' ot '', I don't see a problem doing so (and yast no longer changing it, unless a specific role was selected, i.e GNOME or KDE.

that would be perfect. As change to yast2-installation have to go also to SP3 so I would like to have it minimal. For TW and SLE15 we can do whatever makes more sense. But keeping default defined by distro sounds very reasonable for me. So I will prepare pull request to SP3 and if you can modify aaa_base to contain e.g. that default. Thanks -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1030873 http://bugzilla.opensuse.org/show_bug.cgi?id=1030873#c61 --- Comment #61 from Josef Reidinger --- yes, yast change is at https://github.com/yast/yast-installation/pull/579 BTW I am targetting change to SP3, so probably also aaa_base have to be changed for leap42.3 -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1030873 http://bugzilla.opensuse.org/show_bug.cgi?id=1030873#c63 --- Comment #63 from Ludwig Nussel --- In a discussion with Dominique we agreed for TW to - get rid of DEFAULT_WM - try to add some code to aaa_base to migrate the DEFAULT_WM setting to update-alternatives. aaa_base already needs coreutils which is the only dependency of update-alternatives anyways. - remove the patch that reads DEFAULT_WM it from GDM - make GDM fall back to default.desktop first, then potentially gnome.desktop - apply the same logic to wayland sessions SDDM already doesn't read DEFAULT_WM so broken in that regard already since it's introduction -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1030873 http://bugzilla.opensuse.org/show_bug.cgi?id=1030873#c65 --- Comment #65 from Dominique Leuenberger --- DEFAULT_WM would simply be deprecated and not be written/read at all anymore Release Notes would need to be updated to indicate that the 'default' desktop is configured by means of update-alternatives, selecting the corresponding DE/WM -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1030873 http://bugzilla.opensuse.org/show_bug.cgi?id=1030873#c67 --- Comment #67 from Josef Reidinger --- (In reply to Ludwig Nussel from comment #66)

(In reply to Josef Reidinger from comment #64)

...

[...] well, in such case we have to update once more yast module, as we write DEFAULT_WM when user select other roles like KDE or GNOME. So if user select KDE role but install also GNOME pattern, what will be selected?

Depends on the priorities of update-alternatives. Right now the value gets written but SDDM ignores it...

so role based desktop selection will be only about package selection, right? -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1030873 http://bugzilla.opensuse.org/show_bug.cgi?id=1030873#c70 Dominique Leuenberger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|IN_PROGRESS |RESOLVED Resolution|--- |FIXED --- Comment #70 from Dominique Leuenberger --- I think we can close this by now: * the role based selector does not need to worry for it * lightdm no longer reads /etc/sysconfig/windowmanager, but relies on /usr/share/xsessions/default.desktop, which in turn is handled by update-alternatives As can be seen in openQA, the lxde tests are back to functional since those changes were introduced, meaning autologin for lxde is back operational oto -- You are receiving this mail because: You are on the CC list for the bug.