[Bug 812346] New: checkproc fails to give proper result.
https://bugzilla.novell.com/show_bug.cgi?id=812346 https://bugzilla.novell.com/show_bug.cgi?id=812346#c0 Summary: checkproc fails to give proper result. Classification: openSUSE Product: openSUSE 12.1 Version: Final Platform: x86-64 OS/Version: openSUSE 12.1 Status: NEW Severity: Major Priority: P5 - None Component: Basesystem AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: carlos.e.r@opensuse.org QAContact: qa-bugs@suse.de Found By: --- Blocker: --- Telcontar:~ # rcspamd status Checking for service spamd dead However, it is running at the expected place: Telcontar:~ # cat /var/run/spamd.pid 23803 Telcontar:~ # ps afxu | grep 23803 root 24147 0.0 0.0 6792 844 pts/14 S+ 19:08 0:00 | | \_ grep --color=auto 23803 root 23803 0.1 0.7 134552 57556 ? Ss 18:56 0:01 /usr/sbin/spamd -d -c --max-children=6 -r /var/run/spamd.pid But: Telcontar:~ # checkproc -v -p /var/run/spamd.pid /usr/sbin/spamd ; echo $? 1 Telcontar:~ # according to the manual, an exitcode of "1" means: 1 No process but pid file found which is obviously false, the process does exist at the given PID. Other services, like "rcpostfix", which uses the same code for the status result, work correctly. (Note that 12.1 is still supported, and it supports namely systemv as well as systemd) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=812346 https://bugzilla.novell.com/show_bug.cgi?id=812346#c Xiaolong Li <xlli@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xlli@suse.com AssignedTo|bnc-team-screening@forge.pr |werner@suse.com |ovo.novell.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=812346 https://bugzilla.novell.com/show_bug.cgi?id=812346#c1 Dr. Werner Fink <werner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WONTFIX --- Comment #1 from Dr. Werner Fink <werner@suse.com> 2013-04-08 08:24:20 UTC --- checkproc can not handle perl scripts which rewrite the command line. This is simply impossible as a) the exec link points to the perl binary and b) the command line does not show the script its self anymore. See `man checkproc', section BUGS: Identifying a process based on the executable file and the corresponding inode number only works if the process stays alive during startproc's execution. Processes rewriting their zeroth argument or shell scripts (the inode number of the shell executable file is not identical to that of the script file) may not be identified by a filename path. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=812346 https://bugzilla.novell.com/show_bug.cgi?id=812346#c2 Christian Boltz <suse-beta@cboltz.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |suse-beta@cboltz.de --- Comment #2 from Christian Boltz <suse-beta@cboltz.de> 2013-04-08 15:02:55 CEST --- Amavis has a similar problem, and it looks like the initscript contains a way to work around it. See /etc/init.d/amavis, line 31: # it's like checkproc, but works for scripts too: checkproc_script() { [...] Maybe spamd could also use this function? (not reopening - personally I don't care about spamd ;-) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=812346 https://bugzilla.novell.com/show_bug.cgi?id=812346#c3 --- Comment #3 from Dr. Werner Fink <werner@suse.com> 2013-04-08 13:48:59 UTC --- I wouldn't accept a reopen as checkproc initially was not written for catching scripts but todetect binaries with the help ofan inode comparision. The unsafe script extension was added to catch also scripts but this depends on the command line and the the argument number 0 and if this will be rewritten by e.g. perl checkproc is not able to make an assumption. The checkproc_script shell function does not make any check about the provided pid. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=812346 https://bugzilla.novell.com/show_bug.cgi?id=812346#c4 Carlos Robinson <carlos.e.r@opensuse.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|WONTFIX | --- Comment #4 from Carlos Robinson <carlos.e.r@opensuse.org> 2013-04-08 13:52:22 UTC --- It certainly works, I tried. After all, amavis and spamd are related projects. So, can now spamd be patched and and update submitted? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=812346 https://bugzilla.novell.com/show_bug.cgi?id=812346#c5 Dr. Werner Fink <werner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |werner@suse.com AssignedTo|werner@suse.com |varkoly@suse.com --- Comment #5 from Dr. Werner Fink <werner@suse.com> 2013-04-08 14:14:16 UTC --- Reassign to maintainer of spamassassin -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=812346 https://bugzilla.novell.com/show_bug.cgi?id=812346#c6 Dr. Werner Fink <werner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEEDINFO InfoProvider| |varkoly@suse.com --- Comment #6 from Dr. Werner Fink <werner@suse.com> 2013-05-16 20:30:01 UTC --- Ping? Had something happened here? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=812346 https://bugzilla.novell.com/show_bug.cgi?id=812346#c7 Peter Varkoly <varkoly@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |CLOSED InfoProvider|varkoly@suse.com | Resolution| |FIXED --- Comment #7 from Peter Varkoly <varkoly@suse.com> 2014-06-05 11:23:00 UTC --- On openSUSE 13.1 and SLE12 it works fine. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com