[Bug 1102261] New: "zypper patch --with update" should implicitly assume "--with-optional" and not tell me that I need to do something more to install optional patches, since it will install them anyway
http://bugzilla.opensuse.org/show_bug.cgi?id=1102261 Bug ID: 1102261 Summary: "zypper patch --with update" should implicitly assume "--with-optional" and not tell me that I need to do something more to install optional patches, since it will install them anyway Classification: openSUSE Product: openSUSE Distribution Version: Leap 15.0 Hardware: All OS: All Status: NEW Severity: Enhancement Priority: P5 - None Component: libzypp Assignee: zypp-maintainers@forge.provo.novell.com Reporter: antoine.mechelynck@gmail.com QA Contact: qa-bugs@suse.de Found By: --- Blocker: --- I'm reporting this in severity "enhancement" because it is an RFE, not a bug. The following is from my latest run of "zypper patch --with-update":
Loading repository data... Reading installed packages... Patch '8464-1' is optional. Use 'zypper in patch:8464' to install it, or '--with-optional' to include all optional patches. Resolving package dependencies...
The following 2 NEW packages are going to be installed: ffmpeg-3 libzimg2
The following package is going to be REMOVED: ffmpeg
The following 14 packages are going to be upgraded: libavcodec57 libavcodec58 libavdevice57 libavfilter6 libavformat57 libavformat58 libavresample3 libavutil55 libavutil56 libpostproc54 libsodium23 libswresample2 libswresample3 libswscale4
14 packages to upgrade, 2 new, 1 to remove. Overall download size: 8.5 MiB. Already cached: 0 B. After the operation, additional 997.9 KiB will be used. Continue? [y/n/...? shows all options] (y):
Of course, these 1 removed, 2 new and 14 updated packages are from patch 8464, and after letting this update run its course, "zypper lp -a" shows patch 8464 as "installed". So "--with-update" should not believe that it won't install optional patches: ideally, it should have said instead: "The following patch is going to be installed: 8464". -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1102261 http://bugzilla.opensuse.org/show_bug.cgi?id=1102261#c1 Michael Andres <ma@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium Status|NEW |CONFIRMED --- Comment #1 from Michael Andres <ma@suse.com> --- Yes, we should enhance the summary in that case. Implicitly assuming "--with-optional" is probably sufficient. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1102261 http://bugzilla.opensuse.org/show_bug.cgi?id=1102261#c2 --- Comment #2 from Tony Mechelynck <antoine.mechelynck@gmail.com> --- There was an update to libzypp and zypper at approx. 1AM CEST but no change: to day I see: linux-2iyu:~ # (zypper lu -t package -t patch || echo 'exit status' $? ; date ) 2>&1 |tee -a ~/zypper.log Retrieving repository 'RWTH:Leap-15.0-Packman' metadata [..done] Building repository 'RWTH:Leap-15.0-Packman' cache [....done] Retrieving repository 'FAU_:Leap-15.0-Packman' metadata [.done] Building repository 'FAU_:Leap-15.0-Packman' cache [....done] Retrieving repository 'SUSE:Leap-15.0-Update-Test' metadata [..done] Building repository 'SUSE:Leap-15.0-Update-Test' cache [....done] Loading repository data... Reading installed packages... Patches Repository | Name | Category | Severity | Interactive | Status | Summary ---------------------------+------+-------------+-----------+-------------+----------+----------------------------------- SUSE:Leap-15.0-Update-Test | 9067 | security | moderate | --- | needed | Security update for wpa_supplicant SUSE:Leap-15.0-Update-Test | 9071 | recommended | moderate | --- | needed | Recommended update for kmod SUSE:Leap-15.0-Update-Test | 9072 | optional | low | --- | optional | Optional update for tdb SUSE:Leap-15.0-Update-Test | 9073 | recommended | moderate | --- | needed | Recommended update for xdm SUSE:Leap-15.0-Update-Test | 9074 | recommended | important | --- | needed | Recommended update for xfsprogs Found 5 applicable patches: 1 patch optional (use '--with-optional' to include optional patches) 4 patches needed (1 security patch) Package updates S | Repository | Name | Current Version | Available Version | Arch --+----------------------------+----------------+-------------------+---------------------+------- v | SUSE:Leap-15.0-Update-Test | kmod | 25-lp150.3.1 | 25-lp150.4.3.1 | x86_64 v | SUSE:Leap-15.0-Update-Test | kmod-compat | 25-lp150.3.1 | 25-lp150.4.3.1 | x86_64 v | SUSE:Leap-15.0-Update-Test | libkmod2 | 25-lp150.3.1 | 25-lp150.4.3.1 | x86_64 v | SUSE:Leap-15.0-Update-Test | libtdb1 | 1.3.15-lp150.1.8 | 1.3.15-lp150.2.3.1 | x86_64 v | SUSE:Leap-15.0-Update-Test | libtdb1-32bit | 1.3.15-lp150.1.8 | 1.3.15-lp150.2.3.1 | x86_64 v | SUSE:Leap-15.0-Update-Test | python-tdb | 1.3.15-lp150.1.8 | 1.3.15-lp150.2.3.1 | x86_64 v | SUSE:Leap-15.0-Update-Test | tdb-tools | 1.3.15-lp150.1.8 | 1.3.15-lp150.2.3.1 | x86_64 v | SUSE:Leap-15.0-Update-Test | wpa_supplicant | 2.6-lp150.3.3.1 | 2.6-lp150.3.6.1 | x86_64 v | SUSE:Leap-15.0-Update-Test | xdm | 1.1.11-lp150.10.1 | 1.1.11-lp150.11.3.1 | x86_64 v | SUSE:Leap-15.0-Update-Test | xdm-xsession | 1.1.11-lp150.10.1 | 1.1.11-lp150.11.3.1 | x86_64 v | SUSE:Leap-15.0-Update-Test | xfsprogs | 4.15.0-lp150.2.1 | 4.15.0-lp150.3.4.1 | x86_64 Fri 26 Oct 19:10:07 CEST 2018 linux-2iyu:~ # (zypper patch --with-update || echo 'exit status' $? ; date ) 2>&1 |tee -a ~/zypper.log Loading repository data... Reading installed packages... Patch '9072-1' is optional. Use 'zypper in patch:9072' to install it, or '--with-optional' to include all optional patches. Resolving package dependencies... The following 4 NEW patches are going to be installed: 9067 9071 9073 9074 The following 11 packages are going to be upgraded: kmod kmod-compat libkmod2 libtdb1 libtdb1-32bit python-tdb tdb-tools wpa_supplicant xdm xdm-xsession xfsprogs 11 packages to upgrade. Overall download size: 2.6 MiB. Already cached: 0 B. After the operation, additional 1.9 MiB will be used. Continue? [y/n/...? shows all options] (y): -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1102261 http://bugzilla.opensuse.org/show_bug.cgi?id=1102261#c3 --- Comment #3 from Tony Mechelynck <antoine.mechelynck@gmail.com> --- oops, 1AM CEST on Tuesday. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1102261 http://bugzilla.opensuse.org/show_bug.cgi?id=1102261#c4 Michael Andres <ma@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #4 from Michael Andres <ma@suse.com> --- Fixed for zypper-1.14.19 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1102261 http://bugzilla.opensuse.org/show_bug.cgi?id=1102261#c6 --- Comment #6 from Tony Mechelynck <antoine.mechelynck@gmail.com> --- (In reply to Michael Andres from comment #4)
Fixed for zypper-1.14.19
The current zypper version on openSUSE 15.1 is 1.14.27 which means it should include this fix; its manpage is not very clear about this matter; it doesn't mention --with-optional except at the end of the description of package type "patch" at line 81. I'll test this fix the next time an optional patch comes around for my system (the only one so far for 15.1 is part of patch openSUSE-2019-1393 on the 15.1 Update-OSS repo, titled "test optional update for 15.1" and labeled "not needed"). -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1102261 http://bugzilla.opensuse.org/show_bug.cgi?id=1102261#c7 --- Comment #7 from Michael Andres <ma@suse.com> --- See
--with[out]-optional Whether applicable optional patches should be treated as needed or be excluded. The default is to exclude optional patches.
in list-patches, patch-check, patch. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1102261 http://bugzilla.opensuse.org/show_bug.cgi?id=1102261#c8 --- Comment #8 from Tony Mechelynck <antoine.mechelynck@gmail.com> --- (In reply to Michael Andres from comment #7)
See
--with[out]-optional Whether applicable optional patches should be treated as needed or be excluded. The default is to exclude optional patches.
in list-patches, patch-check, patch.
Ah, that's how I missed it: I searched for --with-optional and even for --with- but didn't think about --with[out]. Too obvious, maybe. Thanks for the pointer. Searching the manpage for --with[[o-] finds a lot of --with-, no separate --without-, and --with[out]- for only optional. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1102261 http://bugzilla.opensuse.org/show_bug.cgi?id=1102261#c9 --- Comment #9 from Michael Andres <ma@suse.com> --- (In reply to Tony Mechelynck from comment #8)
--with- but didn't think about --with[out]. Too obvious, maybe. Thanks for the pointer. Searching the manpage for --with[[o-] finds a lot of --with-, no separate --without-, and --with[out]- for only optional.
We'll separate them.... -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1102261 http://bugzilla.opensuse.org/show_bug.cgi?id=1102261#c13 Tony Mechelynck <antoine.mechelynck@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |VERIFIED Component|libzypp |Live Medium Version|Leap 15.0 |Jump 15.2.1 Assignee|zypp-maintainers@suse.de |fvogt@suse.com --- Comment #13 from Tony Mechelynck <antoine.mechelynck@gmail.com> --- I forgot to VERIFY this fix. Today on Leap 15.2 Update-Test there was an update (patch 16177) for libsolv and also among others an "optional" update (patch 16176) for tcpdump. After updating the package manager, "zypper lu -t package -t patch" said that --with optional was necessary to install the optional update (I suppose this is normal) but "zypper patch --with-update" installed it (as well as all other "needed" patches) with no warning message about its "optional" status, which VERIFIES this bugfix. -- You are receiving this mail because: You are on the CC list for the bug.
participants (2)
-
bugzilla_noreply＠novell.com -
bugzilla_noreply＠suse.com