[Bug 1208439] New: dracut will never use the network-wicked module due to a faulty check
https://bugzilla.suse.com/show_bug.cgi?id=1208439 Bug ID: 1208439 Summary: dracut will never use the network-wicked module due to a faulty check Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem Assignee: dracut-maintainers@suse.de Reporter: jbohac@suse.com QA Contact: qa-bugs@suse.de Found By: --- Blocker: --- modules.d/40network/module-setup.sh contains: if [[ -x $dracutsysrootdir$systemdsystemunitdir/wicked.service ]]; then network_handler="network-wicked" However, the service file is never executable, so this will always fail. The check should probably be "-e" instead of "-x" That said - once I fixed this, I found the wicked dracut module unable to properly bring up a simple network setup: (commandline: rd.neednet=1 ifname=kdump0:02:d1:ae:b5:70:9f bridge=br0:kdump0 ip=br0:dhcp) So fixing this will actually break stuff, because wicked has bugs. Not sure it's worth fixing wicked at this point, maybe the dracut wicked code should just be dropped? -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1208439 https://bugzilla.suse.com/show_bug.cgi?id=1208439#c1 Thomas Blume <thomas.blume@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thomas.blume@suse.com --- Comment #1 from Thomas Blume <thomas.blume@suse.com> --- (In reply to Jiri Bohac from comment #0)
modules.d/40network/module-setup.sh contains: if [[ -x $dracutsysrootdir$systemdsystemunitdir/wicked.service ]]; then network_handler="network-wicked"
However, the service file is never executable, so this will always fail. The check should probably be "-e" instead of "-x"
That said - once I fixed this, I found the wicked dracut module unable to properly bring up a simple network setup: (commandline: rd.neednet=1 ifname=kdump0:02:d1:ae:b5:70:9f bridge=br0:kdump0 ip=br0:dhcp)
So fixing this will actually break stuff, because wicked has bugs. Not sure it's worth fixing wicked at this point, maybe the dracut wicked code should just be dropped?
It's already fixed in git: --> Author: Antonio Alvarez Feijoo <antonio.feijoo@suse.com> Date: Mon Jan 10 11:46:41 2022 +0100 fix(network): wrong test of wicked unit The test for the wicked service is never met because it does not have execute permission. diff --git a/modules.d/40network/module-setup.sh b/modules.d/40network/module-setup.sh index 9fd5d806..d5edbf81 100755 --- a/modules.d/40network/module-setup.sh +++ b/modules.d/40network/module-setup.sh @@ -17,7 +17,7 @@ depends() { done if [ -z "$network_handler" ]; then - if [[ -x $dracutsysrootdir$systemdsystemunitdir/wicked.service ]]; then + if [[ -e $dracutsysrootdir$systemdsystemunitdir/wicked.service ]]; then network_handler="network-wicked" elif [[ -x $dracutsysrootdir/usr/libexec/nm-initrd-generator ]] || [[ -x $dracutsysrootdir/usr/lib/nm-initrd-generator ]]; then network_handler="network-manager" --< but I don't see it in the devel project yet. It will be part of one of the next submissions. Ok for you Jiri? -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1208439 https://bugzilla.suse.com/show_bug.cgi?id=1208439#c2 Jiri Bohac <jbohac@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Jiri Bohac <jbohac@suse.com> --- (In reply to Thomas Blume from comment #1)
(In reply to Jiri Bohac from comment #0) It's already fixed in git:
--> Author: Antonio Alvarez Feijoo <antonio.feijoo@suse.com> Date: Mon Jan 10 11:46:41 2022 +0100
fix(network): wrong test of wicked unit
Interesting, didn't check the upstream repo, thanks for that! Looking at upstream, I also see: 9dbbebb1339d1c3dc8e6b8835a6edbc95c66e2fe ("feat(network-wicked): remove module")
but I don't see it in the devel project yet. It will be part of one of the next submissions.
... so maybe it would be best not to fix the original problem. It will just uncover existing bugs in wicked and since there is probably no long term perspective in it, it will just waste people's time trying to fix them? Anyway, closing this one as fixed. Thanks! -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1208439 https://bugzilla.suse.com/show_bug.cgi?id=1208439#c3 Antonio Feijoo <antonio.feijoo@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |antonio.feijoo@suse.com --- Comment #3 from Antonio Feijoo <antonio.feijoo@suse.com> --- (In reply to Jiri Bohac from comment #2)
... so maybe it would be best not to fix the original problem. It will just uncover existing bugs in wicked and since there is probably no long term perspective in it, it will just waste people's time trying to fix them?
Sorry for chiming in late, I was on vacation. Yes, this was not fixed on purpose to avoid picking the faulty network-wicked module by default, unless the user explicitly adds it to the list of modules. I already sent the deprecation notice to the factory mailing list [1], it'll be removed with the next dracut release. Thanks! [1] https://lists.opensuse.org/archives/list/factory@lists.opensuse.org/thread/Y... -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠suse.com