Thomas Blume changed bug 1208439
What Removed Added
CC   thomas.blume@suse.com

Comment # 1 on bug 1208439 from
(In reply to Jiri Bohac from comment #0)
> modules.d/40network/module-setup.sh contains:
>         if [[ -x $dracutsysrootdir$systemdsystemunitdir/wicked.service ]];
> then
>             network_handler="network-wicked"
> 
> However, the service file is never executable, so this will always fail. The
> check should probably be "-e" instead of "-x"
> 
> That said - once I fixed this, I found the wicked dracut module unable to
> properly bring up a simple network setup:
> (commandline: rd.neednet=1 ifname=kdump0:02:d1:ae:b5:70:9f bridge=br0:kdump0
> ip=br0:dhcp)
> 
> So fixing this will actually break stuff, because wicked has bugs.
> Not sure it's worth fixing wicked at this point, maybe the dracut wicked
> code should just be dropped?


It's already fixed in git:


-->
Author: Antonio Alvarez Feijoo <antonio.feijoo@suse.com>
Date:   Mon Jan 10 11:46:41 2022 +0100

    fix(network): wrong test of wicked unit

    The test for the wicked service is never met because it
    does not have execute permission.

diff --git a/modules.d/40network/module-setup.sh
b/modules.d/40network/module-setup.sh
index 9fd5d806..d5edbf81 100755
--- a/modules.d/40network/module-setup.sh
+++ b/modules.d/40network/module-setup.sh
@@ -17,7 +17,7 @@ depends() {
     done

     if [ -z "$network_handler" ]; then
-        if [[ -x $dracutsysrootdir$systemdsystemunitdir/wicked.service ]];
then
+        if [[ -e $dracutsysrootdir$systemdsystemunitdir/wicked.service ]];
then
             network_handler="network-wicked"
         elif [[ -x $dracutsysrootdir/usr/libexec/nm-initrd-generator ]] || [[
-x $dracutsysrootdir/usr/lib/nm-initrd-generator ]]; then
             network_handler="network-manager"
--<

but I don't see it in the devel project yet.
It will be part of one of the next submissions.

Ok for you Jiri?


You are receiving this mail because: