[Bug 1202793] dracut: 05-convertfs.conf with problems
https://bugzilla.suse.com/show_bug.cgi?id=1202793
https://bugzilla.suse.com/show_bug.cgi?id=1202793#c4
--- Comment #4 from Antonio Feijoo
Ah, what I find is
# cat /etc/dracut.conf.d/05-convertfs.conf add_dracutmodules+="convertfs" add_dracutmodules+="convertfs" add_dracutmodules+="convertfs" add_dracutmodules+=" convertfs " add_dracutmodules+=" convertfs "
so whatever the fix from 2 years ago was (probably appending to the conf file), it just left the old entries alone.
Thanks for this feedback, this will help to improve the code.
Yes, the post-install script appends a line to that file, rather than
overwriting the contents of the file, and this maybe should be changed.
---
# check whether /var/run has been converted to a symlink
if [ ! -L /var/run ]; then
grep -q '^[ ]*GRUB_CMDLINE_LINUX_DEFAULT=.*rd.convertfs'
/etc/default/grub || \
sed -i '/^[ ]*GRUB_CMDLINE_LINUX_DEFAULT.*/s/"$/ rd.convertfs"/'
/etc/default/grub || :
if ! grep --no-message 'add_dracutmodules+=" convertfs "'
/etc/dracut.conf.d/05-convertfs.conf; then
--> cat >>/etc/dracut.conf.d/05-convertfs.conf<
participants (1)
-
bugzilla_noreply@suse.com