Comment # 4 on bug 1202793 from
(In reply to Jan Engelhardt from comment #3)
> Ah, what I find is
> 
> # cat /etc/dracut.conf.d/05-convertfs.conf
> add_dracutmodules+="convertfs"
> add_dracutmodules+="convertfs"
> add_dracutmodules+="convertfs"
> add_dracutmodules+=" convertfs "
> add_dracutmodules+=" convertfs "
> 
> so whatever the fix from 2 years ago was (probably appending to the conf
> file), it just left the old entries alone.

Thanks for this feedback, this will help to improve the code.

Yes, the post-install script appends a line to that file, rather than
overwriting the contents of the file, and this maybe should be changed.

---
# check whether /var/run has been converted to a symlink
if [ ! -L /var/run ]; then
    grep -q '^[     ]*GRUB_CMDLINE_LINUX_DEFAULT=.*rd.convertfs'
/etc/default/grub || \
    sed -i '/^[     ]*GRUB_CMDLINE_LINUX_DEFAULT.*/s/"$/ rd.convertfs"/'
/etc/default/grub  || :
    if ! grep --no-message 'add_dracutmodules+=" convertfs "'
/etc/dracut.conf.d/05-convertfs.conf; then
-->      cat >>/etc/dracut.conf.d/05-convertfs.conf<<EOF
add_dracutmodules+=" convertfs "
EOF
    fi
fi
---

But, there is a second part that removes the 05-convertfs.conf file, and it
never seems to be reached on your system.

---
#clean up after the conversion is done
if [ -L /var/run ] && [ -f /etc/dracut.conf.d/05-convertfs.conf ]; then
    sed -i '/^[     ]*GRUB_CMDLINE_LINUX_DEFAULT.*/s/rd.convertfs//'
/etc/default/grub || :
    [ -f /etc/dracut.conf.d/05-convertfs.conf ] && sed -i
'/add_dracutmodules+="[     ]*convertfs[     ]*"/d'
/etc/dracut.conf.d/05-convertfs.conf || :
--> [ -s /etc/dracut.conf.d/05-convertfs.conf ] || rm -f
/etc/dracut.conf.d/05-convertfs.conf || :
    [ -d /var/lock.lockmove~ ] && rm -rf /var/lock.lockmove~ || :
    [ -d /var/run.runmove~ ] && rm -rf /var/run.runmove~ || :
fi
---


You are receiving this mail because: