[Bug 1179766] New: [rpm4.16] MozillaFirefox (and Thunderbird) fail to build with rpm 4.16
http://bugzilla.opensuse.org/show_bug.cgi?id=1179766 Bug ID: 1179766 Summary: [rpm4.16] MozillaFirefox (and Thunderbird) fail to build with rpm 4.16 Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Firefox Assignee: mozilla-bugs@suse.de Reporter: dimstar@opensuse.org QA Contact: qa-bugs@suse.de Found By: --- Blocker: --- In Staging:A we have currently RPM 4.16. Firefox (and Thunderbird) fail the build there. Firefox: https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:A... Thunderbird: https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:A... From the Firefox buildlog: [ 5617s] Processing files: MozillaFirefox-translations-common-83.0-2.1.x86_64 [ 5617s] error: Directory not found: /home/abuild/rpmbuild/BUILDROOT/MozillaFirefox-83.0-2.1.x86_64/usr/lib64/firefox/browser/extensions [ 5617s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/MozillaFirefox-83.0-2.1.x86_64/usr/lib64/firefox/browser/extensions/langpack-ar@firefox.mozilla.org.xpi [ 5617s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/MozillaFirefox-83.0-2.1.x86_64/usr/lib64/firefox/browser/extensions/langpack-ca@firefox.mozilla.org.xpi [ 5617s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/MozillaFirefox-83.0-2.1.x86_64/usr/lib64/firefox/browser/extensions/langpack-da@firefox.mozilla.org.xpi [ 5617s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/MozillaFirefox-83.0-2.1.x86_64/usr/lib64/firefox/browser/extensions/langpack-de@firefox.mozilla.org.xpi [ 5617s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/MozillaFirefox-83.0-2.1.x86_64/usr/lib64/firefox/browser/extensions/langpack-el@firefox.mozilla.org.xpi [ 5617s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/MozillaFirefox-83.0-2.1.x86_64/usr/lib64/firefox/browser/extensions/langpack-en-GB@firefox.mozilla.org.xpi [ 5617s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/MozillaFirefox-83.0-2.1.x86_64/usr/lib64/firefox/browser/extensions/langpack-es-AR@firefox.mozilla.org.xpi [ 5617s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/MozillaFirefox-83.0-2.1.x86_64/usr/lib64/firefox/browser/extensions/langpack-cs@firefox.mozilla.org.xpi [ 5617s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/MozillaFirefox-83.0-2.1.x86_64/usr/lib64/firefox/browser/extensions/langpack-es-CL@firefox.mozilla.org.xpi [ 5617s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/MozillaFirefox-83.0-2.1.x86_64/usr/lib64/firefox/browser/extensions/langpack-es-ES@firefox.mozilla.org.xpi [ 5617s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/MozillaFirefox-83.0-2.1.x86_64/usr/lib64/firefox/browser/extensions/langpack-fi@firefox.mozilla.org.xpi [ 5617s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/MozillaFirefox-83.0-2.1.x86_64/usr/lib64/firefox/browser/extensions/langpack-fr@firefox.mozilla.org.xpi [ 5617s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/MozillaFirefox-83.0-2.1.x86_64/usr/lib64/firefox/browser/extensions/langpack-hu@firefox.mozilla.org.xpi [ 5617s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/MozillaFirefox-83.0-2.1.x86_64/usr/lib64/firefox/browser/extensions/langpack-it@firefox.mozilla.org.xpi [ 5617s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/MozillaFirefox-83.0-2.1.x86_64/usr/lib64/firefox/browser/extensions/langpack-ja@firefox.mozilla.org.xpi [ 5617s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/MozillaFirefox-83.0-2.1.x86_64/usr/lib64/firefox/browser/extensions/langpack-ko@firefox.mozilla.org.xpi [ 5617s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/MozillaFirefox-83.0-2.1.x86_64/usr/lib64/firefox/browser/extensions/langpack-nl@firefox.mozilla.org.xpi [ 5617s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/MozillaFirefox-83.0-2.1.x86_64/usr/lib64/firefox/browser/extensions/langpack-nb-NO@firefox.mozilla.org.xpi [ 5617s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/MozillaFirefox-83.0-2.1.x86_64/usr/lib64/firefox/browser/extensions/langpack-pl@firefox.mozilla.org.xpi [ 5617s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/MozillaFirefox-83.0-2.1.x86_64/usr/lib64/firefox/browser/extensions/langpack-pt-BR@firefox.mozilla.org.xpi [ 5617s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/MozillaFirefox-83.0-2.1.x86_64/usr/lib64/firefox/browser/extensions/langpack-pt-PT@firefox.mozilla.org.xpi [ 5617s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/MozillaFirefox-83.0-2.1.x86_64/usr/lib64/firefox/browser/extensions/langpack-ru@firefox.mozilla.org.xpi [ 5617s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/MozillaFirefox-83.0-2.1.x86_64/usr/lib64/firefox/browser/extensions/langpack-sv-SE@firefox.mozilla.org.xpi [ 5617s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/MozillaFirefox-83.0-2.1.x86_64/usr/lib64/firefox/browser/extensions/langpack-zh-CN@firefox.mozilla.org.xpi [ 5617s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/MozillaFirefox-83.0-2.1.x86_64/usr/lib64/firefox/browser/extensions/langpack-zh-TW@firefox.mozilla.org.xpi -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1179766 http://bugzilla.opensuse.org/show_bug.cgi?id=1179766#c1 --- Comment #1 from Dominique Leuenberger <dimstar@opensuse.org> --- At least for Firefox, I can see that there are at least two points where buildroot is being modified during the %build phase - which is no longer allowed in RPM 4.6 (modifying buildroot is %install phase) The two points are: 1) mkdir -p %{buildroot}%{progdir}/browser/extensions 2) sed -r '/^(ja-JP-mac|ga-IE|en-US|)$/d;s/ .*$//' $RPM_BUILD_DIR/%{srcname}-%{orig_version}/browser/locales/shipped-locales \ | xargs -n 1 %{?njobs:-P %njobs} -I {} /bin/sh -c ' locale=$1 cp ${MOZCONFIG}_LANG ${MOZCONFIG}_$locale sed -i "s|obj_LANG|obj_$locale|" ${MOZCONFIG}_$locale export MOZCONFIG=${MOZCONFIG}_$locale # nsinstall is needed for langpack-build. It is already built by `./mach build`, but building it again is very fast ./mach build config/nsinstall langpack-$locale cp -L ../obj_$locale/dist/linux-*/xpi/firefox-%{orig_version}.$locale.langpack.xpi \ %{buildroot}%{progdir}/browser/extensions/langpack-$locale@firefox.mozilla.org.xpi # remove prefs, profile defaults, and hyphenation from langpack #rm -rf %{buildroot}%{progdir}/browser/extensions/langpack-$locale@firefox.mozilla.org/defaults #rm -rf %{buildroot}%{progdir}/browser/extensions/langpack-$locale@firefox.mozilla.org/hyphenation # check against the fixed common list and sort into the right filelist _matched=0 for _match in ar ca cs da de el en-GB es-AR es-CL es-ES fi fr hu it ja ko nb-NO nl pl pt-BR pt-PT ru sv-SE zh-CN zh-TW; do [ "$_match" = "$locale" ] && _matched=1 done [ $_matched -eq 1 ] && _l10ntarget=common || _l10ntarget=other echo %{progdir}/browser/extensions/langpack-$locale@firefox.mozilla.org.xpi \ >> %{_tmppath}/translations.$_l10ntarget ' -- {} -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1179766 Dominique Leuenberger <dimstar@opensuse.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cgrobertson@suse.com, | |martin.sirringhaus@suse.com -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1179766 http://bugzilla.opensuse.org/show_bug.cgi?id=1179766#c2 --- Comment #2 from Martin Sirringhaus <martin.sirringhaus@suse.com> --- That is in the %build-section because it builds the langpacks. Building them in %install doesn't feel right. So I will try to build them in %build, copy them somewhere in `$RPM_BUILD_DIR` rather then buildroot and copy again during %install (including doing the mkdir) -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1179766 http://bugzilla.opensuse.org/show_bug.cgi?id=1179766#c3 --- Comment #3 from Dominique Leuenberger <dimstar@opensuse.org> --- (In reply to Martin Sirringhaus from comment #2)
That is in the %build-section because it builds the langpacks. Building them in %install doesn't feel right.
So I will try to build them in %build, copy them somewhere in `$RPM_BUILD_DIR` rather then buildroot and copy again during %install (including doing the mkdir)
Right; %build to build, %install to install (as it's in the name :) ) Maybe you can skip the first copy in your proposal? and copy from wherever they are being created in %build during %install? The data from %build is not being lost after all (or do we lose the information about available files somehow?) -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1179766 http://bugzilla.opensuse.org/show_bug.cgi?id=1179766#c4 --- Comment #4 from Martin Sirringhaus <martin.sirringhaus@suse.com> --- For ESR, we remove the whole obj-dir for each langpack after build because we very often run out of disk space. I thought its in the regular Firefox spec as well, but apparently it isn't. So we could either do that here as well and have an additional copy, or hope disk space will be sufficient and copy directly in %install. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1179766 http://bugzilla.opensuse.org/show_bug.cgi?id=1179766#c5 --- Comment #5 from Dominique Leuenberger <dimstar@opensuse.org> --- The constraint files has: <hardware> <disk> <size unit="G">36</size> </disk> With a few overrides: aarch64: <size unit="G">12</size> armv6l/armv7l: <size unit="G">12</size> ppc64/ppc64le: <size unit="G">25</size> Those are the constraints to find a worker that matches the requirement. Of course, the lower the limits, the more workers can be found to satisfy the build -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1179766 http://bugzilla.opensuse.org/show_bug.cgi?id=1179766#c6 --- Comment #6 from Martin Sirringhaus <martin.sirringhaus@suse.com> --- Created attachment 844400 --> http://bugzilla.opensuse.org/attachment.cgi?id=844400&action=edit Try to fix rpm issue Hi, mozilla:Factory has the old, still working rpm version, so I can't really test this. Could you try this patch directly and see if it fixes the build? -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1179766 http://bugzilla.opensuse.org/show_bug.cgi?id=1179766#c7 --- Comment #7 from Dominique Leuenberger <dimstar@opensuse.org> --- (In reply to Martin Sirringhaus from comment #6)
Created attachment 844400 [details] Try to fix rpm issue
Hi, mozilla:Factory has the old, still working rpm version, so I can't really test this.
Could you try this patch directly and see if it fixes the build?
You can do
osc build --alternative-project=openSUSE:Factory:Staging:A --clean
to get a buildroot setup with the Staging area including RPM4.16 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1179766 http://bugzilla.opensuse.org/show_bug.cgi?id=1179766#c8 Andreas Stieger <Andreas.Stieger@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |Andreas.Stieger@gmx.de Resolution|--- |FIXED --- Comment #8 from Andreas Stieger <Andreas.Stieger@gmx.de> --- Factory has rpm 4.17.0, assuming this is either fixed or no longer needed -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠suse.com