https://bugzilla.novell.com/show_bug.cgi?id=836235 https://bugzilla.novell.com/show_bug.cgi?id=836235#c13 Russell Miller <russellx.j.miller@intel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |russellx.j.miller@intel.com --- Comment #13 from Russell Miller <russellx.j.miller@intel.com> 2013-12-04 18:24:18 UTC --- ok, reading back on your reason, I think I might understand your confusion. Let me explain what I was trying to do? The issue is that $ipmioutput contains a string called "Fatal IO Error". This creates a situation where $ipmioutput contains a string "Error", which is the exact string that you are checking for to see if there is an error ($errorstring). This is probably not the ideal way of doing this for exactly the reason that we're encountering, but I understand that you may not have time to completely rework that. You seem to be treating $errorstring as the actual error output from ipmitool, but it isn't. $ipmioutput is that output. $errorstring is just the string you are checking for in the $ipmioutput string. So I believe that your patch operates on the wrong variable. What my patch does is substitutes out the "Error" string in $ipmioutput so it doesn't trip the detection algorithm. Can you please do me a favor and explain to me how your patch will solve the problem, in light of my above explanation? I understand that I'm a new contributor, but I really would not like to have to go through this process again on next release. :) Thanks. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.