[Bug 836235] New: nagios-plugins-ipmi-sensor1 not working on Dell
https://bugzilla.novell.com/show_bug.cgi?id=836235 https://bugzilla.novell.com/show_bug.cgi?id=836235#c0 Summary: nagios-plugins-ipmi-sensor1 not working on Dell Classification: openSUSE Product: openSUSE 12.3 Version: Final Platform: x86-64 OS/Version: openSUSE 12.3 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: russellx.j.miller@intel.com QAContact: qa-bugs@suse.de Found By: --- Blocker: --- User-Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; WOW64; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; NET CLR 1.1.4322; .NET4.0C; .NET4.0E; InfoPath.3) On a Del PowerEdge R710, /usr/lib/nagios/plugins/check_ipmi_sensor1 fails using -t all. This is because it returns the following: Fatal IO Error | 27h | ns | 34.1 | No Reading The code: errorstring="Error" shopt -s nocasematch if [[ "$ipmioutput" =~ "${errorstring}" ]] then checkhint="check BMC availability/username/password" echo "ipmitool output contains \"$errorstring\" - $checkhint" exit 2 fi shopt -u nocasematch This happens immediately after the check and before the exclusion rule is run, so it's impossible to exclude the offending variable. Suggested fix: Move the "Error" check to after the exclusion, or make the string a little more narrow. Reproducible: Always Steps to Reproduce: 1. run the script on a PowerEdge R710 using -t all. Actual Results: Run the script, says "Error", and fails. Expected Results: Succeeded, there was no error. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=836235
https://bugzilla.novell.com/show_bug.cgi?id=836235#c
FeiXiang Zhang
https://bugzilla.novell.com/show_bug.cgi?id=836235
https://bugzilla.novell.com/show_bug.cgi?id=836235#c
Christian Schneemann
https://bugzilla.novell.com/show_bug.cgi?id=836235
https://bugzilla.novell.com/show_bug.cgi?id=836235#c1
--- Comment #1 from Lars Vogdt
https://bugzilla.novell.com/show_bug.cgi?id=836235
https://bugzilla.novell.com/show_bug.cgi?id=836235#c2
Lars Vogdt
https://bugzilla.novell.com/show_bug.cgi?id=836235
https://bugzilla.novell.com/show_bug.cgi?id=836235#c
Lars Vogdt
https://bugzilla.novell.com/show_bug.cgi?id=836235
https://bugzilla.novell.com/show_bug.cgi?id=836235#c3
--- Comment #3 from Lars Vogdt
https://bugzilla.novell.com/show_bug.cgi?id=836235
https://bugzilla.novell.com/show_bug.cgi?id=836235#c4
--- Comment #4 from Russell Miller
https://bugzilla.novell.com/show_bug.cgi?id=836235
https://bugzilla.novell.com/show_bug.cgi?id=836235#c5
Lars Vogdt
I'll take a look as soon as I get a chance. My apologizes, my hair (what's left of it) has been on fire the past week or two.
Sad to hear. Get well soon! No need to hurry - I hope the patch already fixes your problem, but I will leave the bug open until you had the time to cross check. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=836235
https://bugzilla.novell.com/show_bug.cgi?id=836235#c6
--- Comment #6 from Russell Miller
https://bugzilla.novell.com/show_bug.cgi?id=836235
https://bugzilla.novell.com/show_bug.cgi?id=836235#c7
Russell Miller
https://bugzilla.novell.com/show_bug.cgi?id=836235
https://bugzilla.novell.com/show_bug.cgi?id=836235#c8
--- Comment #8 from Russell Miller
ipmioutput=${ipmioutput/Fatal IO Error/Fatal IO}
This just gets rid of the "Fatal IO Error" string so that it doesn't get in the way. Kind of hacky but at least it's mostly guaranteed to do the right thing. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=836235
https://bugzilla.novell.com/show_bug.cgi?id=836235#c9
--- Comment #9 from Russell Miller
ipmioutput=${ipmioutput/Fatal IO Error/Fatal IO Err}
This one might even be better - because it seems like Dell and ipmitool say "Err" everywhere else in the description, but in this particular situation they say "Error". Or there are probably a hundred different ways to do it, but the long and short is, it seems to be much simpler to get rid of the offending string than try to work around it. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=836235
https://bugzilla.novell.com/show_bug.cgi?id=836235#c10
Lars Vogdt
https://bugzilla.novell.com/show_bug.cgi?id=836235
https://bugzilla.novell.com/show_bug.cgi?id=836235#c11
--- Comment #11 from Russell Miller
https://bugzilla.novell.com/show_bug.cgi?id=836235
https://bugzilla.novell.com/show_bug.cgi?id=836235#c12
Russell Miller
https://bugzilla.novell.com/show_bug.cgi?id=836235
https://bugzilla.novell.com/show_bug.cgi?id=836235#c13
Russell Miller
participants (1)
-
bugzilla_noreply@novell.com