https://bugzilla.novell.com/show_bug.cgi?id=732898 https://bugzilla.novell.com/show_bug.cgi?id=732898#c5 --- Comment #5 from Michael Gorse <mgorse@suse.com> 2011-11-29 01:49:21 UTC --- (In reply to comment #3)
+#include <dbus/dbus.h>
Including without checking if dbus is enabled/available? That might work in our build configuration but usually I'd like to have patches which could be applied and do the right thing for everyone.
Right. Thanks for the catch. I've updated the patch on the upstream bug and added the check in a couple places where it was missing.
-static bool sATKChecked = false; +static PRBool sATKChecked = PR_FALSE;
Why that? Starting with Firefox 10 PRBool is not used in the mozilla tree (minus nspr/nss) anymore intentionally.
Looks like I was a bit hasty/over-zealous there; I was trying to make sure it would build, since I was backporting to Firefox 8, but that change at least wasn't needed.
I'm going to add the patch to the beta builds of Firefox 9 and Thunderbird 9 for now. Those are to be released December, 20th Or do you think we should release an official update based on FF8 and TB8 earlier?
Hmm; good question. If we have any other reason for pushing an update, then I think it would be good for it to be included, at least. Btw, is there a good way to test the beta package on 12.1 without installing factory / factory packages? Even the "12.1" package in that repository wants mozilla-nss 3.13, where 12.1 has 3.12, and the repository doesn't seem to include a mozilla-nss package. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.